⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.
TypeScript honoissue-managementissue-trackerjira-alternativekanbanlinear-alternativemcpproject-managementreactself-hostedtypescript
fix(admin): don't warn about upload-only storage on the overview
Tinb6dfee617499
diff --git a/apps/api/src/admin/overview/configuration-warnings.test.ts b/apps/api/src/admin/overview/configuration-warnings.test.tsnew file mode 100644index 000000000..9068299c6--- /dev/null+++ b/apps/api/src/admin/overview/configuration-warnings.test.ts@@ -0,0 +1,33 @@+import { describe, expect, it } from "vite-plus/test";+import { configurationWarnings } from "./configuration-warnings";++type Services = Parameters<typeof configurationWarnings>[0];++const services = (storage: Partial<Services["storage"]>) =>+ ({+ email: { configured: true, status: "ok" },+ redis: { status: "not_configured" },+ storage: { configured: true, status: "ok", ...storage },+ }) as unknown as Services;++describe("configurationWarnings", () => {+ it("doesn't warn about upload-only storage that answers 403", () => {+ expect(+ configurationWarnings(+ services({ status: "warning", errorCode: "HTTP_403" }),+ false,+ 2,+ ),+ ).toEqual([]);+ });++ it("warns when storage is unreachable", () => {+ expect(+ configurationWarnings(+ services({ status: "down", errorCode: "ECONNREFUSED" }),+ false,+ 2,+ ),+ ).toEqual(["storage_unreachable"]);+ });+});diff --git a/apps/api/src/admin/overview/configuration-warnings.ts b/apps/api/src/admin/overview/configuration-warnings.tsindex fff397701..30b09371e 100644--- a/apps/api/src/admin/overview/configuration-warnings.ts+++ b/apps/api/src/admin/overview/configuration-warnings.ts@@ -17,10 +17,8 @@ export function configurationWarnings(}if (services.storage.errorCode === "INCOMPLETE_CONFIG")warnings.push("storage_incomplete");- else if (- services.storage.status === "down" ||- services.storage.status === "warning"- ) {+ // A 403 "warning" is expected for upload-only bucket policies.+ else if (services.storage.status === "down") {warnings.push("storage_unreachable");}if (registration && !services.email.configured)