Skip to content

armgit / kaneo

Public Imported from GitHub
0

⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.

feat(rbac): gate workspace UI on server-checked permissions

Andrejc41443276ca7
diff --git a/apps/api/src/auth.ts b/apps/api/src/auth.ts
index 050a236d9..eaa9e584f 100644
--- a/apps/api/src/auth.ts
+++ b/apps/api/src/auth.ts
@@ -4,7 +4,12 @@ import {
sendOtpEmail,
sendWorkspaceInvitationEmail,
} from "@kaneo/email";
-import { ac, admin, member, owner, viewer } from "@kaneo/permissions";
+import {
+ ac,
+ DEFAULT_ROLE_NAMES,
+ defaultRolePayloads,
+ owner,
+} from "@kaneo/permissions";
import bcrypt from "bcrypt";
import { betterAuth } from "better-auth";
import { drizzleAdapter } from "better-auth/adapters/drizzle";
@@ -237,7 +242,13 @@ export const auth = betterAuth({
// `AccessControl` type. Widen via an explicit cast so the plugin
// accepts our custom statement.
ac: ac as unknown as AccessControl,
- roles: { viewer, member, admin, owner },
+ // Only `owner` stays static so its permissions can never be edited away
+ // from the workspace creator. `viewer`, `member`, and `admin` are
+ // seeded into `workspace_role` per workspace and resolved via
+ // dynamic access control, so admins can fully override (replace) their
+ // permissions per workspace. See `seedDefaultWorkspaceRoles` + the
+ // afterCreateOrganization hook.
+ roles: { owner },
dynamicAccessControl: {
enabled: true,
maximumRolesPerOrganization: 25,
@@ -288,6 +299,41 @@ export const auth = betterAuth({
allowUserToCreateOrganization: true,
organizationHooks: {
afterCreateOrganization: async ({ organization, user }) => {
+ // Seed the editable default roles for this workspace. Each
+ // role's permissions are derived from the compiled-in defaults
+ // in `@kaneo/permissions`; admins can later replace them in the
+ // Roles UI. We skip names that somehow already exist (this hook
+ // is best-effort idempotent — the boot-time backfill is the
+ // belt-and-braces path).
+ try {
+ const existing = await db
+ .select({ role: schema.workspaceRoleTable.role })
+ .from(schema.workspaceRoleTable)
+ .where(
+ eq(schema.workspaceRoleTable.workspaceId, organization.id),
+ );
+ const taken = new Set(existing.map((r) => r.role));
+ const now = new Date();
+ const rows = DEFAULT_ROLE_NAMES.filter(
+ (name) => !taken.has(name),
+ ).map((name) => ({
+ workspaceId: organization.id,
+ role: name,
+ permission: JSON.stringify(defaultRolePayloads[name]),
+ createdAt: now,
+ updatedAt: now,
+ }));
+ if (rows.length > 0) {
+ await db.insert(schema.workspaceRoleTable).values(rows);
+ }
+ } catch (error) {
+ console.error(
+ "Failed to seed default workspace roles for workspace",
+ organization.id,
+ error,
+ );
+ }
+
publishEvent("workspace.created", {
workspaceId: organization.id,
workspaceName: organization.name,
diff --git a/apps/api/src/index.ts b/apps/api/src/index.ts
index c623ec103..569024aac 100644
--- a/apps/api/src/index.ts
+++ b/apps/api/src/index.ts
@@ -69,6 +69,7 @@ import {
normalizeNullableSchemasForOpenApi30,
normalizeOrganizationAuthOperations,
} from "./utils/openapi-spec";
+import { seedDefaultWorkspaceRoles } from "./utils/seed-default-workspace-roles";
import { validateWorkspaceAccess } from "./utils/validate-workspace-access";
import workflowRule from "./workflow-rule";
import workspace from "./workspace";
@@ -645,6 +646,7 @@ export async function runStartupTasks() {
await migrateNotificationPreferencesSchema();
await migrateGitHubIntegration();
await migrateColumns();
+ await seedDefaultWorkspaceRoles();
initializePlugins();
initializeScheduler();
diff --git a/apps/api/src/utils/require-workspace-permission.ts b/apps/api/src/utils/require-workspace-permission.ts
index 62fd8e31a..c585f31c2 100644
--- a/apps/api/src/utils/require-workspace-permission.ts
+++ b/apps/api/src/utils/require-workspace-permission.ts
@@ -117,9 +117,15 @@ export function requireWorkspacePermission(permissions: PermissionMap) {
throw new HTTPException(403, { message: "Insufficient permissions" });
}
+ // Prefer the DB row when present so admin-edited defaults
+ // (viewer/member/admin) take effect immediately. Falls back to the
+ // compiled-in static definitions only when no row exists — protects
+ // viewer/member/admin users from a 403 if their workspace somehow
+ // missed the seed (e.g., seed failed during workspace creation and
+ // the boot-time backfill hasn't run yet).
const statements =
- builtInRoleStatements(member.role) ??
- (await customRoleStatements(workspaceId, member.role));
+ (await customRoleStatements(workspaceId, member.role)) ??
+ builtInRoleStatements(member.role);
if (!statements || !satisfies(statements, permissions)) {
throw new HTTPException(403, { message: "Insufficient permissions" });
diff --git a/apps/api/src/utils/seed-default-workspace-roles.ts b/apps/api/src/utils/seed-default-workspace-roles.ts
new file mode 100644
index 000000000..ff25ec5fe
--- /dev/null
+++ b/apps/api/src/utils/seed-default-workspace-roles.ts
@@ -0,0 +1,96 @@
+import { DEFAULT_ROLE_NAMES, defaultRolePayloads } from "@kaneo/permissions";
+import { and, inArray, sql } from "drizzle-orm";
+import db, { schema } from "../database";
+
+/**
+ * Backfill the editable default roles (viewer/member/admin) for every
+ * workspace that's missing them. Runs on API startup after Drizzle
+ * migrations.
+ *
+ * These three roles used to be static (compiled into better-auth's
+ * `roles` config). They were converted to DB rows so admins can override
+ * them per workspace — but that means existing workspaces, which were
+ * created before the switch, have no rows yet. Without this backfill,
+ * better-auth's dynamic-access-control resolution would treat them as
+ * having an empty permission set on existing workspaces.
+ *
+ * Idempotent: only inserts rows that aren't already present.
+ */
+export async function seedDefaultWorkspaceRoles() {
+ try {
+ const tableExists = await db.execute(sql`
+ SELECT EXISTS (
+ SELECT 1
+ FROM information_schema.tables
+ WHERE table_name = 'workspace_role'
+ ) AS exists;
+ `);
+
+ const exists =
+ tableExists.rows[0]?.exists === true ||
+ tableExists.rows[0]?.exists === "t";
+ if (!exists) {
+ console.log(
+ "🛈 workspace_role table does not exist — skipping default-role seed.",
+ );
+ return;
+ }
+
+ const workspaces = await db
+ .select({ id: schema.workspaceTable.id })
+ .from(schema.workspaceTable);
+
+ if (workspaces.length === 0) {
+ return;
+ }
+
+ const workspaceIds = workspaces.map((w) => w.id);
+
+ const existingRows = await db
+ .select({
+ workspaceId: schema.workspaceRoleTable.workspaceId,
+ role: schema.workspaceRoleTable.role,
+ })
+ .from(schema.workspaceRoleTable)
+ .where(
+ and(
+ inArray(schema.workspaceRoleTable.workspaceId, workspaceIds),
+ inArray(
+ schema.workspaceRoleTable.role,
+ DEFAULT_ROLE_NAMES as unknown as string[],
+ ),
+ ),
+ );
+
+ const present = new Set(
+ existingRows.map((r) => `${r.workspaceId}:${r.role}`),
+ );
+
+ const now = new Date();
+ const rows: Array<typeof schema.workspaceRoleTable.$inferInsert> = [];
+ for (const workspaceId of workspaceIds) {
+ for (const name of DEFAULT_ROLE_NAMES) {
+ if (present.has(`${workspaceId}:${name}`)) continue;
+ rows.push({
+ workspaceId,
+ role: name,
+ permission: JSON.stringify(defaultRolePayloads[name]),
+ createdAt: now,
+ updatedAt: now,
+ });
+ }
+ }
+
+ if (rows.length === 0) {
+ return;
+ }
+
+ await db.insert(schema.workspaceRoleTable).values(rows);
+ console.log(
+ `✅ Seeded ${rows.length} default workspace role row(s) across ${workspaceIds.length} workspace(s).`,
+ );
+ } catch (error) {
+ console.error("❌ Failed to seed default workspace roles:", error);
+ throw error;
+ }
+}
diff --git a/apps/web/src/components/bulk-selection/backlog-bulk-toolbar.tsx b/apps/web/src/components/bulk-selection/backlog-bulk-toolbar.tsx
index 13e4dd29f..4a923fbd2 100644
--- a/apps/web/src/components/bulk-selection/backlog-bulk-toolbar.tsx
+++ b/apps/web/src/components/bulk-selection/backlog-bulk-toolbar.tsx
@@ -48,6 +48,7 @@ import { useBulkOperations } from "@/hooks/mutations/task/use-bulk-operations";
import useGetLabelsByWorkspace from "@/hooks/queries/label/use-get-labels-by-workspace";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
import { useGetActiveWorkspaceUsers } from "@/hooks/queries/workspace-users/use-get-active-workspace-users";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { getColumnIcon } from "@/lib/column";
import { getPriorityLabel } from "@/lib/i18n/domain";
import { getPriorityIcon } from "@/lib/priority";
@@ -102,6 +103,9 @@ function BacklogBulkToolbar() {
const { data: workspaceLabels = [] } = useGetLabelsByWorkspace(
workspace?.id ?? "",
);
+ const { canManageTasks, canAssignTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
+ const canAssign = canAssignTasks();
const [isActionsOpen, setIsActionsOpen] = useState(false);
const [isDatePickerOpen, setIsDatePickerOpen] = useState(false);
@@ -254,9 +258,10 @@ function BacklogBulkToolbar() {
[bulkDueDate, selectedTaskIds, selectedCount, clearSelection, t],
);
- const groupedItems = useMemo<BacklogActionGroup[]>(
- () => [
- {
+ const groupedItems = useMemo<BacklogActionGroup[]>(() => {
+ const groups: BacklogActionGroup[] = [];
+ if (canEdit) {
+ groups.push({
value: "actions",
label: t("tasks:bulk.actions"),
items: [
@@ -277,8 +282,10 @@ function BacklogBulkToolbar() {
},
},
],
- },
- {
+ });
+ }
+ if (canAssign) {
+ groups.push({
value: "assign",
label: t("tasks:bulk.assignTo"),
items: (workspaceUsers?.members ?? []).map((member) => ({
@@ -299,8 +306,10 @@ function BacklogBulkToolbar() {
void handleBulkAssign(member.userId);
},
})),
- },
- {
+ });
+ }
+ if (canEdit) {
+ groups.push({
value: "priority",
label: t("tasks:bulk.setPriority"),
items: priorityOptions.map((opt) => ({
@@ -311,8 +320,8 @@ function BacklogBulkToolbar() {
void handleBulkPriority(opt.value);
},
})),
- },
- {
+ });
+ groups.push({
value: "label",
label: t("tasks:bulk.addLabel"),
items: uniqueLabels.map((label) => ({
@@ -332,22 +341,25 @@ function BacklogBulkToolbar() {
void handleBulkAddLabel(label.id);
},
})),
- },
- ],
- [
- workspaceUsers?.members,
- uniqueLabels,
- handleBulkDelete,
- handleBulkArchive,
- handleBulkAssign,
- handleBulkPriority,
- handleBulkAddLabel,
- priorityOptions,
- t,
- ],
- );
+ });
+ }
+ return groups;
+ }, [
+ canEdit,
+ canAssign,
+ workspaceUsers?.members,
+ uniqueLabels,
+ handleBulkDelete,
+ handleBulkArchive,
+ handleBulkAssign,
+ handleBulkPriority,
+ handleBulkAddLabel,
+ priorityOptions,
+ t,
+ ]);
if (selectedCount === 0) return null;
+ if (!canEdit && !canAssign) return null;
return (
<div className="fixed bottom-6 left-1/2 transform -translate-x-1/2 z-50">
@@ -358,74 +370,82 @@ function BacklogBulkToolbar() {
</span>
</ToolbarGroup>
- <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
-
- <ToolbarGroup>
- <DropdownMenu>
- <DropdownMenuTrigger asChild>
- <Button size="sm" variant="ghost" className="gap-1.5">
- <ArrowUpToLine className="size-4" />
- {t("tasks:bulk.moveToBoard")}
- <ChevronDown className="size-3 opacity-60" />
- </Button>
- </DropdownMenuTrigger>
- <DropdownMenuContent align="center" className="w-48">
- {(project?.columns ?? []).map((col) => (
- <DropdownMenuItem
- key={col.id}
- onClick={() => handleMoveToBoard(col.id)}
- >
- {getColumnIcon(col.id, col.isFinal)}
- <span className="ml-2">{col.name}</span>
- </DropdownMenuItem>
- ))}
- </DropdownMenuContent>
- </DropdownMenu>
- </ToolbarGroup>
+ {canEdit && (
+ <>
+ <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
+ <ToolbarGroup>
+ <DropdownMenu>
+ <DropdownMenuTrigger asChild>
+ <Button size="sm" variant="ghost" className="gap-1.5">
+ <ArrowUpToLine className="size-4" />
+ {t("tasks:bulk.moveToBoard")}
+ <ChevronDown className="size-3 opacity-60" />
+ </Button>
+ </DropdownMenuTrigger>
+ <DropdownMenuContent align="center" className="w-48">
+ {(project?.columns ?? []).map((col) => (
+ <DropdownMenuItem
+ key={col.id}
+ onClick={() => handleMoveToBoard(col.id)}
+ >
+ {getColumnIcon(col.id, col.isFinal)}
+ <span className="ml-2">{col.name}</span>
+ </DropdownMenuItem>
+ ))}
+ </DropdownMenuContent>
+ </DropdownMenu>
+ </ToolbarGroup>
- <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
+ <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
+ <ToolbarGroup>
+ <Popover
+ open={isDatePickerOpen}
+ onOpenChange={setIsDatePickerOpen}
+ >
+ <PopoverTrigger asChild>
+ <Button size="sm" variant="ghost">
+ <CalendarIcon className="size-4" />
+ {t("tasks:bulk.setDueDate")}
+ </Button>
+ </PopoverTrigger>
+ <PopoverContent className="p-0" align="center">
+ <Calendar
+ mode="single"
+ onSelect={handleBulkDueDate}
+ className="w-full bg-popover"
+ />
+ <div className="p-0 border-t border-border">
+ <Button
+ variant="ghost"
+ size="sm"
+ className="w-full justify-start gap-2 text-muted-foreground hover:text-foreground rounded-none"
+ onClick={() => handleBulkDueDate(undefined)}
+ >
+ <X className="h-4 w-4" />
+ {t("tasks:dueDate.clear")}
+ </Button>
+ </div>
+ </PopoverContent>
+ </Popover>
+ </ToolbarGroup>
+ </>
+ )}
- <ToolbarGroup>
- <Popover open={isDatePickerOpen} onOpenChange={setIsDatePickerOpen}>
- <PopoverTrigger asChild>
- <Button size="sm" variant="ghost">
- <CalendarIcon className="size-4" />
- {t("tasks:bulk.setDueDate")}
+ {groupedItems.length > 0 && (
+ <>
+ <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
+ <ToolbarGroup>
+ <Button
+ size="sm"
+ variant="ghost"
+ onClick={() => setIsActionsOpen(true)}
+ >
+ <Menu className="size-4" />
+ {t("tasks:bulk.actions")}
</Button>
- </PopoverTrigger>
- <PopoverContent className="p-0" align="center">
- <Calendar
- mode="single"
- onSelect={handleBulkDueDate}
- className="w-full bg-popover"
- />
- <div className="p-0 border-t border-border">
- <Button
- variant="ghost"
- size="sm"
- className="w-full justify-start gap-2 text-muted-foreground hover:text-foreground rounded-none"
- onClick={() => handleBulkDueDate(undefined)}
- >
- <X className="h-4 w-4" />
- {t("tasks:dueDate.clear")}
- </Button>
- </div>
- </PopoverContent>
- </Popover>
- </ToolbarGroup>
-
- <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
-
- <ToolbarGroup>
- <Button
- size="sm"
- variant="ghost"
- onClick={() => setIsActionsOpen(true)}
- >
- <Menu className="size-4" />
- {t("tasks:bulk.actions")}
- </Button>
- </ToolbarGroup>
+ </ToolbarGroup>
+ </>
+ )}
<ToolbarSeparator orientation="vertical" className="my-1 h-5" />
diff --git a/apps/web/src/components/bulk-selection/bulk-toolbar.tsx b/apps/web/src/components/bulk-selection/bulk-toolbar.tsx
index ffde1a2f3..188b1e1e7 100644
--- a/apps/web/src/components/bulk-selection/bulk-toolbar.tsx
+++ b/apps/web/src/components/bulk-selection/bulk-toolbar.tsx
@@ -41,6 +41,7 @@ import { useBulkOperations } from "@/hooks/mutations/task/use-bulk-operations";
import useGetLabelsByWorkspace from "@/hooks/queries/label/use-get-labels-by-workspace";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
import { useGetActiveWorkspaceUsers } from "@/hooks/queries/workspace-users/use-get-active-workspace-users";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { getColumnIcon } from "@/lib/column";
import { getPriorityLabel } from "@/lib/i18n/domain";
import { getPriorityIcon } from "@/lib/priority";
@@ -96,6 +97,9 @@ function BulkToolbar() {
const { data: workspaceLabels = [] } = useGetLabelsByWorkspace(
workspace?.id ?? "",
);
+ const { canManageTasks, canAssignTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
+ const canAssign = canAssignTasks();
const [isActionsOpen, setIsActionsOpen] = useState(false);
const [isDatePickerOpen, setIsDatePickerOpen] = useState(false);
@@ -259,9 +263,10 @@ function BulkToolbar() {
[bulkDueDate, selectedTaskIds, selectedCount, clearSelection, t],
);
- const groupedItems = useMemo<BulkActionGroup[]>(
- () => [
- {
+ const groupedItems = useMemo<BulkActionGroup[]>(() => {
+ const groups: BulkActionGroup[] = [];
+ if (canEdit) {
+ groups.push({
value: "actions",
label: t("tasks:bulk.actions"),
items: [
@@ -282,8 +287,8 @@ function BulkToolbar() {
},
},
],
- },
- {
+ });
+ groups.push({
value: "status",
label: t("tasks:bulk.changeStatus"),
items: (project?.columns ?? []).map((col) => ({
@@ -294,8 +299,10 @@ function BulkToolbar() {
void handleBulkChangeStatus(col.id);
},
})),
- },
- {
+ });
+ }
+ if (canAssign) {
+ groups.push({
value: "assign",
label: t("tasks:bulk.assignTo"),
items: (workspaceUsers?.members ?? []).map((member) => ({
@@ -316,8 +323,10 @@ function BulkToolbar() {
void handleBulkAssign(member.userId);
},
})),
- },
- {
+ });
+ }
+ if (canEdit) {
+ groups.push({
value: "priority",
label: t("tasks:bulk.setPriority"),
items: priorityOptions.map((opt) => ({
@@ -328,8 +337,8 @@ function BulkToolbar() {
void handleBulkPriority(opt.value);
},
})),
- },
- {
+ });
+ groups.push({
value: "label",
label: t("tasks:bulk.addLabel"),
items: uniqueLabels.map((label) => ({
@@ -349,24 +358,28 @@ function BulkToolbar() {
void handleBulkAddLabel(label.id);
},
})),
- },
- ],
- [
- project?.columns,
- workspaceUsers?.members,
- uniqueLabels,
- handleBulkDelete,
- handleBulkArchive,
- handleBulkChangeStatus,
- handleBulkAssign,
- handleBulkPriority,
- handleBulkAddLabel,
- priorityOptions,
- t,
- ],
- );
+ });
+ }
+ return groups;
+ }, [
+ canEdit,
+ canAssign,
+ project?.columns,
+ workspaceUsers?.members,
+ uniqueLabels,
+ handleBulkDelete,
+ handleBulkArchive,
+ handleBulkChangeStatus,
+ handleBulkAssign,
+ handleBulkPriority,
+ handleBulkAddLabel,
+ priorityOptions,
+ t,
+ ]);
if (selectedCount === 0) return null;
+ // Nothing the user can do in bulk → no toolbar.
+ if (!canEdit && !canAssign) return null;
return (
<div className="fixed bottom-6 left-1/2 transform -translate-x-1/2 z-50">
@@ -377,58 +390,66 @@ function BulkToolbar() {
</span>
</ToolbarGroup>
- <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
-
- <ToolbarGroup>
- <Button size="sm" variant="ghost" onClick={handleMoveToBacklog}>
- <ArrowDownToLine className="size-4" />
- {t("tasks:bulk.moveToBacklog")}
- </Button>
- </ToolbarGroup>
-
- <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
-
- <ToolbarGroup>
- <Popover open={isDatePickerOpen} onOpenChange={setIsDatePickerOpen}>
- <PopoverTrigger asChild>
- <Button size="sm" variant="ghost">
- <CalendarIcon className="size-4" />
- {t("tasks:bulk.setDueDate")}
+ {canEdit && (
+ <>
+ <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
+ <ToolbarGroup>
+ <Button size="sm" variant="ghost" onClick={handleMoveToBacklog}>
+ <ArrowDownToLine className="size-4" />
+ {t("tasks:bulk.moveToBacklog")}
</Button>
- </PopoverTrigger>
- <PopoverContent className="p-0" align="center">
- <Calendar
- mode="single"
- onSelect={handleBulkDueDate}
- className="w-full bg-popover"
- />
- <div className="p-0 border-t border-border">
- <Button
- variant="ghost"
- size="sm"
- className="w-full justify-start gap-2 text-muted-foreground hover:text-foreground rounded-none"
- onClick={() => handleBulkDueDate(undefined)}
- >
- <X className="h-4 w-4" />
- {t("tasks:dueDate.clear")}
- </Button>
- </div>
- </PopoverContent>
- </Popover>
- </ToolbarGroup>
-
- <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
-
- <ToolbarGroup>
- <Button
- size="sm"
- variant="ghost"
- onClick={() => setIsActionsOpen(true)}
- >
- <Menu className="size-4" />
- {t("tasks:bulk.actions")}
- </Button>
- </ToolbarGroup>
+ </ToolbarGroup>
+
+ <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
+ <ToolbarGroup>
+ <Popover
+ open={isDatePickerOpen}
+ onOpenChange={setIsDatePickerOpen}
+ >
+ <PopoverTrigger asChild>
+ <Button size="sm" variant="ghost">
+ <CalendarIcon className="size-4" />
+ {t("tasks:bulk.setDueDate")}
+ </Button>
+ </PopoverTrigger>
+ <PopoverContent className="p-0" align="center">
+ <Calendar
+ mode="single"
+ onSelect={handleBulkDueDate}
+ className="w-full bg-popover"
+ />
+ <div className="p-0 border-t border-border">
+ <Button
+ variant="ghost"
+ size="sm"
+ className="w-full justify-start gap-2 text-muted-foreground hover:text-foreground rounded-none"
+ onClick={() => handleBulkDueDate(undefined)}
+ >
+ <X className="h-4 w-4" />
+ {t("tasks:dueDate.clear")}
+ </Button>
+ </div>
+ </PopoverContent>
+ </Popover>
+ </ToolbarGroup>
+ </>
+ )}
+
+ {groupedItems.length > 0 && (
+ <>
+ <ToolbarSeparator orientation="vertical" className="my-1 h-5" />
+ <ToolbarGroup>
+ <Button
+ size="sm"
+ variant="ghost"
+ onClick={() => setIsActionsOpen(true)}
+ >
+ <Menu className="size-4" />
+ {t("tasks:bulk.actions")}
+ </Button>
+ </ToolbarGroup>
+ </>
+ )}
<ToolbarSeparator orientation="vertical" className="my-1 h-5" />
diff --git a/apps/web/src/components/kanban-board/column/column-header.tsx b/apps/web/src/components/kanban-board/column/column-header.tsx
index 88f6524cf..e1d1c5e9b 100644
--- a/apps/web/src/components/kanban-board/column/column-header.tsx
+++ b/apps/web/src/components/kanban-board/column/column-header.tsx
@@ -4,6 +4,7 @@ import { useState } from "react";
import { useTranslation } from "react-i18next";
import CreateTaskModal from "@/components/shared/modals/create-task-modal";
import { useUpdateTask } from "@/hooks/mutations/task/use-update-task";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { getColumnIcon } from "@/lib/column";
import { toast } from "@/lib/toast";
import useProjectStore from "@/store/project";
@@ -18,6 +19,8 @@ export function ColumnHeader({ column }: ColumnHeaderProps) {
const { t } = useTranslation();
const { project, setProject } = useProjectStore();
const { mutate: updateTask } = useUpdateTask();
+ const { canManageTasks } = useWorkspacePermission();
+ const canTask = canManageTasks();
const [isArchiveModalOpen, setIsArchiveModalOpen] = useState(false);
const [isTaskModalOpen, setIsTaskModalOpen] = useState(false);
@@ -61,7 +64,7 @@ export function ColumnHeader({ column }: ColumnHeaderProps) {
</div>
<div className="flex items-center">
- {column.isFinal && column.tasks.length > 0 && (
+ {canTask && column.isFinal && column.tasks.length > 0 && (
<button
type="button"
onClick={() => setIsArchiveModalOpen(true)}
@@ -71,14 +74,16 @@ export function ColumnHeader({ column }: ColumnHeaderProps) {
<Archive className="w-4 h-4 text-muted-foreground" />
</button>
)}
- <button
- type="button"
- onClick={() => setIsTaskModalOpen(true)}
- className="flex items-center rounded-md px-2 py-1 text-left text-muted-foreground transition-all hover:bg-accent/50"
- title={t("tasks:kanban.addTask")}
- >
- <Plus className="w-4 h-4 text-muted-foreground" />
- </button>
+ {canTask && (
+ <button
+ type="button"
+ onClick={() => setIsTaskModalOpen(true)}
+ className="flex items-center rounded-md px-2 py-1 text-left text-muted-foreground transition-all hover:bg-accent/50"
+ title={t("tasks:kanban.addTask")}
+ >
+ <Plus className="w-4 h-4 text-muted-foreground" />
+ </button>
+ )}
</div>
<CreateTaskModal
diff --git a/apps/web/src/components/kanban-board/task-card-context-menu/task-card-context-menu-content.tsx b/apps/web/src/components/kanban-board/task-card-context-menu/task-card-context-menu-content.tsx
index 18079754a..0c8b9e163 100644
--- a/apps/web/src/components/kanban-board/task-card-context-menu/task-card-context-menu-content.tsx
+++ b/apps/web/src/components/kanban-board/task-card-context-menu/task-card-context-menu-content.tsx
@@ -21,6 +21,7 @@ import { useUpdateTaskPriority } from "@/hooks/mutations/task/use-update-task-st
import { useUpdateTaskTitle } from "@/hooks/mutations/task/use-update-task-title";
import { useGetColumns } from "@/hooks/queries/column/use-get-columns";
import { useGetActiveWorkspaceUsers } from "@/hooks/queries/workspace-users/use-get-active-workspace-users";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { getColumnIcon } from "@/lib/column";
import { generateLink } from "@/lib/generate-link";
import { getPriorityLabel } from "@/lib/i18n/domain";
@@ -70,6 +71,9 @@ export default function TaskCardContextMenuContent({
const { mutateAsync: updateTaskTitle } = useUpdateTaskTitle();
const { mutateAsync: updateTaskDescription } = useUpdateTaskDescription();
const { mutateAsync: updateTaskDueDate } = useUpdateTaskDueDate();
+ const { canManageTasks, canAssignTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
+ const canAssign = canAssignTasks();
const usersOptions = useMemo(() => {
return workspaceUsers?.members?.map((member) => ({
@@ -130,115 +134,121 @@ export default function TaskCardContextMenuContent({
<span>{t("tasks:contextMenu.copyLink")}</span>
</ContextMenuItem>
- <ContextMenuSeparator />
+ {(canEdit || canAssign) && <ContextMenuSeparator />}
- <ContextMenuSub>
- <ContextMenuSubTrigger className="gap-2">
- <span>{t("tasks:priority.label")}</span>
- </ContextMenuSubTrigger>
- <ContextMenuSubContent className="w-48">
- <ContextMenuCheckboxItem
- key="no-priority"
- checked={task.priority === "no-priority"}
- onCheckedChange={() => handleChange("priority", "no-priority")}
- closeOnClick
- className="[&_svg]:text-muted-foreground"
- >
- {getPriorityIcon("no-priority")}
- <span>{getPriorityLabel("no-priority")}</span>
- </ContextMenuCheckboxItem>
- {["low", "medium", "high", "urgent"].map((priority) => (
+ {canEdit && (
+ <ContextMenuSub>
+ <ContextMenuSubTrigger className="gap-2">
+ <span>{t("tasks:priority.label")}</span>
+ </ContextMenuSubTrigger>
+ <ContextMenuSubContent className="w-48">
<ContextMenuCheckboxItem
- key={priority}
- checked={task.priority === priority}
- onCheckedChange={() => handleChange("priority", priority)}
+ key="no-priority"
+ checked={task.priority === "no-priority"}
+ onCheckedChange={() => handleChange("priority", "no-priority")}
closeOnClick
className="[&_svg]:text-muted-foreground"
>
- {getPriorityIcon(priority)}
- <span className="capitalize">{getPriorityLabel(priority)}</span>
+ {getPriorityIcon("no-priority")}
+ <span>{getPriorityLabel("no-priority")}</span>
</ContextMenuCheckboxItem>
- ))}
- </ContextMenuSubContent>
- </ContextMenuSub>
+ {["low", "medium", "high", "urgent"].map((priority) => (
+ <ContextMenuCheckboxItem
+ key={priority}
+ checked={task.priority === priority}
+ onCheckedChange={() => handleChange("priority", priority)}
+ closeOnClick
+ className="[&_svg]:text-muted-foreground"
+ >
+ {getPriorityIcon(priority)}
+ <span className="capitalize">{getPriorityLabel(priority)}</span>
+ </ContextMenuCheckboxItem>
+ ))}
+ </ContextMenuSubContent>
+ </ContextMenuSub>
+ )}
- <ContextMenuSub>
- <ContextMenuSubTrigger>
- <span>{t("tasks:status.label")}</span>
- </ContextMenuSubTrigger>
- <ContextMenuSubContent className="w-48">
- {columns.map((col) => (
- <ContextMenuCheckboxItem
- key={col.slug}
- checked={task.status === col.slug}
- onCheckedChange={() => handleChange("status", col.slug)}
- closeOnClick
- className="[&_svg]:text-muted-foreground"
- >
- {getColumnIcon(col.slug, col.isFinal)}
- <span>{col.name}</span>
- </ContextMenuCheckboxItem>
- ))}
- </ContextMenuSubContent>
- </ContextMenuSub>
+ {canEdit && (
+ <ContextMenuSub>
+ <ContextMenuSubTrigger>
+ <span>{t("tasks:status.label")}</span>
+ </ContextMenuSubTrigger>
+ <ContextMenuSubContent className="w-48">
+ {columns.map((col) => (
+ <ContextMenuCheckboxItem
+ key={col.slug}
+ checked={task.status === col.slug}
+ onCheckedChange={() => handleChange("status", col.slug)}
+ closeOnClick
+ className="[&_svg]:text-muted-foreground"
+ >
+ {getColumnIcon(col.slug, col.isFinal)}
+ <span>{col.name}</span>
+ </ContextMenuCheckboxItem>
+ ))}
+ </ContextMenuSubContent>
+ </ContextMenuSub>
+ )}
- <ContextMenuSub>
- <ContextMenuSubTrigger>
- <span>{t("tasks:dueDate.label")}</span>
- </ContextMenuSubTrigger>
- <ContextMenuSubContent className="w-fit min-w-0 p-0">
- <div className="p-2">
- <Calendar
- mode="single"
- selected={task.dueDate ? new Date(task.dueDate) : undefined}
- onSelect={async (date) => {
- try {
- await updateTaskDueDate({
- ...task,
- dueDate: date?.toISOString() || null,
- });
- toast.success(t("tasks:dueDate.updateSuccess"));
- } catch (error) {
- toast.error(
- error instanceof Error
- ? error.message
- : t("tasks:dueDate.updateError"),
- );
- }
- }}
- className="w-full bg-popover!"
- />
- </div>
- {task.dueDate && (
- <>
- <ContextMenuSeparator />
- <ContextMenuItem
- className="gap-2 text-muted-foreground"
- onClick={async () => {
+ {canEdit && (
+ <ContextMenuSub>
+ <ContextMenuSubTrigger>
+ <span>{t("tasks:dueDate.label")}</span>
+ </ContextMenuSubTrigger>
+ <ContextMenuSubContent className="w-fit min-w-0 p-0">
+ <div className="p-2">
+ <Calendar
+ mode="single"
+ selected={task.dueDate ? new Date(task.dueDate) : undefined}
+ onSelect={async (date) => {
try {
await updateTaskDueDate({
...task,
- dueDate: null,
+ dueDate: date?.toISOString() || null,
});
- toast.success(t("tasks:dueDate.clearSuccess"));
+ toast.success(t("tasks:dueDate.updateSuccess"));
} catch (error) {
toast.error(
error instanceof Error
? error.message
- : t("tasks:dueDate.clearError"),
+ : t("tasks:dueDate.updateError"),
);
}
}}
- >
- <X className="h-4 w-4" />
- <span>{t("tasks:dueDate.clear")}</span>
- </ContextMenuItem>
- </>
- )}
- </ContextMenuSubContent>
- </ContextMenuSub>
+ className="w-full bg-popover!"
+ />
+ </div>
+ {task.dueDate && (
+ <>
+ <ContextMenuSeparator />
+ <ContextMenuItem
+ className="gap-2 text-muted-foreground"
+ onClick={async () => {
+ try {
+ await updateTaskDueDate({
+ ...task,
+ dueDate: null,
+ });
+ toast.success(t("tasks:dueDate.clearSuccess"));
+ } catch (error) {
+ toast.error(
+ error instanceof Error
+ ? error.message
+ : t("tasks:dueDate.clearError"),
+ );
+ }
+ }}
+ >
+ <X className="h-4 w-4" />
+ <span>{t("tasks:dueDate.clear")}</span>
+ </ContextMenuItem>
+ </>
+ )}
+ </ContextMenuSubContent>
+ </ContextMenuSub>
+ )}
- {usersOptions && (
+ {canAssign && usersOptions && (
<ContextMenuSub>
<ContextMenuSubTrigger>
<span>{t("tasks:assignee.label")}</span>
@@ -280,29 +290,33 @@ export default function TaskCardContextMenuContent({
</ContextMenuSub>
)}
- <ContextMenuSeparator />
+ {canEdit && (
+ <>
+ <ContextMenuSeparator />
- <ContextMenuItem onClick={() => handleChange("status", "archived")}>
- <span>{t("tasks:actions.archive")}</span>
- </ContextMenuItem>
+ <ContextMenuItem onClick={() => handleChange("status", "archived")}>
+ <span>{t("tasks:actions.archive")}</span>
+ </ContextMenuItem>
- <ContextMenuItem onClick={() => handleChange("status", "planned")}>
- <span>{t("tasks:actions.markAsPlanned")}</span>
- </ContextMenuItem>
+ <ContextMenuItem onClick={() => handleChange("status", "planned")}>
+ <span>{t("tasks:actions.markAsPlanned")}</span>
+ </ContextMenuItem>
- <ContextMenuSeparator />
+ <ContextMenuSeparator />
- <ContextMenuItem
- className="text-destructive"
- onClick={(e) => {
- e.preventDefault();
- setTimeout(() => {
- onDeleteClick();
- }, 0);
- }}
- >
- <span>{t("tasks:actions.delete")}</span>
- </ContextMenuItem>
+ <ContextMenuItem
+ className="text-destructive"
+ onClick={(e) => {
+ e.preventDefault();
+ setTimeout(() => {
+ onDeleteClick();
+ }, 0);
+ }}
+ >
+ <span>{t("tasks:actions.delete")}</span>
+ </ContextMenuItem>
+ </>
+ )}
</ContextMenuContent>
);
}
diff --git a/apps/web/src/components/nav-projects.tsx b/apps/web/src/components/nav-projects.tsx
index 0dee2623e..517b27474 100644
--- a/apps/web/src/components/nav-projects.tsx
+++ b/apps/web/src/components/nav-projects.tsx
@@ -58,9 +58,9 @@ export function NavProjects() {
});
const queryClient = useQueryClient();
const { mutateAsync: deleteProject } = useDeleteProject();
- const { canCreateProjects, checkRolePermission } = useWorkspacePermission();
+ const { canCreateProjects, canDeleteProjects } = useWorkspacePermission();
const canCreate = canCreateProjects();
- const canDeleteProject = checkRolePermission({ project: ["delete"] });
+ const canDeleteProject = canDeleteProjects();
const navigate = useNavigate();
const { workspaceId: currentWorkspaceId, projectId: currentProjectId } =
useParams({
diff --git a/apps/web/src/components/project/column-editor.tsx b/apps/web/src/components/project/column-editor.tsx
index ae81f9247..9704b8dd0 100644
--- a/apps/web/src/components/project/column-editor.tsx
+++ b/apps/web/src/components/project/column-editor.tsx
@@ -9,6 +9,7 @@ import { useDeleteColumn } from "@/hooks/mutations/column/use-delete-column";
import { useReorderColumns } from "@/hooks/mutations/column/use-reorder-columns";
import { useUpdateColumn } from "@/hooks/mutations/column/use-update-column";
import { useGetColumns } from "@/hooks/queries/column/use-get-columns";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { toast } from "@/lib/toast";
type ColumnEditorProps = {
@@ -22,6 +23,8 @@ export default function ColumnEditor({ projectId }: ColumnEditorProps) {
const { mutateAsync: updateColumn } = useUpdateColumn();
const { mutateAsync: deleteColumn } = useDeleteColumn();
const { mutateAsync: reorderColumns } = useReorderColumns();
+ const { canManageProjects } = useWorkspacePermission();
+ const canEdit = canManageProjects();
const [newColumnName, setNewColumnName] = useState("");
const [draggedIndex, setDraggedIndex] = useState<number | null>(null);
@@ -123,7 +126,7 @@ export default function ColumnEditor({ projectId }: ColumnEditorProps) {
<div
key={col.id}
role="listitem"
- draggable
+ draggable={canEdit}
onDragStart={() => handleDragStart(index)}
onDragOver={(e) => handleDragOver(e, index)}
onDragEnd={handleDragEnd}
@@ -133,6 +136,7 @@ export default function ColumnEditor({ projectId }: ColumnEditorProps) {
<Input
defaultValue={col.name}
className="h-8 text-sm flex-1"
+ disabled={!canEdit}
onBlur={(e) => {
if (e.target.value !== col.name) {
handleRename(col.id, e.target.value);
@@ -160,9 +164,12 @@ export default function ColumnEditor({ projectId }: ColumnEditorProps) {
</span>
<Switch
checked={col.isFinal}
- onCheckedChange={(checked) =>
- handleToggleFinal(col.id, checked)
+ onCheckedChange={
+ canEdit
+ ? (checked) => handleToggleFinal(col.id, checked)
+ : undefined
}
+ disabled={!canEdit}
aria-label={t("settings:columnEditor.markDoneAria", {
name: col.name,
})}
@@ -174,40 +181,44 @@ export default function ColumnEditor({ projectId }: ColumnEditorProps) {
: t("settings:columnEditor.off")}
</span>
</div>
- <Button
- variant="ghost"
- size="sm"
- className="h-7 w-7 p-0 text-muted-foreground hover:text-destructive"
- onClick={() => handleDelete(col.id)}
- >
- <Trash2 className="w-3.5 h-3.5" />
- </Button>
+ {canEdit && (
+ <Button
+ variant="ghost"
+ size="sm"
+ className="h-7 w-7 p-0 text-muted-foreground hover:text-destructive"
+ onClick={() => handleDelete(col.id)}
+ >
+ <Trash2 className="w-3.5 h-3.5" />
+ </Button>
+ )}
</div>
</div>
))}
</div>
- <div className="flex items-center gap-2">
- <Input
- placeholder={t("settings:columnEditor.newColumnPlaceholder")}
- value={newColumnName}
- onChange={(e) => setNewColumnName(e.target.value)}
- className="h-8 text-sm flex-1"
- onKeyDown={(e) => {
- if (e.key === "Enter") handleCreate();
- }}
- />
- <Button
- variant="outline"
- size="sm"
- onClick={handleCreate}
- disabled={!newColumnName.trim()}
- className="h-8 gap-1"
- >
- <Plus className="w-3.5 h-3.5" />
- {t("settings:columnEditor.add")}
- </Button>
- </div>
+ {canEdit && (
+ <div className="flex items-center gap-2">
+ <Input
+ placeholder={t("settings:columnEditor.newColumnPlaceholder")}
+ value={newColumnName}
+ onChange={(e) => setNewColumnName(e.target.value)}
+ className="h-8 text-sm flex-1"
+ onKeyDown={(e) => {
+ if (e.key === "Enter") handleCreate();
+ }}
+ />
+ <Button
+ variant="outline"
+ size="sm"
+ onClick={handleCreate}
+ disabled={!newColumnName.trim()}
+ className="h-8 gap-1"
+ >
+ <Plus className="w-3.5 h-3.5" />
+ {t("settings:columnEditor.add")}
+ </Button>
+ </div>
+ )}
</div>
);
}
diff --git a/apps/web/src/components/shared/modals/create-task-modal.tsx b/apps/web/src/components/shared/modals/create-task-modal.tsx
index 7f039c736..1425118be 100644
--- a/apps/web/src/components/shared/modals/create-task-modal.tsx
+++ b/apps/web/src/components/shared/modals/create-task-modal.tsx
@@ -43,6 +43,7 @@ import { useUpdateTask } from "@/hooks/mutations/task/use-update-task";
import useGetLabelsByWorkspace from "@/hooks/queries/label/use-get-labels-by-workspace";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
import { useGetActiveWorkspaceUsers } from "@/hooks/queries/workspace-users/use-get-active-workspace-users";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { cn } from "@/lib/cn";
import { formatDateMedium } from "@/lib/format";
import { getPriorityIcon } from "@/lib/priority";
@@ -174,6 +175,9 @@ function CreateTaskModal({
const { data: workspaceLabels = [] } = useGetLabelsByWorkspace(
workspace?.id || "",
);
+ const { canManageTasks, canManageLabels } = useWorkspacePermission();
+ const canCreateTaskCapability = canManageTasks();
+ const canCreateLabelCapability = canManageLabels();
const [title, setTitle] = useState("");
const [description, setDescription] = useState("");
@@ -576,6 +580,11 @@ function CreateTaskModal({
setLabels(labels.filter((l) => l.name !== labelName));
};
+ // Defense-in-depth: if the user lacks task-create permission, don't render
+ // the modal even if a stale trigger somehow opens it (e.g., keyboard
+ // shortcut after the capability has changed).
+ if (!canCreateTaskCapability) return null;
+
return (
<Dialog open={open} onOpenChange={handleClose}>
<DialogContent
@@ -929,10 +938,12 @@ function CreateTaskModal({
</button>
))}
- {isCreatingNewLabel && filteredLabels.length > 0 && (
- <div className="border-t border-border my-1" />
- )}
- {isCreatingNewLabel && (
+ {canCreateLabelCapability &&
+ isCreatingNewLabel &&
+ filteredLabels.length > 0 && (
+ <div className="border-t border-border my-1" />
+ )}
+ {canCreateLabelCapability && isCreatingNewLabel && (
<button
type="button"
className="w-full flex items-center gap-2 px-2 py-1.5 text-xs hover:bg-accent/50 text-left"
diff --git a/apps/web/src/components/task/subtask-assignee-popover.tsx b/apps/web/src/components/task/subtask-assignee-popover.tsx
index db3182f05..99bfc4b5f 100644
--- a/apps/web/src/components/task/subtask-assignee-popover.tsx
+++ b/apps/web/src/components/task/subtask-assignee-popover.tsx
@@ -12,6 +12,7 @@ import { ShortcutNumber } from "@/components/ui/shortcut-number";
import { useUpdateTaskAssignee } from "@/hooks/mutations/task/use-update-task-assignee";
import { useGetActiveWorkspaceUsers } from "@/hooks/queries/workspace-users/use-get-active-workspace-users";
import { useNumberedShortcuts } from "@/hooks/use-numbered-shortcuts";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { toast } from "@/lib/toast";
import type Task from "@/types/task";
@@ -36,6 +37,8 @@ export default function SubtaskAssigneePopover({
);
const { mutateAsync: updateTaskAssignee } = useUpdateTaskAssignee();
const { data: workspaceUsers } = useGetActiveWorkspaceUsers(workspaceId);
+ const { canAssignTasks } = useWorkspacePermission();
+ const canAssign = canAssignTasks();
const usersOptions = useMemo(() => {
return workspaceUsers?.members?.map((member) => ({
@@ -110,6 +113,8 @@ export default function SubtaskAssigneePopover({
useNumberedShortcuts(open, shortcutOptions);
+ if (!canAssign) return <>{children}</>;
+
return (
<Popover open={open} onOpenChange={handleOpenChange} modal={false}>
<PopoverTrigger asChild>{children}</PopoverTrigger>
diff --git a/apps/web/src/components/task/subtask-status-popover.tsx b/apps/web/src/components/task/subtask-status-popover.tsx
index 10dbc803f..fc5596573 100644
--- a/apps/web/src/components/task/subtask-status-popover.tsx
+++ b/apps/web/src/components/task/subtask-status-popover.tsx
@@ -11,6 +11,7 @@ import { ShortcutNumber } from "@/components/ui/shortcut-number";
import { useUpdateTaskStatus } from "@/hooks/mutations/task/use-update-task-status";
import { useGetColumns } from "@/hooks/queries/column/use-get-columns";
import { useNumberedShortcuts } from "@/hooks/use-numbered-shortcuts";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { getColumnIcon } from "@/lib/column";
import { getStatusDisplayLabel } from "@/lib/i18n/domain";
import { toast } from "@/lib/toast";
@@ -36,6 +37,8 @@ export default function SubtaskStatusPopover({
isFinal: col.isFinal,
}));
const { mutateAsync: updateTaskStatus } = useUpdateTaskStatus();
+ const { canManageTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
const allSameStatus =
tasks.length > 0 && tasks.every((t) => t.status === tasks[0].status);
@@ -74,6 +77,8 @@ export default function SubtaskStatusPopover({
useNumberedShortcuts(open, shortcutOptions);
+ if (!canEdit) return <>{children}</>;
+
return (
<Popover open={open} onOpenChange={setOpen} modal={false}>
<PopoverTrigger asChild>{children}</PopoverTrigger>
diff --git a/apps/web/src/components/task/task-assignee-popover.tsx b/apps/web/src/components/task/task-assignee-popover.tsx
index fb1761d26..24e7468ac 100644
--- a/apps/web/src/components/task/task-assignee-popover.tsx
+++ b/apps/web/src/components/task/task-assignee-popover.tsx
@@ -12,6 +12,7 @@ import { ShortcutNumber } from "@/components/ui/shortcut-number";
import { useUpdateTaskAssignee } from "@/hooks/mutations/task/use-update-task-assignee";
import { useGetActiveWorkspaceUsers } from "@/hooks/queries/workspace-users/use-get-active-workspace-users";
import { useNumberedShortcuts } from "@/hooks/use-numbered-shortcuts";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { toast } from "@/lib/toast";
import type Task from "@/types/task";
@@ -36,6 +37,8 @@ export default function TaskAssigneePopover({
);
const { mutateAsync: updateTaskAssignee } = useUpdateTaskAssignee();
const { data: workspaceUsers } = useGetActiveWorkspaceUsers(workspaceId);
+ const { canAssignTasks } = useWorkspacePermission();
+ const canAssign = canAssignTasks();
const usersOptions = useMemo(() => {
return workspaceUsers?.members?.map((member) => ({
@@ -102,6 +105,8 @@ export default function TaskAssigneePopover({
useNumberedShortcuts(open, shortcutOptions);
+ if (!canAssign) return <>{children}</>;
+
return (
<Popover open={open} onOpenChange={handleOpenChange}>
<PopoverTrigger asChild>{children}</PopoverTrigger>
diff --git a/apps/web/src/components/task/task-description.tsx b/apps/web/src/components/task/task-description.tsx
index 94b484c53..9697b0576 100644
--- a/apps/web/src/components/task/task-description.tsx
+++ b/apps/web/src/components/task/task-description.tsx
@@ -49,6 +49,7 @@ import {
} from "@/components/ui/menu";
import { useUpdateTaskDescription } from "@/hooks/mutations/task/use-update-task-description";
import useGetTask from "@/hooks/queries/task/use-get-task";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { cn } from "@/lib/cn";
import debounce from "@/lib/debounce";
import { parseTaskListMarkdownToNodes } from "@/lib/editor-task-list-paste";
@@ -256,6 +257,8 @@ export default function TaskDescription({ taskId }: TaskDescriptionProps) {
const { t } = useTranslation();
const { data: task } = useGetTask(taskId);
const { mutateAsync: updateTaskDescription } = useUpdateTaskDescription();
+ const { canManageTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
const editorShellRef = useRef<HTMLDivElement | null>(null);
const imageInputRef = useRef<HTMLInputElement | null>(null);
@@ -757,6 +760,15 @@ export default function TaskDescription({ taskId }: TaskDescriptionProps) {
);
}, [editor, shikiHighlighter]);
+ // Toggle Tiptap's editable flag based on workspace permission. When the
+ // user can't manage tasks, the description renders as read-only — slash
+ // menus, paste handlers, and toolbar buttons all become no-ops because
+ // the editor refuses content mutations.
+ useEffect(() => {
+ if (!editor) return;
+ editor.setEditable(canEdit);
+ }, [editor, canEdit]);
+
useEffect(() => {
if (!editor || typeof document === "undefined") return;
@@ -1755,17 +1767,19 @@ export default function TaskDescription({ taskId }: TaskDescriptionProps) {
onMouseMove={handleEditorMouseMove}
onMouseLeave={handleEditorMouseLeave}
/>
- <button
- type="button"
- className="kaneo-editor-quick-attach"
- onMouseDown={(event) => {
- event.preventDefault();
- }}
- onClick={() => openImagePicker(editor)}
- aria-label={t("tasks:detail.editor.attachFile")}
- >
- <Paperclip className="size-3.5" />
- </button>
+ {canEdit && (
+ <button
+ type="button"
+ className="kaneo-editor-quick-attach"
+ onMouseDown={(event) => {
+ event.preventDefault();
+ }}
+ onClick={() => openImagePicker(editor)}
+ aria-label={t("tasks:detail.editor.attachFile")}
+ >
+ <Paperclip className="size-3.5" />
+ </button>
+ )}
{isDragActive && (
<div className="kaneo-editor-drop-indicator">
<span>{t("tasks:detail.editor.dropToUpload")}</span>
diff --git a/apps/web/src/components/task/task-due-date-popover.tsx b/apps/web/src/components/task/task-due-date-popover.tsx
index fded763dd..7b222b2bf 100644
--- a/apps/web/src/components/task/task-due-date-popover.tsx
+++ b/apps/web/src/components/task/task-due-date-popover.tsx
@@ -9,6 +9,7 @@ import {
PopoverTrigger,
} from "@/components/ui/popover";
import { useUpdateTaskDueDate } from "@/hooks/mutations/task/use-update-task-due-date";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { toast } from "@/lib/toast";
import type Task from "@/types/task";
@@ -24,6 +25,8 @@ export default function TaskDueDatePopover({
const { t } = useTranslation();
const [open, setOpen] = useState(false);
const { mutateAsync: updateTaskDueDate } = useUpdateTaskDueDate();
+ const { canManageTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
const handleDateChange = async (date: Date | undefined) => {
try {
@@ -42,6 +45,8 @@ export default function TaskDueDatePopover({
}
};
+ if (!canEdit) return <>{children}</>;
+
return (
<Popover open={open} onOpenChange={setOpen}>
<PopoverTrigger asChild>{children}</PopoverTrigger>
diff --git a/apps/web/src/components/task/task-labels-popover.tsx b/apps/web/src/components/task/task-labels-popover.tsx
index c78b1864c..2e07c89e6 100644
--- a/apps/web/src/components/task/task-labels-popover.tsx
+++ b/apps/web/src/components/task/task-labels-popover.tsx
@@ -12,6 +12,7 @@ import useCreateLabel from "@/hooks/mutations/label/use-create-label";
import useDeleteLabel from "@/hooks/mutations/label/use-delete-label";
import useGetLabelsByTask from "@/hooks/queries/label/use-get-labels-by-task";
import useGetLabelsByWorkspace from "@/hooks/queries/label/use-get-labels-by-workspace";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { cn } from "@/lib/cn";
import { toast } from "@/lib/toast";
import type Task from "@/types/task";
@@ -66,6 +67,13 @@ export default function TaskLabelsPopover({
const { mutateAsync: createLabel } = useCreateLabel();
const { mutateAsync: deleteLabel } = useDeleteLabel();
+ // Attaching/removing labels from a task is a task mutation; creating a new
+ // workspace label needs the label capability. We gate the popover trigger
+ // on whichever is required: any flow needs at least task-edit since the
+ // result lives on the task.
+ const { canManageTasks, canManageLabels } = useWorkspacePermission();
+ const canEdit = canManageTasks();
+ const canCreateLabels = canManageLabels();
const { data: taskLabels = [] } = useGetLabelsByTask(task.id);
const { data: workspaceLabels = [] } = useGetLabelsByWorkspace(workspaceId);
@@ -242,10 +250,10 @@ export default function TaskLabelsPopover({
</button>
))}
- {isCreatingNewLabel && filteredLabels.length > 0 && (
+ {canCreateLabels && isCreatingNewLabel && filteredLabels.length > 0 && (
<div className="border-t border-border my-1" />
)}
- {isCreatingNewLabel && (
+ {canCreateLabels && isCreatingNewLabel && (
<button
type="button"
className="w-full flex items-center gap-2 px-2 py-1.5 text-xs hover:bg-accent/50 text-left"
@@ -313,6 +321,10 @@ export default function TaskLabelsPopover({
</div>
);
+ // No task-edit permission → no label changes at all. The trigger renders
+ // as a plain element so users still see the existing labels.
+ if (!canEdit) return <>{children}</>;
+
return (
<Popover open={open} onOpenChange={setOpen}>
<PopoverTrigger asChild nativeButton={triggerNativeButton}>
diff --git a/apps/web/src/components/task/task-priority-popover.tsx b/apps/web/src/components/task/task-priority-popover.tsx
index 481cfc67f..438a7078a 100644
--- a/apps/web/src/components/task/task-priority-popover.tsx
+++ b/apps/web/src/components/task/task-priority-popover.tsx
@@ -10,6 +10,7 @@ import {
import { ShortcutNumber } from "@/components/ui/shortcut-number";
import { useUpdateTaskPriority } from "@/hooks/mutations/task/use-update-task-status-priority";
import { useNumberedShortcuts } from "@/hooks/use-numbered-shortcuts";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { getPriorityLabel } from "@/lib/i18n/domain";
import { getPriorityIcon } from "@/lib/priority";
import { toast } from "@/lib/toast";
@@ -35,6 +36,8 @@ export default function TaskPriorityPopover({
const { t } = useTranslation();
const [open, setOpen] = useState(false);
const { mutateAsync: updateTaskPriority } = useUpdateTaskPriority();
+ const { canManageTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
const handlePriorityChange = useCallback(
async (newPriority: string) => {
@@ -65,6 +68,10 @@ export default function TaskPriorityPopover({
useNumberedShortcuts(open, shortcutOptions);
+ // Read-only role: render the trigger child as a plain element so the user
+ // still sees the current priority but can't open the popover.
+ if (!canEdit) return <>{children}</>;
+
return (
<Popover open={open} onOpenChange={setOpen}>
<PopoverTrigger asChild>{children}</PopoverTrigger>
diff --git a/apps/web/src/components/task/task-relations.tsx b/apps/web/src/components/task/task-relations.tsx
index b9d9aeb74..58b96e6e9 100644
--- a/apps/web/src/components/task/task-relations.tsx
+++ b/apps/web/src/components/task/task-relations.tsx
@@ -45,6 +45,7 @@ import { useGetTasks } from "@/hooks/queries/task/use-get-tasks";
import useGetTaskRelations from "@/hooks/queries/task-relation/use-get-task-relations";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
import { useGetActiveWorkspaceUsers } from "@/hooks/queries/workspace-users/use-get-active-workspace-users";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { getColumnIcon } from "@/lib/column";
import { toast } from "@/lib/toast";
import type Task from "@/types/task";
@@ -93,6 +94,8 @@ export default function TaskRelations({
);
const createRelation = useCreateTaskRelation();
const deleteRelation = useDeleteTaskRelation(taskId);
+ const { canManageTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
useEffect(() => {
if (!commandOpen) {
@@ -260,14 +263,16 @@ export default function TaskRelations({
</span>
)}
</div>
- <Button
- variant="ghost"
- size="xs"
- className="text-muted-foreground"
- onClick={() => setCommandOpen(true)}
- >
- <Plus className="size-3.5" />
- </Button>
+ {canEdit && (
+ <Button
+ variant="ghost"
+ size="xs"
+ className="text-muted-foreground"
+ onClick={() => setCommandOpen(true)}
+ >
+ <Plus className="size-3.5" />
+ </Button>
+ )}
</div>
<CollapsibleContent>
@@ -353,13 +358,17 @@ export default function TaskRelations({
>
<span>{t("tasks:relations.openTask")}</span>
</ContextMenuItem>
- <ContextMenuSeparator />
- <ContextMenuItem
- className="text-destructive"
- onClick={() => handleRemoveRelation(item.id)}
- >
- <span>{t("tasks:relations.removeRelation")}</span>
- </ContextMenuItem>
+ {canEdit && (
+ <>
+ <ContextMenuSeparator />
+ <ContextMenuItem
+ className="text-destructive"
+ onClick={() => handleRemoveRelation(item.id)}
+ >
+ <span>{t("tasks:relations.removeRelation")}</span>
+ </ContextMenuItem>
+ </>
+ )}
</ContextMenuContent>
</ContextMenu>
);
diff --git a/apps/web/src/components/task/task-start-date-popover.tsx b/apps/web/src/components/task/task-start-date-popover.tsx
index a9ba53ae3..1ebbe83ad 100644
--- a/apps/web/src/components/task/task-start-date-popover.tsx
+++ b/apps/web/src/components/task/task-start-date-popover.tsx
@@ -9,6 +9,7 @@ import {
PopoverTrigger,
} from "@/components/ui/popover";
import { useUpdateTask } from "@/hooks/mutations/task/use-update-task";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { toast } from "@/lib/toast";
import type Task from "@/types/task";
@@ -24,6 +25,8 @@ export default function TaskStartDatePopover({
const { t } = useTranslation();
const [open, setOpen] = useState(false);
const { mutateAsync: updateTask } = useUpdateTask();
+ const { canManageTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
const handleDateChange = async (date: Date | undefined) => {
try {
@@ -42,6 +45,8 @@ export default function TaskStartDatePopover({
}
};
+ if (!canEdit) return <>{children}</>;
+
return (
<Popover open={open} onOpenChange={setOpen}>
<PopoverTrigger asChild>{children}</PopoverTrigger>
diff --git a/apps/web/src/components/task/task-status-popover.tsx b/apps/web/src/components/task/task-status-popover.tsx
index 65b220cbc..e37ddcaa9 100644
--- a/apps/web/src/components/task/task-status-popover.tsx
+++ b/apps/web/src/components/task/task-status-popover.tsx
@@ -10,6 +10,7 @@ import {
import { ShortcutNumber } from "@/components/ui/shortcut-number";
import { useUpdateTaskStatus } from "@/hooks/mutations/task/use-update-task-status";
import { useNumberedShortcuts } from "@/hooks/use-numbered-shortcuts";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { getColumnIcon } from "@/lib/column";
import { getStatusDisplayLabel } from "@/lib/i18n/domain";
import { toast } from "@/lib/toast";
@@ -35,6 +36,8 @@ export default function TaskStatusPopover({
isFinal: col.isFinal,
})) ?? [];
const { mutateAsync: updateTaskStatus } = useUpdateTaskStatus();
+ const { canManageTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
const handleStatusChange = useCallback(
async (newStatus: string) => {
@@ -65,6 +68,8 @@ export default function TaskStatusPopover({
useNumberedShortcuts(open, shortcutOptions);
+ if (!canEdit) return <>{children}</>;
+
return (
<Popover open={open} onOpenChange={setOpen}>
<PopoverTrigger asChild>{children}</PopoverTrigger>
diff --git a/apps/web/src/components/task/task-subtasks.tsx b/apps/web/src/components/task/task-subtasks.tsx
index e95a09b5d..47a10a27e 100644
--- a/apps/web/src/components/task/task-subtasks.tsx
+++ b/apps/web/src/components/task/task-subtasks.tsx
@@ -26,6 +26,7 @@ import useCreateTaskRelation from "@/hooks/mutations/task-relation/use-create-ta
import useGetTaskRelations from "@/hooks/queries/task-relation/use-get-task-relations";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
import { useGetActiveWorkspaceUsers } from "@/hooks/queries/workspace-users/use-get-active-workspace-users";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { toast } from "@/lib/toast";
import queryClient from "@/query-client";
import type Task from "@/types/task";
@@ -60,6 +61,8 @@ export default function TaskSubtasks({
const createTask = useCreateTask();
const createRelation = useCreateTaskRelation();
const { mutateAsync: deleteTask } = useDeleteTask();
+ const { canManageTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
const subtasks = relations
.filter(
@@ -298,14 +301,16 @@ export default function TaskSubtasks({
</span>
)}
</div>
- <Button
- variant="ghost"
- size="xs"
- className="text-muted-foreground"
- onClick={() => setIsAdding(true)}
- >
- <Plus className="size-3.5" />
- </Button>
+ {canEdit && (
+ <Button
+ variant="ghost"
+ size="xs"
+ className="text-muted-foreground"
+ onClick={() => setIsAdding(true)}
+ >
+ <Plus className="size-3.5" />
+ </Button>
+ )}
</div>
<CollapsibleContent>
diff --git a/apps/web/src/components/task/task-title.tsx b/apps/web/src/components/task/task-title.tsx
index fefa023e9..310226768 100644
--- a/apps/web/src/components/task/task-title.tsx
+++ b/apps/web/src/components/task/task-title.tsx
@@ -5,6 +5,7 @@ import { useTranslation } from "react-i18next";
import { Form, FormField } from "@/components/ui/form";
import { useUpdateTaskTitle } from "@/hooks/mutations/task/use-update-task-title";
import useGetTask from "@/hooks/queries/task/use-get-task";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import debounce from "@/lib/debounce";
type TaskTitleProps = {
@@ -15,6 +16,8 @@ export default function TaskTitle({ taskId }: TaskTitleProps) {
const { t } = useTranslation();
const { data: task } = useGetTask(taskId);
const { mutateAsync: updateTaskTitle } = useUpdateTaskTitle();
+ const { canManageTasks } = useWorkspacePermission();
+ const canEdit = canManageTasks();
const isInitializedRef = useRef(false);
const taskRef = useRef(task);
const updateTaskRef = useRef(updateTaskTitle);
@@ -81,6 +84,7 @@ export default function TaskTitle({ taskId }: TaskTitleProps) {
{...field}
type="text"
placeholder={t("tasks:detail.titlePlaceholder")}
+ readOnly={!canEdit}
className="block h-auto w-full appearance-none border-0 bg-transparent p-0 font-heading text-[2rem] leading-[1.15] font-semibold tracking-[-0.02em] text-foreground outline-none placeholder:text-foreground/45"
onChange={(e) => {
field.onChange(e);
diff --git a/apps/web/src/components/team/delete-team-member-modal.tsx b/apps/web/src/components/team/delete-team-member-modal.tsx
index 56818fbd5..c30c2e89d 100644
--- a/apps/web/src/components/team/delete-team-member-modal.tsx
+++ b/apps/web/src/components/team/delete-team-member-modal.tsx
@@ -2,6 +2,7 @@ import { useQueryClient } from "@tanstack/react-query";
import { Trash2, X } from "lucide-react";
import useDeleteWorkspaceUser from "@/hooks/mutations/workspace-user/use-delete-workspace-user";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { Button } from "../ui/button";
import { Dialog, DialogClose, DialogPopup, DialogTitle } from "../ui/dialog";
@@ -18,8 +19,11 @@ function DeleteTeamMemberModal({
const workspaceId = workspace?.id ?? "";
const { mutateAsync: deleteWorkspaceUser } = useDeleteWorkspaceUser();
const queryClient = useQueryClient();
+ const { canRemoveMembers } = useWorkspacePermission();
+ const canRemove = canRemoveMembers();
const onRemoveMember = async () => {
+ if (!canRemove) return;
await deleteWorkspaceUser({
workspaceId,
userId,
@@ -66,7 +70,11 @@ function DeleteTeamMemberModal({
>
Cancel
</DialogClose>
- <Button onClick={onRemoveMember} variant="destructive">
+ <Button
+ onClick={onRemoveMember}
+ variant="destructive"
+ disabled={!canRemove}
+ >
<Trash2 className="w-4 h-4 mr-2" />
Remove Member
</Button>
diff --git a/apps/web/src/components/team/invite-team-member-modal.tsx b/apps/web/src/components/team/invite-team-member-modal.tsx
index 201fc89d6..0c6d840da 100644
--- a/apps/web/src/components/team/invite-team-member-modal.tsx
+++ b/apps/web/src/components/team/invite-team-member-modal.tsx
@@ -6,6 +6,7 @@ import { useTranslation } from "react-i18next";
import { z } from "zod/v4";
import useInviteWorkspaceUser from "@/hooks/mutations/workspace-user/use-invite-workspace-user";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { toast } from "@/lib/toast";
import { Button } from "../ui/button";
import { Dialog, DialogClose, DialogPopup, DialogTitle } from "../ui/dialog";
@@ -36,6 +37,8 @@ function InviteTeamMemberModal({ open, onClose }: Props) {
const queryClient = useQueryClient();
const { data: workspace } = useActiveWorkspace();
const workspaceId = workspace?.id;
+ const { canInviteUsers } = useWorkspacePermission();
+ const canInvite = canInviteUsers();
const form = useForm<TeamMemberFormValues>({
resolver: standardSchemaResolver(teamMemberSchema),
@@ -49,6 +52,13 @@ function InviteTeamMemberModal({ open, onClose }: Props) {
toast.error(t("team:inviteModal.error"));
return;
}
+ if (!canInvite) {
+ // Defense-in-depth: parent gates the trigger, but if the modal is
+ // somehow open without permission we refuse rather than firing a
+ // mutation the server will reject.
+ toast.error(t("team:inviteModal.error"));
+ return;
+ }
try {
await mutateAsync({ email, workspaceId, role: "member" }); // TODO: role and email
await queryClient.refetchQueries({
@@ -134,7 +144,7 @@ function InviteTeamMemberModal({ open, onClose }: Props) {
>
{t("common:actions.cancel")}
</DialogClose>
- <Button type="submit" disabled={!workspaceId}>
+ <Button type="submit" disabled={!workspaceId || !canInvite}>
{t("team:inviteModal.sendInvitation")}
</Button>
</div>
diff --git a/apps/web/src/hooks/mutations/workspace-user/use-update-workspace-user-role.ts b/apps/web/src/hooks/mutations/workspace-user/use-update-workspace-user-role.ts
index f2c478ffb..74d4b55a1 100644
--- a/apps/web/src/hooks/mutations/workspace-user/use-update-workspace-user-role.ts
+++ b/apps/web/src/hooks/mutations/workspace-user/use-update-workspace-user-role.ts
@@ -35,6 +35,11 @@ function useUpdateWorkspaceUserRole() {
});
queryClient.invalidateQueries({ queryKey: ["full-workspace"] });
queryClient.invalidateQueries({ queryKey: ["active-workspace-user"] });
+ // The active user's role may have changed; capability cache is keyed
+ // by (workspaceId, role) so we drop the per-workspace cache.
+ queryClient.invalidateQueries({
+ queryKey: ["workspace-capabilities", variables.workspaceId],
+ });
},
});
}
diff --git a/apps/web/src/hooks/mutations/workspace/use-update-workspace-role.ts b/apps/web/src/hooks/mutations/workspace/use-update-workspace-role.ts
index 8b279a859..de1053ce1 100644
--- a/apps/web/src/hooks/mutations/workspace/use-update-workspace-role.ts
+++ b/apps/web/src/hooks/mutations/workspace/use-update-workspace-role.ts
@@ -27,6 +27,11 @@ function useUpdateWorkspaceRole() {
queryClient.invalidateQueries({
queryKey: ["workspace-roles", variables.workspaceId],
});
+ // The role's permission set just changed, so any cached capability
+ // map for members assigned to this role is now stale.
+ queryClient.invalidateQueries({
+ queryKey: ["workspace-capabilities", variables.workspaceId],
+ });
},
});
}
diff --git a/apps/web/src/hooks/use-workspace-permission.ts b/apps/web/src/hooks/use-workspace-permission.ts
index 9492be3c6..3faa29ecc 100644
--- a/apps/web/src/hooks/use-workspace-permission.ts
+++ b/apps/web/src/hooks/use-workspace-permission.ts
@@ -1,3 +1,4 @@
+import { useQuery } from "@tanstack/react-query";
import { useMemo } from "react";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
import { useGetActiveWorkspaceUser } from "@/hooks/queries/workspace-users/use-active-workspace-user";
@@ -5,77 +6,126 @@ import { authClient } from "@/lib/auth-client";
export type PermissionLevel = "owner" | "admin" | "member";
+// Capabilities are named permission bundles checked against the SERVER via
+// better-auth's `/organization/has-permission` endpoint. Going through the
+// server is what makes custom workspace roles work in the UI — the local
+// `checkRolePermission` only knows about the four static roles compiled
+// into the auth client, so it would silently return false for any custom
+// role that grants the permission.
+const CAPABILITIES = {
+ manageProjects: { project: ["create", "update", "delete"] },
+ createProjects: { project: ["create"] },
+ deleteProjects: { project: ["delete"] },
+ manageTasks: { task: ["create", "update", "delete"] },
+ assignTasks: { task: ["assign"] },
+ manageLabels: { label: ["create", "update", "delete"] },
+ manageWorkspace: { workspace: ["update", "manage_settings"] },
+ deleteWorkspace: { workspace: ["delete"] },
+ inviteUsers: { invitation: ["create"] },
+ manageTeam: { member: ["update", "delete"] },
+ removeMembers: { member: ["delete"] },
+} as const satisfies Record<string, Record<string, string[]>>;
+
+type Capability = keyof typeof CAPABILITIES;
+
+type CapabilityMap = Record<Capability, boolean>;
+
+function emptyCapabilityMap(): CapabilityMap {
+ const out = {} as CapabilityMap;
+ for (const key of Object.keys(CAPABILITIES) as Capability[]) {
+ out[key] = false;
+ }
+ return out;
+}
+
export function useWorkspacePermission() {
const { data: activeWorkspace } = useActiveWorkspace();
const { data: activeMember } = useGetActiveWorkspaceUser();
+ const workspaceId = activeWorkspace?.id;
+ const role = activeMember?.role as string | undefined;
- const permissionCheckers = useMemo(() => {
- const role = activeMember?.role as PermissionLevel | undefined;
-
- const hasPermission = async (permissions: Record<string, string[]>) => {
- try {
- const result = await authClient.organization.hasPermission({
- permissions,
- });
- return result.data || false;
- } catch (error) {
- console.error("Permission check failed:", error);
- return false;
+ // One query that fans out to all capability checks in parallel and caches
+ // the resulting map by (workspaceId, role). Refetches when either changes
+ // — e.g., when the admin edits the role's permissions in the Roles UI and
+ // we invalidate this key.
+ const {
+ data: capabilities,
+ isLoading,
+ isFetching,
+ } = useQuery({
+ queryKey: ["workspace-capabilities", workspaceId, role],
+ enabled: Boolean(workspaceId && role),
+ staleTime: 5 * 60 * 1000,
+ queryFn: async (): Promise<CapabilityMap> => {
+ const entries = Object.entries(CAPABILITIES) as Array<
+ [Capability, Record<string, string[]>]
+ >;
+ const results = await Promise.all(
+ entries.map(async ([key, permissions]) => {
+ try {
+ const res = await authClient.organization.hasPermission({
+ organizationId: workspaceId,
+ permissions,
+ });
+ return [key, res.data?.success === true] as const;
+ } catch (error) {
+ console.error(`hasPermission check failed for ${key}:`, error);
+ return [key, false] as const;
+ }
+ }),
+ );
+ const map = emptyCapabilityMap();
+ for (const [key, value] of results) {
+ map[key] = value;
}
- };
+ return map;
+ },
+ });
- const checkRolePermission = (permissions: Record<string, string[]>) => {
- if (!role) return false;
- try {
- return authClient.organization.checkRolePermission({
- permissions,
- role,
- });
- } catch (error) {
- console.error("Role permission check failed:", error);
- return false;
- }
- };
-
- const checkPermission = (
- requiredRole: PermissionLevel = "member",
- ): boolean => {
- if (!activeWorkspace || !activeMember) return false;
- const userRole = activeMember.role as string | undefined;
- if (!userRole) return false;
- if (requiredRole === "owner") return userRole === "owner";
- if (requiredRole === "admin")
- return ["owner", "admin"].includes(userRole);
- // Baseline membership: any non-empty role (built-in or custom) counts.
- return true;
- };
+ const can: CapabilityMap = capabilities ?? emptyCapabilityMap();
+ const helpers = useMemo(() => {
return {
- hasPermission,
- checkRolePermission,
- canManageProjects: () =>
- checkRolePermission({ project: ["create", "update", "delete"] }),
- canCreateProjects: () => checkRolePermission({ project: ["create"] }),
- canManageTasks: () =>
- checkRolePermission({ task: ["create", "update", "delete"] }),
- canAssignTasks: () => checkRolePermission({ task: ["assign"] }),
- canManageWorkspace: () =>
- checkRolePermission({ workspace: ["update", "manage_settings"] }),
- canDeleteWorkspace: () => checkRolePermission({ workspace: ["delete"] }),
- canInviteUsers: () => checkRolePermission({ team: ["invite"] }),
- canManageTeam: () =>
- checkRolePermission({ team: ["remove", "manage_roles"] }),
- canRemoveMembers: () => checkRolePermission({ team: ["remove"] }),
- checkPermission,
- isOwner: role === "owner",
- isAdmin: ["owner", "admin"].includes(role || ""),
- role,
+ canManageProjects: () => can.manageProjects,
+ canCreateProjects: () => can.createProjects,
+ canDeleteProjects: () => can.deleteProjects,
+ canManageTasks: () => can.manageTasks,
+ canAssignTasks: () => can.assignTasks,
+ canManageLabels: () => can.manageLabels,
+ canManageWorkspace: () => can.manageWorkspace,
+ canDeleteWorkspace: () => can.deleteWorkspace,
+ canInviteUsers: () => can.inviteUsers,
+ canManageTeam: () => can.manageTeam,
+ canRemoveMembers: () => can.removeMembers,
+ // Escape hatch for ad-hoc permission checks (uncached). Prefer adding
+ // a capability above.
+ hasPermission: async (permissions: Record<string, string[]>) => {
+ try {
+ const res = await authClient.organization.hasPermission({
+ organizationId: workspaceId,
+ permissions,
+ });
+ return res.data?.success === true;
+ } catch (error) {
+ console.error("hasPermission check failed:", error);
+ return false;
+ }
+ },
};
- }, [activeMember, activeWorkspace]);
+ }, [can, workspaceId]);
return {
- ...permissionCheckers,
+ ...helpers,
workspace: activeWorkspace,
member: activeMember,
+ role,
+ isOwner: role === "owner",
+ isAdmin: role === "owner" || role === "admin",
+ // True while the first capability fetch is in flight. Useful for hiding
+ // action UI during the initial render instead of flashing it on then
+ // off when the server check resolves.
+ isCheckingPermissions:
+ Boolean(workspaceId && role) && (isLoading || !capabilities),
+ isRefetchingPermissions: isFetching,
};
}
diff --git a/apps/web/src/routes/_layout/_authenticated/dashboard/settings/projects/$projectId/general.tsx b/apps/web/src/routes/_layout/_authenticated/dashboard/settings/projects/$projectId/general.tsx
index 091eb129b..3887cb406 100644
--- a/apps/web/src/routes/_layout/_authenticated/dashboard/settings/projects/$projectId/general.tsx
+++ b/apps/web/src/routes/_layout/_authenticated/dashboard/settings/projects/$projectId/general.tsx
@@ -41,6 +41,7 @@ import useDeleteProject from "@/hooks/mutations/project/use-delete-project";
import useUpdateProject from "@/hooks/mutations/project/use-update-project";
import { useGetTasks } from "@/hooks/queries/task/use-get-tasks";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { cn } from "@/lib/cn";
import { toast } from "@/lib/toast";
import useProjectStore from "@/store/project.ts";
@@ -123,6 +124,9 @@ function RouteComponent() {
const { mutateAsync: updateProject } = useUpdateProject();
const { mutateAsync: deleteProject, isPending: isDeleting } =
useDeleteProject();
+ const { canManageProjects, canDeleteProjects } = useWorkspacePermission();
+ const canEdit = canManageProjects();
+ const canDelete = canDeleteProjects();
const projectForm = useForm<ProjectFormValues>({
resolver: standardSchemaResolver(projectSchema),
@@ -257,6 +261,7 @@ function RouteComponent() {
}, [projectForm, saveProject]);
useEffect(() => {
+ if (!canEdit) return;
// Do not gate on formState.isDirty here: after setValue (e.g. icon pick), the
// watch callback can run before RHF updates isDirty, so the debounced save never runs.
const subscription = projectForm.watch(() => {
@@ -264,7 +269,7 @@ function RouteComponent() {
});
return () => subscription.unsubscribe();
- }, [projectForm, debouncedSave]);
+ }, [projectForm, debouncedSave, canEdit]);
useEffect(() => {
return () => {
@@ -364,6 +369,7 @@ function RouteComponent() {
size="sm"
className="h-8 w-auto justify-start gap-2 font-normal"
title={t("settings:projectGeneral.pickIconTitle")}
+ disabled={!canEdit}
>
{(() => {
const selectedKey =
@@ -455,6 +461,7 @@ function RouteComponent() {
placeholder={t(
"settings:projectGeneral.projectNamePlaceholder",
)}
+ disabled={!canEdit}
{...field}
/>
</FormControl>
@@ -488,6 +495,7 @@ function RouteComponent() {
placeholder={t(
"settings:projectGeneral.keyPlaceholder",
)}
+ disabled={!canEdit}
{...field}
/>
</FormControl>
@@ -519,6 +527,7 @@ function RouteComponent() {
placeholder={t(
"settings:projectGeneral.descriptionPlaceholder",
)}
+ disabled={!canEdit}
{...field}
/>
</FormControl>
@@ -544,39 +553,41 @@ function RouteComponent() {
</div>
</div>
- <div className="space-y-6">
- <div className="space-y-1">
- <h2 className="text-md font-medium">
- {t("settings:projectGeneral.dangerZone")}
- </h2>
- <p className="text-xs text-muted-foreground">
- {t("settings:projectGeneral.dangerZoneSubtitle")}
- </p>
- </div>
+ {canDelete && (
+ <div className="space-y-6">
+ <div className="space-y-1">
+ <h2 className="text-md font-medium">
+ {t("settings:projectGeneral.dangerZone")}
+ </h2>
+ <p className="text-xs text-muted-foreground">
+ {t("settings:projectGeneral.dangerZoneSubtitle")}
+ </p>
+ </div>
- <div className="space-y-4 border border-border rounded-md p-4 bg-sidebar">
- <div className="flex items-center justify-between">
- <div className="space-y-0.5">
- <p className="text-sm font-medium">
+ <div className="space-y-4 border border-border rounded-md p-4 bg-sidebar">
+ <div className="flex items-center justify-between">
+ <div className="space-y-0.5">
+ <p className="text-sm font-medium">
+ {t("settings:projectGeneral.deleteProject")}
+ </p>
+ <p className="text-xs text-muted-foreground">
+ {t("settings:projectGeneral.deleteProjectDescription")}
+ </p>
+ </div>
+ <Button
+ variant="ghost"
+ size="sm"
+ className="text-destructive hover:text-destructive transition-colors"
+ type="button"
+ onClick={() => setIsDeleteModalOpen(true)}
+ disabled={!project}
+ >
{t("settings:projectGeneral.deleteProject")}
- </p>
- <p className="text-xs text-muted-foreground">
- {t("settings:projectGeneral.deleteProjectDescription")}
- </p>
+ </Button>
</div>
- <Button
- variant="ghost"
- size="sm"
- className="text-destructive hover:text-destructive transition-colors"
- type="button"
- onClick={() => setIsDeleteModalOpen(true)}
- disabled={!project}
- >
- {t("settings:projectGeneral.deleteProject")}
- </Button>
</div>
</div>
- </div>
+ )}
<AlertDialog
open={isDeleteModalOpen}
diff --git a/apps/web/src/routes/_layout/_authenticated/dashboard/settings/projects/$projectId/visibility.tsx b/apps/web/src/routes/_layout/_authenticated/dashboard/settings/projects/$projectId/visibility.tsx
index 488887d5e..deaca6172 100644
--- a/apps/web/src/routes/_layout/_authenticated/dashboard/settings/projects/$projectId/visibility.tsx
+++ b/apps/web/src/routes/_layout/_authenticated/dashboard/settings/projects/$projectId/visibility.tsx
@@ -1,6 +1,6 @@
import { useQueryClient } from "@tanstack/react-query";
import { createFileRoute, useParams } from "@tanstack/react-router";
-import { useCallback, useRef } from "react";
+import { useCallback, useEffect, useRef, useState } from "react";
import { useTranslation } from "react-i18next";
import PageTitle from "@/components/page-title";
import { Button } from "@/components/ui/button";
@@ -11,6 +11,7 @@ import { Switch } from "@/components/ui/switch";
import useUpdateProject from "@/hooks/mutations/project/use-update-project";
import useGetProject from "@/hooks/queries/project/use-get-project";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { toast } from "@/lib/toast";
export const Route = createFileRoute(
@@ -30,7 +31,21 @@ function RouteComponent() {
const queryClient = useQueryClient();
const { mutateAsync: updateProject } = useUpdateProject();
+ const { hasPermission } = useWorkspacePermission();
const savingRef = useRef(false);
+ // `project:share` isn't in CAPABILITIES (only admin/owner/custom roles
+ // with it can flip visibility), so use the generic server check. Result
+ // isn't cached, but visibility is a rarely-toggled setting page.
+ const [canShare, setCanShare] = useState(false);
+ useEffect(() => {
+ let cancelled = false;
+ void hasPermission({ project: ["share"] }).then((ok) => {
+ if (!cancelled) setCanShare(ok);
+ });
+ return () => {
+ cancelled = true;
+ };
+ }, [hasPermission]);
const handleToggle = useCallback(async () => {
if (!project) return;
@@ -105,7 +120,8 @@ function RouteComponent() {
</div>
<Switch
checked={!!project?.isPublic}
- onCheckedChange={handleToggle}
+ onCheckedChange={canShare ? handleToggle : undefined}
+ disabled={!canShare}
/>
</div>
diff --git a/apps/web/src/routes/_layout/_authenticated/dashboard/settings/workspace/general.tsx b/apps/web/src/routes/_layout/_authenticated/dashboard/settings/workspace/general.tsx
index 7f4a8ed30..387185305 100644
--- a/apps/web/src/routes/_layout/_authenticated/dashboard/settings/workspace/general.tsx
+++ b/apps/web/src/routes/_layout/_authenticated/dashboard/settings/workspace/general.tsx
@@ -29,6 +29,7 @@ import { Separator } from "@/components/ui/separator";
import useDeleteWorkspace from "@/hooks/mutations/workspace/use-delete-workspace";
import useUpdateWorkspace from "@/hooks/mutations/workspace/use-update-workspace";
import useActiveWorkspace from "@/hooks/queries/workspace/use-active-workspace";
+import { useWorkspacePermission } from "@/hooks/use-workspace-permission";
import { toast } from "@/lib/toast";
export const Route = createFileRoute(
@@ -105,6 +106,9 @@ function RouteComponent() {
const { mutateAsync: updateWorkspace } = useUpdateWorkspace();
const { mutateAsync: deleteWorkspace, isPending: isDeleting } =
useDeleteWorkspace();
+ const { canManageWorkspace, canDeleteWorkspace } = useWorkspacePermission();
+ const canEdit = canManageWorkspace();
+ const canDelete = canDeleteWorkspace();
const workspaceDescription = getWorkspaceDescription(workspace);
const workspaceForm = useForm<WorkspaceFormValues>({
@@ -232,6 +236,7 @@ function RouteComponent() {
);
useEffect(() => {
+ if (!canEdit) return;
const subscription = workspaceForm.watch(() => {
if (workspaceForm.formState.isDirty && workspaceForm.formState.isValid) {
debouncedSave(workspaceForm.getValues());
@@ -239,7 +244,7 @@ function RouteComponent() {
});
return () => subscription.unsubscribe();
- }, [workspaceForm, debouncedSave]);
+ }, [workspaceForm, debouncedSave, canEdit]);
useEffect(() => {
return () => {
@@ -295,6 +300,7 @@ function RouteComponent() {
placeholder={t(
"settings:workspaceGeneral.namePlaceholder",
)}
+ disabled={!canEdit}
{...field}
/>
</FormControl>
@@ -326,6 +332,7 @@ function RouteComponent() {
placeholder={t(
"settings:workspaceGeneral.descriptionPlaceholder",
)}
+ disabled={!canEdit}
{...field}
/>
</FormControl>
@@ -339,38 +346,40 @@ function RouteComponent() {
</div>
</div>
- <div className="space-y-6">
- <div className="space-y-1">
- <h2 className="text-md font-medium">
- {t("settings:workspaceGeneral.dangerZone")}
- </h2>
- <p className="text-xs text-muted-foreground">
- {t("settings:workspaceGeneral.dangerZoneSubtitle")}
- </p>
- </div>
+ {canDelete && (
+ <div className="space-y-6">
+ <div className="space-y-1">
+ <h2 className="text-md font-medium">
+ {t("settings:workspaceGeneral.dangerZone")}
+ </h2>
+ <p className="text-xs text-muted-foreground">
+ {t("settings:workspaceGeneral.dangerZoneSubtitle")}
+ </p>
+ </div>
- <div className="space-y-4 border border-border rounded-md p-4 bg-sidebar">
- <div className="flex items-center justify-between">
- <div className="space-y-0.5">
- <p className="text-sm font-medium">
+ <div className="space-y-4 border border-border rounded-md p-4 bg-sidebar">
+ <div className="flex items-center justify-between">
+ <div className="space-y-0.5">
+ <p className="text-sm font-medium">
+ {t("settings:workspaceGeneral.deleteWorkspace")}
+ </p>
+ <p className="text-xs text-muted-foreground">
+ {t("settings:workspaceGeneral.deleteWorkspaceDescription")}
+ </p>
+ </div>
+ <Button
+ variant="ghost"
+ size="sm"
+ className="text-destructive hover:text-destructive transition-colors"
+ type="button"
+ onClick={() => setIsDeleteModalOpen(true)}
+ >
{t("settings:workspaceGeneral.deleteWorkspace")}
- </p>
- <p className="text-xs text-muted-foreground">
- {t("settings:workspaceGeneral.deleteWorkspaceDescription")}
- </p>
+ </Button>
</div>
- <Button
- variant="ghost"
- size="sm"
- className="text-destructive hover:text-destructive transition-colors"
- type="button"
- onClick={() => setIsDeleteModalOpen(true)}
- >
- {t("settings:workspaceGeneral.deleteWorkspace")}
- </Button>
</div>
</div>
- </div>
+ )}
<AlertDialog
open={isDeleteModalOpen}
diff --git a/apps/web/src/routes/_layout/_authenticated/dashboard/settings/workspace/roles.tsx b/apps/web/src/routes/_layout/_authenticated/dashboard/settings/workspace/roles.tsx
index 350e3a004..a8b35dc27 100644
--- a/apps/web/src/routes/_layout/_authenticated/dashboard/settings/workspace/roles.tsx
+++ b/apps/web/src/routes/_layout/_authenticated/dashboard/settings/workspace/roles.tsx
@@ -1,12 +1,6 @@
-import {
- admin as adminRole,
- member as memberRole,
- owner as ownerRole,
- statement,
- viewer as viewerRole,
-} from "@kaneo/permissions";
+import { DEFAULT_ROLE_NAMES, statement } from "@kaneo/permissions";
import { createFileRoute } from "@tanstack/react-router";
-import { Lock, Plus, Shield, Trash2, X } from "lucide-react";
+import { Plus, Shield, Trash2, X } from "lucide-react";
import { useMemo, useState } from "react";
import PageTitle from "@/components/page-title";
import {
@@ -55,11 +49,15 @@ export const Route = createFileRoute(
// (organization/member/team/invitation). Derive the list from the shared
// `@kaneo/permissions` statement so adding a new resource there picks it
// up here automatically.
+// "ac" is better-auth's meta-resource for managing roles themselves; we don't
+// surface it. Organization/member/team/invitation are likewise managed by the
+// org plugin, not by our workspace permissions UI.
const BUILT_IN_RESOURCES = new Set([
"organization",
"member",
"team",
"invitation",
+ "ac",
]);
const CUSTOM_RESOURCES = (Object.keys(statement) as string[]).filter(
(key) => !BUILT_IN_RESOURCES.has(key),
@@ -158,53 +156,24 @@ const PERMISSION_LABELS: Record<
},
};
-function permissionsForResources(
- statements: Record<string, readonly string[]>,
-): Record<string, string[]> {
- const result: Record<string, string[]> = {};
- for (const resource of CUSTOM_RESOURCES) {
- const granted = statements[resource];
- if (granted && granted.length > 0) {
- result[resource] = [...granted];
- }
- }
- return result;
-}
+// Default roles are seeded per workspace by the API (see
+// `seedDefaultWorkspaceRoles` and the afterCreateOrganization hook). They show
+// up in `customRoles` like any other dynamic role but get a "Default" badge,
+// can't be deleted, and reserve their names against new custom roles. Owner
+// stays a static role on the auth side and is hidden from this UI, but its
+// name is still reserved here.
+const DEFAULT_ROLE_NAME_SET = new Set<string>(DEFAULT_ROLE_NAMES);
+const RESERVED_ROLE_NAMES = [...DEFAULT_ROLE_NAMES, "owner"];
-const BUILT_IN_ROLES: Array<{
- name: string;
- description: string;
- permissions: Record<string, string[]>;
-}> = [
- {
- name: "viewer",
- description: "Read-only access to projects, tasks, and workspace.",
- permissions: permissionsForResources(
- viewerRole.statements as Record<string, readonly string[]>,
- ),
- },
- {
- name: "member",
- description: "Can create and update projects and tasks.",
- permissions: permissionsForResources(
- memberRole.statements as Record<string, readonly string[]>,
- ),
- },
- {
- name: "admin",
- description: "Full project and task management plus workspace settings.",
- permissions: permissionsForResources(
- adminRole.statements as Record<string, readonly string[]>,
- ),
- },
- {
- name: "owner",
- description: "Full access including workspace deletion.",
- permissions: permissionsForResources(
- ownerRole.statements as Record<string, readonly string[]>,
- ),
- },
-];
+const DEFAULT_ROLE_DESCRIPTIONS: Record<string, string> = {
+ viewer: "Read-only access to projects, tasks, and workspace.",
+ member: "Can create and update projects and tasks.",
+ admin: "Full project and task management plus workspace settings.",
+};
+
+function isDefaultRole(name: string) {
+ return DEFAULT_ROLE_NAME_SET.has(name);
+}
function permissionsEqual(
a: Record<string, string[]>,
@@ -242,6 +211,23 @@ function RouteComponent() {
const [roleToDelete, setRoleToDelete] = useState<WorkspaceRole | null>(null);
const [openCustom, setOpenCustom] = useState<string[]>([]);
+ // Defaults (viewer/member/admin) first so they anchor the list, then
+ // user-created roles in their natural order.
+ const sortedRoles = useMemo(() => {
+ const defaults: WorkspaceRole[] = [];
+ const custom: WorkspaceRole[] = [];
+ for (const role of customRoles) {
+ if (isDefaultRole(role.role)) defaults.push(role);
+ else custom.push(role);
+ }
+ defaults.sort(
+ (a, b) =>
+ DEFAULT_ROLE_NAMES.indexOf(a.role as never) -
+ DEFAULT_ROLE_NAMES.indexOf(b.role as never),
+ );
+ return [...defaults, ...custom];
+ }, [customRoles]);
+
if (!isAdmin) {
return (
<>
@@ -270,50 +256,13 @@ function RouteComponent() {
</p>
</div>
- <div className="space-y-6">
- <div className="space-y-1">
- <h2 className="text-md font-medium">Built-in roles</h2>
- <p className="text-xs text-muted-foreground">
- Default roles available in every workspace. Click to inspect the
- permissions they grant.
- </p>
- </div>
- <div className="border border-border rounded-md bg-sidebar">
- <Accordion>
- {BUILT_IN_ROLES.map((role) => (
- <AccordionItem
- key={role.name}
- value={role.name}
- className="border-b border-border last:border-b-0"
- >
- <AccordionTrigger className="px-4">
- <div className="flex items-center gap-3 min-w-0">
- <Lock className="w-3.5 h-3.5 text-muted-foreground shrink-0" />
- <div className="min-w-0">
- <p className="text-sm font-medium capitalize">
- {role.name}
- </p>
- <p className="text-xs font-normal text-muted-foreground truncate">
- {role.description}
- </p>
- </div>
- </div>
- </AccordionTrigger>
- <AccordionPanel className="px-0 pt-0 pb-0">
- <PermissionList permissions={role.permissions} readOnly />
- </AccordionPanel>
- </AccordionItem>
- ))}
- </Accordion>
- </div>
- </div>
-
<div className="space-y-6">
<div className="flex items-start justify-between gap-4">
<div className="space-y-1">
- <h2 className="text-md font-medium">Custom roles</h2>
+ <h2 className="text-md font-medium">Workspace roles</h2>
<p className="text-xs text-muted-foreground">
- Roles you've defined for this workspace.
+ Edit the default roles or add a tailored one. Members keep their
+ assigned role name across edits.
</p>
</div>
<Button
@@ -340,17 +289,18 @@ function RouteComponent() {
<p className="text-xs text-destructive px-4 py-6">
{customRolesErrorValue instanceof Error
? customRolesErrorValue.message
- : "Failed to load custom roles."}
+ : "Failed to load roles."}
</p>
- ) : customRoles.length === 0 && !draftActive ? (
+ ) : sortedRoles.length === 0 && !draftActive ? (
<Empty>
<EmptyHeader>
<EmptyMedia variant="icon">
<Shield />
</EmptyMedia>
- <EmptyTitle>No custom roles yet</EmptyTitle>
+ <EmptyTitle>No roles yet</EmptyTitle>
<EmptyDescription>
- Create one to grant a tailored permission set.
+ Default roles will appear here once they're seeded for this
+ workspace.
</EmptyDescription>
</EmptyHeader>
</Empty>
@@ -377,7 +327,7 @@ function RouteComponent() {
<DraftEditor
workspaceId={workspaceId}
existingNames={[
- ...BUILT_IN_ROLES.map((r) => r.name),
+ ...RESERVED_ROLE_NAMES,
...customRoles.map((r) => r.role),
]}
onCreated={(roleName) => {
@@ -397,35 +347,56 @@ function RouteComponent() {
</AccordionPanel>
</AccordionItem>
)}
- {customRoles.map((role) => (
- <AccordionItem
- key={role.id}
- value={role.role}
- className="border-b border-border last:border-b-0"
- >
- <AccordionTrigger className="px-4">
- <div className="flex items-center justify-between gap-4 flex-1 min-w-0">
- <div className="flex items-center gap-3 min-w-0">
- <Shield className="w-3.5 h-3.5 text-muted-foreground shrink-0" />
- <p className="text-sm font-medium capitalize truncate">
- {role.role}
+ {sortedRoles.map((role) => {
+ const isDefault = isDefaultRole(role.role);
+ const description = isDefault
+ ? DEFAULT_ROLE_DESCRIPTIONS[role.role]
+ : undefined;
+ return (
+ <AccordionItem
+ key={role.id}
+ value={role.role}
+ className="border-b border-border last:border-b-0"
+ >
+ <AccordionTrigger className="px-4">
+ <div className="flex items-center justify-between gap-4 flex-1 min-w-0">
+ <div className="flex items-center gap-3 min-w-0">
+ <Shield className="w-3.5 h-3.5 text-muted-foreground shrink-0" />
+ <div className="min-w-0">
+ <div className="flex items-center gap-2">
+ <p className="text-sm font-medium capitalize truncate">
+ {role.role}
+ </p>
+ {isDefault && (
+ <span className="text-[10px] uppercase tracking-wide font-medium px-1.5 py-0.5 rounded bg-muted text-muted-foreground">
+ Default
+ </span>
+ )}
+ </div>
+ {description && (
+ <p className="text-xs font-normal text-muted-foreground truncate">
+ {description}
+ </p>
+ )}
+ </div>
+ </div>
+ <p className="text-xs font-normal text-muted-foreground shrink-0">
+ {permissionCount(role.permission)} permissions
</p>
</div>
- <p className="text-xs font-normal text-muted-foreground shrink-0">
- {permissionCount(role.permission)} permissions
- </p>
- </div>
- </AccordionTrigger>
- <AccordionPanel className="px-0 pt-0 pb-0">
- <CustomRoleEditor
- key={role.id}
- workspaceId={workspaceId}
- role={role}
- onDelete={() => setRoleToDelete(role)}
- />
- </AccordionPanel>
- </AccordionItem>
- ))}
+ </AccordionTrigger>
+ <AccordionPanel className="px-0 pt-0 pb-0">
+ <CustomRoleEditor
+ key={role.id}
+ workspaceId={workspaceId}
+ role={role}
+ isDefault={isDefault}
+ onDelete={() => setRoleToDelete(role)}
+ />
+ </AccordionPanel>
+ </AccordionItem>
+ );
+ })}
</Accordion>
)}
</div>
@@ -606,14 +577,16 @@ function DraftEditor({
/>
</div>
</div>
- <PermissionList
- permissions={{}}
- selected={permissions}
- onToggle={togglePermission}
- disabled={isPending}
- />
+ <div className="max-h-[60vh] overflow-y-auto">
+ <PermissionList
+ permissions={{}}
+ selected={permissions}
+ onToggle={togglePermission}
+ disabled={isPending}
+ />
+ </div>
<Separator />
- <div className="flex justify-end gap-2 px-4 py-3">
+ <div className="flex justify-end gap-2 px-4 py-3 bg-sidebar">
<Button
variant="ghost"
size="sm"
@@ -634,10 +607,12 @@ function DraftEditor({
function CustomRoleEditor({
workspaceId,
role,
+ isDefault,
onDelete,
}: {
workspaceId: string;
role: WorkspaceRole;
+ isDefault?: boolean;
onDelete: () => void;
}) {
const [permissions, setPermissions] = useState<Record<string, Set<string>>>(
@@ -691,26 +666,39 @@ function CustomRoleEditor({
}
};
+ // AccordionPanel sets `overflow-hidden`, which kills `position: sticky`
+ // relative to the page. Instead, we cap the permission list height and
+ // give it its own scroll, so the action bar below stays anchored at the
+ // bottom of the accordion content while the user scrolls through
+ // permissions.
return (
<div>
- <PermissionList
- permissions={role.permission}
- selected={permissions}
- onToggle={togglePermission}
- disabled={isPending}
- />
- <Separator />
- <div className="flex items-center justify-between gap-2 px-4 py-3">
- <Button
- variant="ghost"
- size="sm"
- onClick={onDelete}
- className="text-destructive hover:text-destructive"
+ <div className="max-h-[60vh] overflow-y-auto">
+ <PermissionList
+ permissions={role.permission}
+ selected={permissions}
+ onToggle={togglePermission}
disabled={isPending}
- >
- <Trash2 className="w-4 h-4" />
- Delete role
- </Button>
+ />
+ </div>
+ <Separator />
+ <div className="flex items-center justify-between gap-2 px-4 py-3 bg-sidebar">
+ {isDefault ? (
+ <span className="text-xs text-muted-foreground">
+ Default role — name is reserved and the row can't be deleted.
+ </span>
+ ) : (
+ <Button
+ variant="ghost"
+ size="sm"
+ onClick={onDelete}
+ className="text-destructive hover:text-destructive"
+ disabled={isPending}
+ >
+ <Trash2 className="w-4 h-4" />
+ Delete role
+ </Button>
+ )}
<div className="flex items-center gap-3">
<p className="text-xs text-muted-foreground">
{dirty ? "You have unsaved changes" : "All changes saved"}
diff --git a/apps/web/src/routes/_layout/_authenticated/dashboard/workspace/$workspaceId/index.tsx b/apps/web/src/routes/_layout/_authenticated/dashboard/workspace/$workspaceId/index.tsx
index 78c602555..135d22f8d 100644
--- a/apps/web/src/routes/_layout/_authenticated/dashboard/workspace/$workspaceId/index.tsx
+++ b/apps/web/src/routes/_layout/_authenticated/dashboard/workspace/$workspaceId/index.tsx
@@ -160,7 +160,9 @@ function RouteComponent() {
</EmptyMedia>
<EmptyTitle>{t("workspace:projects.emptyTitle")}</EmptyTitle>
<EmptyDescription>
- {t("workspace:projects.emptyDescription")}
+ {canCreate
+ ? t("workspace:projects.emptyDescription")
+ : t("workspace:projects.emptyDescriptionReadOnly")}
</EmptyDescription>
</EmptyHeader>
<EmptyContent>
@@ -188,15 +190,17 @@ function RouteComponent() {
<WorkspaceLayout
title={t("workspace:projects.pageTitle")}
headerActions={
- <Button
- variant="outline"
- size="xs"
- onClick={handleCreateProject}
- className="gap-1"
- >
- <Plus className="w-3 h-3" />
- {t("workspace:projects.createProject")}
- </Button>
+ canCreate ? (
+ <Button
+ variant="outline"
+ size="xs"
+ onClick={handleCreateProject}
+ className="gap-1"
+ >
+ <Plus className="w-3 h-3" />
+ {t("workspace:projects.createProject")}
+ </Button>
+ ) : null
}
>
<Table>
diff --git a/i18n/en-US.json b/i18n/en-US.json
index fff735204..128558e44 100644
--- a/i18n/en-US.json
+++ b/i18n/en-US.json
@@ -1681,6 +1681,7 @@
"status": "Status",
"emptyTitle": "No projects yet",
"emptyDescription": "Get started by creating your first project.",
+ "emptyDescriptionReadOnly": "There are no projects in this workspace yet. Ask an admin to create one.",
"projectStatus": {
"notStarted": "Not started",
"complete": "Complete",
diff --git a/packages/permissions/src/index.ts b/packages/permissions/src/index.ts
index d18654f26..5f1c61340 100644
--- a/packages/permissions/src/index.ts
+++ b/packages/permissions/src/index.ts
@@ -51,3 +51,34 @@ export const owner = ac.newRole({
export const builtInRoles = { viewer, member, admin, owner } as const;
export type BuiltInRoleName = keyof typeof builtInRoles;
+
+// Default-role names that the API seeds per workspace. These ARE editable in
+// the UI (their permissions live as rows in `workspace_role`), but their names
+// are reserved and the rows are auto-created on workspace creation /
+// backfilled at boot. `owner` is intentionally NOT in this list because it
+// stays a true static role on the better-auth side.
+export const DEFAULT_ROLE_NAMES = ["viewer", "member", "admin"] as const;
+export type DefaultRoleName = (typeof DEFAULT_ROLE_NAMES)[number];
+
+function toMutablePayload(
+ statements: Record<string, readonly string[]>,
+): Record<string, string[]> {
+ const out: Record<string, string[]> = {};
+ for (const [resource, actions] of Object.entries(statements)) {
+ out[resource] = [...actions];
+ }
+ return out;
+}
+
+// Plain JSON-serializable permission payloads for the seeded default roles.
+// Mirrors each role's `.statements` (including better-auth's organization/
+// member/team/invitation/ac defaults) so a workspace_role row that uses one
+// of these has parity with the prior static definition.
+export const defaultRolePayloads: Record<
+ DefaultRoleName,
+ Record<string, string[]>
+> = {
+ viewer: toMutablePayload(viewer.statements),
+ member: toMutablePayload(member.statements),
+ admin: toMutablePayload(admin.statements),
+};