Skip to content

armgit / kaneo

Public Imported from GitHub
0

⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.

fix: prevent task number gaps during partial import failures

Sunildc45f26915f4
diff --git a/apps/api/src/task/controllers/import-tasks.ts b/apps/api/src/task/controllers/import-tasks.ts
index b249202e0..dae432cce 100644
--- a/apps/api/src/task/controllers/import-tasks.ts
+++ b/apps/api/src/task/controllers/import-tasks.ts
@@ -8,7 +8,7 @@ import {
coerceStatus,
getValidTaskStatuses,
} from "../validate-task-fields";
-import claimTaskNumbers from "./claim-task-numbers";
+import { claimTaskNumber } from "./claim-task-numbers";
export type ImportTask = {
title: string;
@@ -35,10 +35,6 @@ async function importTasks(
});
}
- let taskNumber =
- tasksToImport.length > 0
- ? (await claimTaskNumbers(projectId, tasksToImport.length)) - 1
- : 0;
const validStatuses = await getValidTaskStatuses(projectId);
const results = [];
@@ -61,21 +57,29 @@ async function importTasks(
),
});
- const [createdTask] = await db
- .insert(taskTable)
- .values({
- projectId,
- userId: taskData.userId || null,
- title: taskData.title,
- status,
- columnId: column?.id ?? null,
- startDate: taskData.startDate ? new Date(taskData.startDate) : null,
- dueDate: taskData.dueDate ? new Date(taskData.dueDate) : null,
- description: taskData.description || "",
- priority,
- number: ++taskNumber,
- })
- .returning();
+ const createdTask = await db.transaction(async (tx) => {
+ const taskNumber = await claimTaskNumber(projectId, tx);
+
+ const [task] = await tx
+ .insert(taskTable)
+ .values({
+ projectId,
+ userId: taskData.userId || null,
+ title: taskData.title,
+ status,
+ columnId: column?.id ?? null,
+ startDate: taskData.startDate
+ ? new Date(taskData.startDate)
+ : null,
+ dueDate: taskData.dueDate ? new Date(taskData.dueDate) : null,
+ description: taskData.description || "",
+ priority,
+ number: taskNumber,
+ })
+ .returning();
+
+ return task;
+ });
if (createdTask) {
await publishEvent("task.created", {