Skip to content

armgit / kaneo

Public Imported from GitHub
0

⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.

Merge canonical reorder snapshots into incremental boards

Tindcd5c75467ee
diff --cc apps/web/src/components/kanban-board/index.tsx
index 0cae81022,082ac8ba3..9212d9018
--- a/apps/web/src/components/kanban-board/index.tsx
+++ b/apps/web/src/components/kanban-board/index.tsx
@@@ -1,4 -1,4 +1,5 @@@
+import { markBoardCacheChanged } from "@/lib/board-cache-version";
+ import { selectReorderBoard } from "./select-reorder-board";
import {
closestCorners,
DndContext,
@@@ -188,15 -188,13 +189,18 @@@ function KanbanBoard(
const activeId = active.id.toString();
const overId = over.id.toString();
- if (isReordering) return;
+ if (
+ isReordering ||
+ queryClient.getQueryState(["tasks", project.id])?.fetchStatus ===
+ "fetching"
+ )
+ return;
- const canonical =
- queryClient.getQueryData<ProjectWithTasks>(["tasks", project.id]) ??
- (storedProject?.id === project.id ? storedProject : undefined);
+ const canonical = selectReorderBoard(
+ project.id,
+ activeId,
+ queryClient.getQueryData<ProjectWithTasks>(["tasks", project.id]),
+ storedProject,
+ );
if (!canonical) return;
const moved = moveBoardTask(canonical, activeId, overId, sortedByNumber);
diff --cc tests/api-integration/column-live-updates.test.ts
index 000000000,000000000..0f2178d79
new file mode 100644
--- /dev/null
+++ b/tests/api-integration/column-live-updates.test.ts
@@@ -1,0 -1,0 +1,38 @@@
++import { beforeEach, expect, it, vi } from "vite-plus/test";
++import db from "../../apps/api/src/database";
++import createColumn from "../../apps/api/src/column/controllers/create-column";
++import updateColumn from "../../apps/api/src/column/controllers/update-column";
++import deleteColumn from "../../apps/api/src/column/controllers/delete-column";
++import reorderColumns from "../../apps/api/src/column/controllers/reorder-columns";
++import { resetTestDatabase } from "./helpers/database";
++import {
++ createWorkspaceMember,
++ createProjectFixture,
++} from "./helpers/fixtures";
++const publish = vi.hoisted(() => vi.fn(async () => {}));
++vi.mock("../../apps/api/src/events", () => ({ publishEvent: publish }));
++beforeEach(async () => {
++ await resetTestDatabase();
++ publish.mockClear();
++});
++it("announces committed column changes for focused remote boards", async () => {
++ const { workspace } = await createWorkspaceMember();
++ const { project } = await createProjectFixture({ workspaceId: workspace.id });
++ const column = await createColumn({ projectId: project.id, name: "Review" });
++ await updateColumn(column.id, { name: "Reviewed", color: "#123456" });
++ await reorderColumns(project.id, [{ id: column.id, position: 0 }]);
++ await deleteColumn(column.id);
++ expect(publish.mock.calls).toEqual(
++ Array.from({ length: 4 }, () => [
++ "project.updated",
++ { projectId: project.id },
++ ]),
++ );
++ expect(
++ await db.query.columnTable.findFirst({
++ where: (table, { eq }) => eq(table.id, column.id),
++ }),
++ ).toBeUndefined();
++ await expect(deleteColumn(column.id)).rejects.toThrow("Column not found");
++ expect(publish).toHaveBeenCalledTimes(4);
++});