Skip to content

armgit / kaneo

Public Imported from GitHub
0

⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.

fix: allow project:update to edit workflow columns and project details (#2073)

Hexalysedee2190d1d4e
diff --git a/apps/web/src/components/project/columns/column-list.test.tsx b/apps/web/src/components/project/columns/column-list.test.tsx
index 968f05b2f..36c621c9b 100644
--- a/apps/web/src/components/project/columns/column-list.test.tsx
+++ b/apps/web/src/components/project/columns/column-list.test.tsx
@@ -18,7 +18,7 @@ import { ColumnList } from "@/components/project/columns/column-list";
import { toast } from "@/lib/toast";
const m = vi.hoisted(() => ({
- canManage: true,
+ canUpdate: true,
createColumn: vi.fn(),
updateColumn: vi.fn(),
deleteColumn: vi.fn(),
@@ -31,7 +31,7 @@ vi.mock("react-i18next", () => ({
}));
vi.mock("@/lib/toast", () => ({ toast: { success: vi.fn(), error: vi.fn() } }));
vi.mock("@/hooks/use-workspace-permission", () => ({
- useWorkspacePermission: () => ({ canManageProjects: () => m.canManage }),
+ useWorkspacePermission: () => ({ canUpdateProjects: () => m.canUpdate }),
}));
vi.mock("@/hooks/queries/column/use-get-columns", () => ({
useGetColumns: () => ({
@@ -72,7 +72,7 @@ vi.mock("@/hooks/mutations/column/use-reorder-columns", () => ({
describe("ColumnList", () => {
beforeEach(() => {
vi.clearAllMocks();
- m.canManage = true;
+ m.canUpdate = true;
for (const fn of [m.createColumn, m.updateColumn, m.deleteColumn]) {
fn.mockResolvedValue({});
}
@@ -174,8 +174,8 @@ describe("ColumnList", () => {
await waitFor(() => expect(input).toHaveValue(""));
});
- it("is read-only without permission to manage projects", () => {
- m.canManage = false;
+ it("is read-only without permission to update projects", () => {
+ m.canUpdate = false;
render(<ColumnList projectId="p1" />);
expect(
screen.queryByRole("button", { name: "settings:columnEditor.addColumn" }),
diff --git a/apps/web/src/components/project/columns/column-list.tsx b/apps/web/src/components/project/columns/column-list.tsx
index 98cb779fa..f183f1063 100644
--- a/apps/web/src/components/project/columns/column-list.tsx
+++ b/apps/web/src/components/project/columns/column-list.tsx
@@ -32,8 +32,8 @@ export function ColumnList({ projectId }: ColumnListProps) {
const { mutateAsync: updateColumn } = useUpdateColumn();
const { mutateAsync: deleteColumn, isPending: deleting } = useDeleteColumn();
const { mutateAsync: reorderColumns } = useReorderColumns();
- const { canManageProjects } = useWorkspacePermission();
- const canEdit = canManageProjects();
+ const { canUpdateProjects } = useWorkspacePermission();
+ const canEdit = canUpdateProjects();
const [pendingDelete, setPendingDelete] = useState<ProjectColumn | null>(
null,
);
diff --git a/apps/web/src/components/settings/project-general/project-general-page.tsx b/apps/web/src/components/settings/project-general/project-general-page.tsx
index 9f0817589..e289ee60f 100644
--- a/apps/web/src/components/settings/project-general/project-general-page.tsx
+++ b/apps/web/src/components/settings/project-general/project-general-page.tsx
@@ -21,8 +21,8 @@ export function ProjectGeneralPage() {
const { data: fetchedProject } = useGetTasks(projectId);
const { project, setProject } = useProjectStore();
const isCurrentProject = project?.id === projectId;
- const { canManageProjects, canDeleteProjects } = useWorkspacePermission();
- const canEdit = canManageProjects();
+ const { canUpdateProjects, canDeleteProjects } = useWorkspacePermission();
+ const canEdit = canUpdateProjects();
const canDelete = canDeleteProjects();
const { form, flushPendingSave } = useProjectAutosave({
project,