⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.
TypeScript honoissue-managementissue-trackerjira-alternativekanbanlinear-alternativemcpproject-managementreactself-hostedtypescript
fix(mcp): validate registered redirect URIs (#1381)
Tin Severe18eb00e2d49
diff --git a/apps/api/src/mcp/controllers/oauth-consent.ts b/apps/api/src/mcp/controllers/oauth-consent.tsindex a15b1b824..7023cfee6 100644--- a/apps/api/src/mcp/controllers/oauth-consent.ts+++ b/apps/api/src/mcp/controllers/oauth-consent.ts@@ -1,6 +1,7 @@import { HTTPException } from "hono/http-exception";import type * as v from "valibot";import { auth } from "../../auth";+import { publishEvent } from "../../events";import {consumeAuthorizationRequest,createAuthCode,@@ -134,5 +135,10 @@ export async function decideMcpAuthorizationRequest(params: {codeChallenge: request.codeChallenge,redirectUri: request.redirectUri,});+ await publishEvent("mcp.authorization_code_issued", {+ clientId: request.clientId,+ userId: session.user.id,+ redirectUri: request.redirectUri,+ });return buildAuthorizationRedirect(request, { code });}diff --git a/apps/api/src/mcp/oauth.ts b/apps/api/src/mcp/oauth.tsindex 42c82e401..f1b4ca2cd 100644--- a/apps/api/src/mcp/oauth.ts+++ b/apps/api/src/mcp/oauth.ts@@ -54,7 +54,7 @@ export function registerClient(params: {const clientId = randomUUID();const client: RegisteredClient = {clientId,- redirectUris: params.redirectUris,+ redirectUris: [...params.redirectUris],clientName: params.clientName,issuedAt: Math.floor(Date.now() / 1000),};