Skip to content

armgit / kaneo

Public Imported from GitHub
0

⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.

fix(api): settle archived state echoes during deferred replay

Tinfff929bf9131
diff --git a/apps/api/src/plugins/github/services/deferred-issue-edits.ts b/apps/api/src/plugins/github/services/deferred-issue-edits.ts
index 49a5bcec2..867171bfe 100644
--- a/apps/api/src/plugins/github/services/deferred-issue-edits.ts
+++ b/apps/api/src/plugins/github/services/deferred-issue-edits.ts
@@ -263,6 +263,11 @@ async function replayClaimedIssueEdits() {
const keepsState =
fields.includes("state") && task.status === "archived";
if (keepsState) current.state = values.state;
+ // Its own uncertain write echoing back settles the intent instead.
+ const stateEcho =
+ keepsState &&
+ uncertainOutboundIntents(current.lastSync?.state, values.state)
+ .length > 0;
for (const field of fields) {
if (field === "state" && keepsState) continue;
const stamp = current.lastSync?.[field];
@@ -313,6 +318,7 @@ async function replayClaimedIssueEdits() {
const accepted = job.fields.filter(
(field) =>
!repairs.some((repair) => repair.field === field) &&
+ !(field === "state" && stateEcho) &&
!(
field === "state" &&
integration.type === "github" &&
diff --git a/tests/api-integration/deferred-issue-edits.test.ts b/tests/api-integration/deferred-issue-edits.test.ts
index fbf18138d..6d0689d5c 100644
--- a/tests/api-integration/deferred-issue-edits.test.ts
+++ b/tests/api-integration/deferred-issue-edits.test.ts
@@ -1738,6 +1738,61 @@ it.each(["github", "gitea"])(
},
);
+it.each(["github", "gitea"])(
+ "settles a delayed %s close echo for an archived task and applies text edits",
+ async (type) => {
+ const { task, integration, link } = await seed(type);
+ await db
+ .update(schema.externalLinkTable)
+ .set({ metadata: "{}" })
+ .where(eq(schema.externalLinkTable.id, link.id));
+ await db
+ .update(schema.taskTable)
+ .set({ status: "done" })
+ .where(eq(schema.taskTable.id, task.id));
+ await expect(
+ syncLatestTaskValue(
+ task.id,
+ integration.projectId,
+ link,
+ "state",
+ "closed",
+ async () => {
+ throw new Error("provider timeout");
+ },
+ ),
+ ).rejects.toThrow("provider timeout");
+ await db
+ .update(schema.taskTable)
+ .set({ status: "archived", columnId: null })
+ .where(eq(schema.taskTable.id, task.id));
+ await deferIssueEdit(link, integration, ["state", "title", "description"]);
+ expect((await metadata(link.id)).deferredIssueEdit.fields).toEqual([
+ "state",
+ "title",
+ "description",
+ ]);
+
+ await replayDeferredIssueEdits();
+
+ expect(m.write).not.toHaveBeenCalled();
+ const after = await metadata(link.id);
+ expect(after.deferredIssueEdit).toBeUndefined();
+ expect(after.state).toBe("closed");
+ expect(
+ after.lastSync.state.outbound.filter(
+ (entry: { uncertain?: boolean; cancelled?: boolean }) =>
+ entry.uncertain && !entry.cancelled,
+ ),
+ ).toEqual([]);
+ expect(await current(task.id)).toMatchObject({
+ status: "archived",
+ title: "A",
+ description: "recovered body",
+ });
+ },
+);
+
it("skips provider reads and writes while another replica holds the worker lease", async () => {
const { link, integration } = await seed();
await deferTaskSync(link, integration, ["title"]);