Skip to content

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search

fix: skip session redirect from the mobile signup inline browser

Mohamed Bassem0416ef463258
diff --git a/apps/mobile/app/signin.tsx b/apps/mobile/app/signin.tsx
index 94a57822..61ece071 100644
--- a/apps/mobile/app/signin.tsx
+++ b/apps/mobile/app/signin.tsx
@@ -84,7 +84,7 @@ export default function Signin() {
const onSignUp = async () => {
const serverAddress = settings.address ?? "https://cloud.karakeep.app";
- const signupUrl = `${serverAddress}/signup?redirectUrl=${encodeURIComponent("karakeep://signin")}`;
+ const signupUrl = `${serverAddress}/signup?redirectUrl=${encodeURIComponent("karakeep://signin")}&skipSessionRedirect=1`;
await WebBrowser.openAuthSessionAsync(signupUrl, "karakeep://signin");
};
diff --git a/apps/web/app/signup/page.tsx b/apps/web/app/signup/page.tsx
index 5c8b943e..6f1ec400 100644
--- a/apps/web/app/signup/page.tsx
+++ b/apps/web/app/signup/page.tsx
@@ -3,18 +3,24 @@ import KarakeepLogo from "@/components/KarakeepIcon";
import SignUpForm from "@/components/signup/SignUpForm";
import { getServerAuthSession } from "@/server/auth";
-import { validateRedirectUrl } from "@karakeep/shared/utils/redirectUrl";
+import {
+ isMobileAppRedirect,
+ validateRedirectUrl,
+} from "@karakeep/shared/utils/redirectUrl";
export default async function SignUpPage({
searchParams,
}: {
- searchParams: Promise<{ redirectUrl?: string }>;
+ searchParams: Promise<{ redirectUrl?: string; skipSessionRedirect?: string }>;
}) {
const session = await getServerAuthSession();
- const { redirectUrl: rawRedirectUrl } = await searchParams;
+ const { redirectUrl: rawRedirectUrl, skipSessionRedirect } =
+ await searchParams;
const redirectUrl = validateRedirectUrl(rawRedirectUrl) ?? "/";
+ const shouldSkipSessionRedirect =
+ isMobileAppRedirect(redirectUrl) && skipSessionRedirect === "1";
- if (session) {
+ if (session && !shouldSkipSessionRedirect) {
redirect(redirectUrl);
}