Skip to content

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search

refactor(plugins): avoid importing plugins that are not in use

Mohamed Bassem046cb17ec192
diff --git a/packages/plugins/queue-restate/index.ts b/packages/plugins/queue-restate/index.ts
index d313615c..fc5e6d3a 100644
--- a/packages/plugins/queue-restate/index.ts
+++ b/packages/plugins/queue-restate/index.ts
@@ -1,7 +1,26 @@
// Auto-register the Restate queue provider when this package is imported
import { PluginManager, PluginType } from "@karakeep/shared/plugins";
+import type { PluginProvider } from "@karakeep/shared/plugins";
+import type { QueueClient } from "@karakeep/shared/queueing";
-import { RestateQueueProvider } from "./src";
+import { envConfig } from "./src/env";
+
+export class RestateQueueProvider implements PluginProvider<QueueClient> {
+ private client: QueueClient | null = null;
+
+ static isConfigured(): boolean {
+ return envConfig.RESTATE_LISTEN_PORT !== undefined;
+ }
+
+ async getClient(): Promise<QueueClient | null> {
+ const { RestateQueueClient } = await import("./src");
+ if (!this.client) {
+ const client = new RestateQueueClient();
+ this.client = client;
+ }
+ return this.client;
+ }
+}
if (RestateQueueProvider.isConfigured()) {
PluginManager.register({
diff --git a/packages/plugins/queue-restate/src/index.ts b/packages/plugins/queue-restate/src/index.ts
index 59cf7d89..0f0fbfc5 100644
--- a/packages/plugins/queue-restate/src/index.ts
+++ b/packages/plugins/queue-restate/src/index.ts
@@ -3,7 +3,6 @@ import { format } from "node:util";
import * as restate from "@restatedev/restate-sdk";
import * as restateClient from "@restatedev/restate-sdk-clients";
-import type { PluginProvider } from "@karakeep/shared/plugins";
import type {
EnqueueOptions,
Queue,
@@ -127,7 +126,7 @@ class RestateRunnerWrapper<T> implements Runner<T> {
}
}
-class RestateQueueClient implements QueueClient {
+export class RestateQueueClient implements QueueClient {
private client: restateClient.Ingress;
private queues = new Map<string, RestateQueueWrapper<unknown>>();
private services = new Map<string, RestateRunnerWrapper<unknown>>();
@@ -218,19 +217,3 @@ class RestateQueueClient implements QueueClient {
// No-op for sqlite
}
}
-
-export class RestateQueueProvider implements PluginProvider<QueueClient> {
- private client: QueueClient | null = null;
-
- static isConfigured(): boolean {
- return envConfig.RESTATE_LISTEN_PORT !== undefined;
- }
-
- async getClient(): Promise<QueueClient | null> {
- if (!this.client) {
- const client = new RestateQueueClient();
- this.client = client;
- }
- return this.client;
- }
-}
diff --git a/packages/plugins/queue-restate/src/tests/queue.test.ts b/packages/plugins/queue-restate/src/tests/queue.test.ts
index fafde598..4d36a00b 100644
--- a/packages/plugins/queue-restate/src/tests/queue.test.ts
+++ b/packages/plugins/queue-restate/src/tests/queue.test.ts
@@ -12,8 +12,8 @@ import {
import type { Queue, QueueClient } from "@karakeep/shared/queueing";
import { QueueRetryAfterError } from "@karakeep/shared/queueing";
+import { RestateQueueProvider } from "../../index";
import { AdminClient } from "../admin";
-import { RestateQueueProvider } from "../index";
import { waitUntil } from "./utils";
class Baton {
diff --git a/packages/plugins/ratelimit-redis/index.ts b/packages/plugins/ratelimit-redis/index.ts
index 86a55c83..a66727ec 100644
--- a/packages/plugins/ratelimit-redis/index.ts
+++ b/packages/plugins/ratelimit-redis/index.ts
@@ -1,10 +1,28 @@
// Auto-register the RateLimit plugin when this package is imported
import serverConfig from "@karakeep/shared/config";
import { PluginManager, PluginType } from "@karakeep/shared/plugins";
+import type { PluginProvider } from "@karakeep/shared/plugins";
+import type { RateLimitClient } from "@karakeep/shared/ratelimiting";
-import { RedisRateLimitProvider } from "./src";
+interface RedisRateLimiterOptions {
+ url: string;
+}
+
+class RedisRateLimitProvider implements PluginProvider<RateLimitClient> {
+ private provider: PluginProvider<RateLimitClient> | null = null;
+
+ constructor(private readonly options: RedisRateLimiterOptions) {}
+
+ async getClient(): Promise<RateLimitClient | null> {
+ const { RedisRateLimitProvider: RedisRateLimitProviderImpl } =
+ await import("./src");
+ if (!this.provider) {
+ this.provider = new RedisRateLimitProviderImpl(this.options);
+ }
+ return this.provider.getClient();
+ }
+}
-// Only register if Redis configuration is provided
if (serverConfig.redis?.url) {
PluginManager.register({
type: PluginType.RateLimit,
@@ -14,6 +32,3 @@ if (serverConfig.redis?.url) {
}),
});
}
-
-// Export the provider and rate limiter class for advanced usage
-export { RedisRateLimiter, RedisRateLimitProvider } from "./src";