Skip to content

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search

fix: address some lint errors

Mohamed Bassem3b0c9ecce6f3
diff --git a/apps/mobile/app/dashboard/(tabs)/(lists)/index.tsx b/apps/mobile/app/dashboard/(tabs)/(lists)/index.tsx
index 0af35832..2cb33ddc 100644
--- a/apps/mobile/app/dashboard/(tabs)/(lists)/index.tsx
+++ b/apps/mobile/app/dashboard/(tabs)/(lists)/index.tsx
@@ -1,4 +1,4 @@
-import { useEffect, useMemo, useState } from "react";
+import { useMemo, useState } from "react";
import {
FlatList,
Platform,
@@ -79,7 +79,7 @@ function traverseTree(
export default function Lists() {
const { colors } = useColorScheme();
const [refreshing, setRefreshing] = useState(false);
- const { data: lists, isPending, error, refetch } = useBookmarkLists();
+ const { data: lists, error, refetch } = useBookmarkLists();
const [showChildrenOf, setShowChildrenOf] = useState<Record<string, boolean>>(
{},
);
@@ -103,18 +103,23 @@ export default function Lists() {
);
}, [lists?.root, hasSharedLists]);
- useEffect(() => {
- setRefreshing(isPending);
- }, [isPending]);
-
if (!lists) {
return <QueryPageState error={error} onRetry={() => refetch()} />;
}
- const onRefresh = () => {
- queryClient.invalidateQueries(api.lists.list.pathFilter());
- queryClient.invalidateQueries(api.lists.stats.pathFilter());
- queryClient.invalidateQueries(api.lists.getPendingInvitations.pathFilter());
+ const onRefresh = async () => {
+ setRefreshing(true);
+ try {
+ await Promise.all([
+ queryClient.invalidateQueries(api.lists.list.pathFilter()),
+ queryClient.invalidateQueries(api.lists.stats.pathFilter()),
+ queryClient.invalidateQueries(
+ api.lists.getPendingInvitations.pathFilter(),
+ ),
+ ]);
+ } finally {
+ setRefreshing(false);
+ }
};
const links: ListLink[] = [
diff --git a/apps/mobile/app/dashboard/(tabs)/(tags)/index.tsx b/apps/mobile/app/dashboard/(tabs)/(tags)/index.tsx
index 4adba8e5..c32b4817 100644
--- a/apps/mobile/app/dashboard/(tabs)/(tags)/index.tsx
+++ b/apps/mobile/app/dashboard/(tabs)/(tags)/index.tsx
@@ -1,4 +1,4 @@
-import { useEffect, useState } from "react";
+import { useState } from "react";
import {
FlatList,
Platform,
@@ -54,16 +54,17 @@ export default function Tags() {
nameContains: debouncedSearch,
});
- useEffect(() => {
- setRefreshing(isPending);
- }, [isPending]);
-
if (!data) {
return <QueryPageState error={error} onRetry={() => refetch()} />;
}
- const onRefresh = () => {
- queryClient.invalidateQueries(api.tags.list.pathFilter());
+ const onRefresh = async () => {
+ setRefreshing(true);
+ try {
+ await queryClient.invalidateQueries(api.tags.list.pathFilter());
+ } finally {
+ setRefreshing(false);
+ }
};
const tags: TagItem[] = data.tags.map((tag) => ({
diff --git a/apps/mobile/app/test-connection.tsx b/apps/mobile/app/test-connection.tsx
index cecf69b2..40547322 100644
--- a/apps/mobile/app/test-connection.tsx
+++ b/apps/mobile/app/test-connection.tsx
@@ -10,7 +10,7 @@ import { z } from "zod";
export default function TestConnection() {
const { settings, isLoading } = useAppSettings();
const [text, setText] = React.useState("");
- const [randomId, setRandomId] = React.useState(Math.random());
+ const [randomId, setRandomId] = React.useState(() => Math.random());
const [status, setStatus] = React.useState<"running" | "success" | "error">(
"running",
);
diff --git a/apps/web/components/dashboard/bookmarks/BookmarkLayoutAdaptingCard.tsx b/apps/web/components/dashboard/bookmarks/BookmarkLayoutAdaptingCard.tsx
index e8e13e90..210cce93 100644
--- a/apps/web/components/dashboard/bookmarks/BookmarkLayoutAdaptingCard.tsx
+++ b/apps/web/components/dashboard/bookmarks/BookmarkLayoutAdaptingCard.tsx
@@ -125,6 +125,7 @@ function BulkEditSelectionOverlay({ bookmark }: { bookmark: ZBookmark }) {
const toggleBookmark = useBulkActionsStore((state) => state.toggleBookmark);
const { resolvedTheme } = useTheme();
const { data: session } = useSession();
+ const { t } = useTranslation();
// Don't show selector for non-owned bookmarks or when bulk edit is disabled
const isOwner = session?.user?.id === bookmark.userId;
@@ -139,6 +140,8 @@ function BulkEditSelectionOverlay({ bookmark }: { bookmark: ZBookmark }) {
},
resolvedTheme === "dark" ? "bg-white" : "bg-black",
)}
+ aria-label={t("actions.select")}
+ aria-pressed={isSelected}
onClick={() => toggleBookmark(bookmark.id)}
></button>
);
diff --git a/apps/web/components/dashboard/lists/EditListModal.tsx b/apps/web/components/dashboard/lists/EditListModal.tsx
index bd1145c2..680b047e 100644
--- a/apps/web/components/dashboard/lists/EditListModal.tsx
+++ b/apps/web/components/dashboard/lists/EditListModal.tsx
@@ -41,7 +41,7 @@ import { toast } from "@/components/ui/sonner";
import { useTranslation } from "@/lib/i18n/client";
import { zodResolver } from "@hookform/resolvers/zod";
import { X } from "lucide-react";
-import { useForm } from "react-hook-form";
+import { useForm, useWatch } from "react-hook-form";
import { z } from "zod";
import {
@@ -123,13 +123,13 @@ export function EditListModal({
});
}, [open]);
+ const query = useWatch({ control: form.control, name: "query" });
const parsedSearchQuery = useMemo(() => {
- const query = form.getValues().query;
if (!query) {
return undefined;
}
return parseSearchQuery(query);
- }, [form.watch("query")]);
+ }, [query]);
const { mutate: createList, isPending: isCreating } = useCreateBookmarkList({
onSuccess: (resp) => {
@@ -195,7 +195,7 @@ export function EditListModal({
}
},
});
- const listType = form.watch("type");
+ const listType = useWatch({ control: form.control, name: "type" });
useEffect(() => {
if (listType !== "smart") {
diff --git a/apps/web/lib/readerSettings.tsx b/apps/web/lib/readerSettings.tsx
index 5966f287..e4990af7 100644
--- a/apps/web/lib/readerSettings.tsx
+++ b/apps/web/lib/readerSettings.tsx
@@ -61,17 +61,14 @@ export function ReaderSettingsProvider({
[sessionOverrides],
);
- // Memoize callbacks to prevent unnecessary re-renders
- const getLocalOverrides = useCallback(getLocalOverridesFromStorage, []);
- const saveLocalOverrides = useCallback(saveLocalOverridesToStorage, []);
const onClearSessionOverrides = useCallback(() => {
setSessionOverrides({});
}, []);
return (
<BaseReaderSettingsProvider
- getLocalOverrides={getLocalOverrides}
- saveLocalOverrides={saveLocalOverrides}
+ getLocalOverrides={getLocalOverridesFromStorage}
+ saveLocalOverrides={saveLocalOverridesToStorage}
sessionOverrides={sessionOverrides}
onClearSessionOverrides={onClearSessionOverrides}
>