A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search
fix(restate): call onError on rpc failures
Mohamed Bassem4fd0eaf036d9
diff --git a/packages/plugins/package.json b/packages/plugins/package.jsonindex f263d593..06aafbfa 100644--- a/packages/plugins/package.json+++ b/packages/plugins/package.json@@ -20,8 +20,8 @@},"dependencies": {"@karakeep/shared": "workspace:*",- "@restatedev/restate-sdk": "^1.9.0",- "@restatedev/restate-sdk-clients": "^1.9.0",+ "@restatedev/restate-sdk": "^1.10.3",+ "@restatedev/restate-sdk-clients": "^1.10.3","async-mutex": "^0.4.1","liteque": "^0.7.0","meilisearch": "^0.45.0"diff --git a/packages/plugins/queue-restate/src/dispatcher.ts b/packages/plugins/queue-restate/src/dispatcher.tsindex 6b48a571..3a03dbf2 100644--- a/packages/plugins/queue-restate/src/dispatcher.ts+++ b/packages/plugins/queue-restate/src/dispatcher.ts@@ -66,13 +66,13 @@ export function buildDispatcherService<T, R>(groupId?: string;},) => {- const id = ctx.rand.uuidv4();+ const id = ctx.request().id;const priority = data.priority ?? 0;const logDebug = async (message: string) => {await ctx.run("log",async () => {- logger.debug(message);+ logger.debug(`[${queue.name()}][${id}] ${message}`);},{maxRetryAttempts: 1,@@ -124,15 +124,34 @@ export function buildDispatcherService<T, R>(// Handle RPC-level errors (e.g., runner service unavailable)if (res.error) {+ const errorMessage =+ res.error instanceof Error+ ? res.error.message+ : String(res.error);await logDebug(- `Dispatcher RPC error for queue ${queue.name()} job ${id}: ${res.error instanceof Error ? res.error.message : String(res.error)}`,+ `Dispatcher RPC error for queue ${queue.name()} job ${id}: ${errorMessage}`,);await semaphore.release(leaseId);if (res.error instanceof restate.CancelledError) {throw res.error;}- // Retry with backoff- await ctx.sleep(1000, "rpc error retry");+ // Notify the runner of the RPC error+ await tryCatch(+ runner.onError({+ job: jobData,+ error: {+ name:+ res.error instanceof Error ? res.error.name : "RPCError",+ message: errorMessage,+ stack:+ res.error instanceof Error ? res.error.stack : undefined,+ },+ }),+ );+ // Retry with exponential backoff + full jitter+ const baseMs = Math.min(5000 * 2 ** runNumber, 60000);+ const delayMs = Math.floor(ctx.rand.random() * baseMs);+ await ctx.sleep(delayMs, "rpc error retry");runNumber++;continue;}diff --git a/packages/plugins/queue-restate/src/tests/docker-compose.yml b/packages/plugins/queue-restate/src/tests/docker-compose.ymlindex f24c2921..989feb79 100644--- a/packages/plugins/queue-restate/src/tests/docker-compose.yml+++ b/packages/plugins/queue-restate/src/tests/docker-compose.yml@@ -1,6 +1,6 @@services:restate:- image: docker.restate.dev/restatedev/restate:1.5+ image: docker.restate.dev/restatedev/restate:1.6.1ports:- "${RESTATE_INGRESS_PORT:-8080}:8080"- "${RESTATE_ADMIN_PORT:-9070}:9070"diff --git a/pnpm-lock.yaml b/pnpm-lock.yamlindex 96f3b5e7..b33dd84f 100644--- a/pnpm-lock.yaml+++ b/pnpm-lock.yaml@@ -1275,11 +1275,11 @@ importers:specifier: workspace:*version: link:../shared'@restatedev/restate-sdk':- specifier: ^1.9.0- version: 1.9.0+ specifier: ^1.10.3+ version: 1.10.3'@restatedev/restate-sdk-clients':- specifier: ^1.9.0- version: 1.9.0+ specifier: ^1.10.3+ version: 1.10.3async-mutex:specifier: ^0.4.1version: 0.4.1@@ -5482,17 +5482,14 @@ packages:'@remusao/[email protected]':resolution: {integrity: sha512-Er3Q8q0/2OcCJPQYJOPLmCuqO0wu7cav3SPtpjlxSbjFi1x+A1pZkkLD6c9q2rGEkGW/tkrRzfrhNMt8VQjzXg==}- '@restatedev/[email protected]':- resolution: {integrity: sha512-vgKlDXQ4fkR9EU+MF/37edxmrLfFlGlorXsbumhkriGgBVimTKigdl/sdSphcAqdnPIq/tBd3H18Qj83uxKezQ==}- engines: {node: '>= 20.19'}+ '@restatedev/[email protected]':+ resolution: {integrity: sha512-Ik6pYMLUfR08N1dcHILd8tbYDrUQoxjmOE6ymnnw08SB1EGarVJOrzGhZDf7LR30Oc490sGSl5ye0OAdesz6fA==}- '@restatedev/[email protected]':- resolution: {integrity: sha512-q3S7hnxcP3zU8cDcaAkYmO50zT8dykzaBm65D+hyJgba74gs/h5HMjbS8gbZgRezbJHtRrRsJmnNFet/qCj4pQ==}- engines: {node: '>= 20.19'}+ '@restatedev/[email protected]':+ resolution: {integrity: sha512-lkBGaYp9hDJEtc2Te3nfvrJr45dSHbmnUrygNWyfkxb9/98/hUZantC9UKFyaccGuEELnVl8NOvyxGC3bK1dDw==}- '@restatedev/[email protected]':- resolution: {integrity: sha512-PSvFpiD7qGN1DVBWuFHR4x5j8Mk6rAl5r75/XUAfW/YN/YchuTK4jIO4nqBLvbJ4dzioDlFbLmLZprKBVfX2tA==}- engines: {node: '>= 20.19'}+ '@restatedev/[email protected]':+ resolution: {integrity: sha512-q8pBmhjC8knEIlsI3B4XR8EqxDwptuJkfq940Z0arMSIDagE1ek6JkjKTdIEAdVpkyBSQJu2fWgtA3OBl2iF6A==}'@rn-primitives/[email protected]':resolution: {integrity: sha512-BR97reSu7uVDpyMeQdRJHT0w8KdS6jdYnOL6xQtqS2q3H6N7vXBlX4LFERqJZphD+aziJFIAJ3HJF1vtt6XlpQ==}@@ -18582,7 +18579,7 @@ snapshots:'@docusaurus/[email protected]([email protected])':dependencies:- '@types/react': 19.1.8+ '@types/react': 19.2.5react: 19.2.3'@docusaurus/[email protected](@types/[email protected])([email protected])([email protected]([email protected]))([email protected])([email protected])':@@ -21721,15 +21718,15 @@ snapshots:'@remusao/[email protected]': {}- '@restatedev/[email protected]':+ '@restatedev/[email protected]':dependencies:- '@restatedev/restate-sdk-core': 1.9.0+ '@restatedev/restate-sdk-core': 1.10.3- '@restatedev/[email protected]': {}+ '@restatedev/[email protected]': {}- '@restatedev/[email protected]':+ '@restatedev/[email protected]':dependencies:- '@restatedev/restate-sdk-core': 1.9.0+ '@restatedev/restate-sdk-core': 1.10.3'@rn-primitives/[email protected]([email protected]([email protected])([email protected]([email protected]))([email protected]))([email protected](@babel/[email protected])(@types/[email protected])([email protected]))([email protected])':dependencies:@@ -23534,7 +23531,7 @@ snapshots:dependencies:- '@babel/runtime': 7.28.4+ '@babel/runtime': 7.28.6cosmiconfig: 7.1.0resolve: 1.22.10@@ -28352,7 +28349,7 @@ snapshots:dependencies:'@babel/traverse': 7.28.5- '@babel/traverse--for-generate-function-map': '@babel/[email protected]'+ '@babel/traverse--for-generate-function-map': '@babel/[email protected]''@babel/types': 7.28.5flow-enums-runtime: 0.0.6invariant: 2.2.4