A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search
fix(browser-extension): handle unreachable background script on Firef… (#2649)
Joly06d54cd7eedda
diff --git a/apps/browser-extension/src/BookmarkSavedPage.tsx b/apps/browser-extension/src/BookmarkSavedPage.tsxindex 3be5f9d0..dc2647b7 100644--- a/apps/browser-extension/src/BookmarkSavedPage.tsx+++ b/apps/browser-extension/src/BookmarkSavedPage.tsx@@ -22,14 +22,19 @@ export default function BookmarkSavedPage() {const { mutate: deleteBookmark, isPending } = useDeleteBookmark({onSuccess: async () => {- const [currentTab] = await chrome.tabs.query({- active: true,- lastFocusedWindow: true,- });- await chrome.runtime.sendMessage({- type: MessageType.BOOKMARK_REFRESH_BADGE,- currentTab: currentTab,- });+ try {+ const [currentTab] = await chrome.tabs.query({+ active: true,+ lastFocusedWindow: true,+ });+ await chrome.runtime.sendMessage({+ type: MessageType.BOOKMARK_REFRESH_BADGE,+ currentTab: currentTab,+ });+ } catch {+ // Badge refresh is best-effort — on Firefox Android the background+ // script may not be reachable from the popup context.+ }navigate("/bookmarkdeleted");},onError: (e) => {diff --git a/apps/browser-extension/src/SavePage.tsx b/apps/browser-extension/src/SavePage.tsxindex 5f55e164..4bbb82a8 100644--- a/apps/browser-extension/src/SavePage.tsx+++ b/apps/browser-extension/src/SavePage.tsx@@ -29,14 +29,19 @@ export default function SavePage() {},onSuccess: async () => {// After successful creation, update badge cache and notify background- const [currentTab] = await chrome.tabs.query({- active: true,- lastFocusedWindow: true,- });- await chrome.runtime.sendMessage({- type: MessageType.BOOKMARK_REFRESH_BADGE,- currentTab: currentTab,- });+ try {+ const [currentTab] = await chrome.tabs.query({+ active: true,+ lastFocusedWindow: true,+ });+ await chrome.runtime.sendMessage({+ type: MessageType.BOOKMARK_REFRESH_BADGE,+ currentTab: currentTab,+ });+ } catch {+ // Badge refresh is best-effort — on Firefox Android the background+ // script may not be reachable from the popup context.+ }},}),);