A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search
fix(web): make bulk selection touch friendly (#3015)
Mohamed Bassem6f375972e1ec
diff --git a/apps/web/components/dashboard/BulkBookmarksAction.tsx b/apps/web/components/dashboard/BulkBookmarksAction.tsxindex 784d0143..e2498d9a 100644--- a/apps/web/components/dashboard/BulkBookmarksAction.tsx+++ b/apps/web/components/dashboard/BulkBookmarksAction.tsx@@ -1,6 +1,7 @@"use client";import { useEffect, useRef, useState } from "react";+import { createPortal } from "react-dom";import { usePathname } from "next/navigation";import {ActionButton,@@ -35,6 +36,9 @@ export default function BulkBookmarksAction() {useState(false);const [manageListsModal, setManageListsModalOpen] = useState(false);const [bulkTagModal, setBulkTagModalOpen] = useState(false);+ const [portalContainer, setPortalContainer] = useState<HTMLElement | null>(+ null,+ );const pathname = usePathname();const currentPathnameRef = useRef(pathname);@@ -74,6 +78,10 @@ export default function BulkBookmarksAction() {},});+ useEffect(() => {+ setPortalContainer(document.body);+ }, []);+// Reset bulk edit state when the route changesuseEffect(() => {if (pathname !== currentPathnameRef.current) {@@ -244,6 +252,57 @@ export default function BulkBookmarksAction() {},];+ const renderActions = (mobile: boolean) => (+ <div className="flex min-w-max items-center">+ {actionList.map(+ ({ name, icon, action, isPending, hidden, alwaysEnable }) => {+ const className = `${hidden ? "hidden" : "block"} ${+ mobile && alwaysEnable ? "-order-1" : ""+ }`;+ const disabled = !selectedBookmarks.length && !alwaysEnable;++ if (mobile) {+ return (+ <ActionButton+ aria-label={name}+ title={name}+ className={className}+ disabled={disabled}+ loading={!!isPending}+ variant="ghost"+ key={name}+ onClick={action}+ >+ {icon}+ </ActionButton>+ );+ }++ return (+ <ActionButtonWithTooltip+ className={className}+ tooltip={name}+ disabled={disabled}+ delayDuration={100}+ loading={!!isPending}+ variant="ghost"+ key={name}+ onClick={action}+ >+ {icon}+ </ActionButtonWithTooltip>+ );+ },+ )}+ </div>+ );++ const isModalOpen =+ isDeleteDialogOpen ||+ isRemoveFromListDialogOpen ||+ manageListsModal ||+ bulkTagModal;+return (<div><ActionConfirmingDialog@@ -293,24 +352,21 @@ export default function BulkBookmarksAction() {open={bulkTagModal}setOpen={setBulkTagModalOpen}/>- <div className="flex items-center">- {actionList.map(- ({ name, icon: Icon, action, isPending, hidden, alwaysEnable }) => (- <ActionButtonWithTooltip- className={hidden ? "hidden" : "block"}- tooltip={name}- disabled={!selectedBookmarks.length && !alwaysEnable}- delayDuration={100}- loading={!!isPending}- variant="ghost"- key={name}- onClick={action}- >- {Icon}- </ActionButtonWithTooltip>- ),- )}- </div>+ {portalContainer && isBulkEditEnabled && !isModalOpen+ ? createPortal(+ <div className="fixed inset-x-3 bottom-[calc(env(safe-area-inset-bottom)+0.75rem)] z-[70] sm:bottom-6 sm:left-1/2 sm:right-auto sm:w-max sm:max-w-[calc(100vw-2rem)] sm:-translate-x-1/2">+ <div+ aria-label={t("actions.bulk_edit")}+ className="overflow-x-auto rounded-2xl border bg-background/95 p-1 shadow-2xl ring-1 ring-black/5 backdrop-blur-sm duration-200 animate-in fade-in slide-in-from-bottom-2 motion-reduce:animate-none dark:ring-white/10"+ role="toolbar"+ >+ <div className="sm:hidden">{renderActions(true)}</div>+ <div className="hidden sm:block">{renderActions(false)}</div>+ </div>+ </div>,+ portalContainer,+ )+ : null}</div>);}diff --git a/apps/web/components/dashboard/bookmarks/BookmarkOptions.tsx b/apps/web/components/dashboard/bookmarks/BookmarkOptions.tsxindex 50d214ef..458ddede 100644--- a/apps/web/components/dashboard/bookmarks/BookmarkOptions.tsx+++ b/apps/web/components/dashboard/bookmarks/BookmarkOptions.tsx@@ -12,11 +12,13 @@ import {DropdownMenuTrigger,} from "@/components/ui/dropdown-menu";import { useSession } from "@/lib/auth/client";+import useBulkActionsStore from "@/lib/bulkActions";import { useClientConfig } from "@/lib/clientConfig";import useUpload from "@/lib/hooks/upload-file";import { useTranslation } from "@/lib/i18n/client";import {Archive,+ Circle,Download,FileDown,FileText,@@ -93,8 +95,12 @@ export default function BookmarkOptions({ bookmark }: { bookmark: ZBookmark }) {// Check if the current user owns this bookmarkconst isOwner = session?.user?.id === bookmark.userId;+ const enableBulkEditForBookmark = useBulkActionsStore(+ (state) => state.enableBulkEditForBookmark,+ );const [isClipboardAvailable, setIsClipboardAvailable] = useState(false);+ const [isTouchDevice, setIsTouchDevice] = useState(false);useEffect(() => {// This code only runs in the browser@@ -103,6 +109,16 @@ export default function BookmarkOptions({ bookmark }: { bookmark: ZBookmark }) {window.navigator &&!!window.navigator.clipboard,);++ const touchPointer = window.matchMedia("(any-pointer: coarse)");+ const updateIsTouchDevice = () => setIsTouchDevice(touchPointer.matches);++ updateIsTouchDevice();+ touchPointer.addEventListener("change", updateIsTouchDevice);++ return () => {+ touchPointer.removeEventListener("change", updateIsTouchDevice);+ };}, []);const { setOpen: setManageListsModalOpen, content: manageListsModal } =@@ -229,6 +245,14 @@ export default function BookmarkOptions({ bookmark }: { bookmark: ZBookmark }) {// Define action items arrayconst actionItems: ActionItemType[] = [+ {+ id: "select",+ title: t("actions.select"),+ icon: <Circle className="mr-2 size-4" />,+ visible: isOwner && isTouchDevice,+ disabled: false,+ onClick: () => enableBulkEditForBookmark(bookmark.id),+ },{id: "edit",title: t("actions.edit"),diff --git a/apps/web/lib/i18n/locales/en/translation.json b/apps/web/lib/i18n/locales/en/translation.jsonindex a4410498..860bc9f1 100644--- a/apps/web/lib/i18n/locales/en/translation.json+++ b/apps/web/lib/i18n/locales/en/translation.json@@ -81,6 +81,7 @@"edit_tags": "Edit Tags","edit_notes": "Edit Notes","add_to_list": "Add to List",+ "select": "Select","select_all": "Select All","unselect_all": "Unselect All","copy_link": "Copy Link",diff --git a/apps/web/lib/i18n/locales/en_US/translation.json b/apps/web/lib/i18n/locales/en_US/translation.jsonindex 31aeef2c..cec7ec7f 100644--- a/apps/web/lib/i18n/locales/en_US/translation.json+++ b/apps/web/lib/i18n/locales/en_US/translation.json@@ -71,6 +71,7 @@"preserve_as_pdf": "Preserve as PDF","edit_tags": "Edit Tags","add_to_list": "Add to List",+ "select": "Select","select_all": "Select All","unselect_all": "Unselect All","copy_link": "Copy Link",