Skip to content

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search

fix(search): respect negation on the age: qualifier (#3254)

Mohamed Bassemaabe09cee63c
diff --git a/packages/shared/searchQueryParser.test.ts b/packages/shared/searchQueryParser.test.ts
index a40b4187..1fe58435 100644
--- a/packages/shared/searchQueryParser.test.ts
+++ b/packages/shared/searchQueryParser.test.ts
@@ -659,6 +659,30 @@ describe("Search Query Parser", () => {
},
},
});
+ expect(parseSearchQuery("-age:<3d")).toEqual({
+ result: "full",
+ text: "",
+ matcher: {
+ type: "age",
+ relativeDate: {
+ direction: "older",
+ amount: 3,
+ unit: "day",
+ },
+ },
+ });
+ expect(parseSearchQuery("!age:>2y")).toEqual({
+ result: "full",
+ text: "",
+ matcher: {
+ type: "age",
+ relativeDate: {
+ direction: "newer",
+ amount: 2,
+ unit: "year",
+ },
+ },
+ });
});
test("complex queries", () => {
diff --git a/packages/shared/searchQueryParser.ts b/packages/shared/searchQueryParser.ts
index 15039898..8267937a 100644
--- a/packages/shared/searchQueryParser.ts
+++ b/packages/shared/searchQueryParser.ts
@@ -312,7 +312,17 @@ MATCHER.setPattern(
text: "",
matcher: {
type: "age",
- relativeDate: { direction, amount, unit },
+ relativeDate: {
+ // "newer" (>=) and "older" (<) are exact complements, so
+ // negating the qualifier is the same as flipping it.
+ direction: minus
+ ? direction === "newer"
+ ? "older"
+ : "newer"
+ : direction,
+ amount,
+ unit,
+ },
},
};
} catch {