A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search
feat(extension): add manual save toggle for browser extension (#2693)
Morgan Keslerc3975018b5ef
diff --git a/apps/browser-extension/src/OptionsPage.tsx b/apps/browser-extension/src/OptionsPage.tsxindex 1b1dc8b6..f0f4f4e2 100644--- a/apps/browser-extension/src/OptionsPage.tsx+++ b/apps/browser-extension/src/OptionsPage.tsx@@ -121,6 +121,19 @@ export default function OptionsPage() {</>)}<hr />+ <div className="flex items-center justify-between gap-2">+ <span className="text-sm font-medium">Auto-save on open</span>+ <Switch+ checked={settings.autoSave}+ onCheckedChange={(checked) =>+ setSettings((s) => ({ ...s, autoSave: checked }))+ }+ />+ </div>+ <p className="text-xs text-muted-foreground">+ When disabled, you'll confirm before saving bookmarks.+ </p>+ <hr /><div className="flex gap-2"><span className="my-auto">Server Address:</span>{settings.address}diff --git a/apps/browser-extension/src/SavePage.tsx b/apps/browser-extension/src/SavePage.tsxindex 4bbb82a8..df793456 100644--- a/apps/browser-extension/src/SavePage.tsx+++ b/apps/browser-extension/src/SavePage.tsx@@ -10,13 +10,21 @@ import {import { NEW_BOOKMARK_REQUEST_KEY_NAME } from "./background/protocol";import Spinner from "./Spinner";+import { Button } from "./components/ui/button";+import { Input } from "./components/ui/input";+import { Textarea } from "./components/ui/textarea";+import usePluginSettings from "./utils/settings";import { useTRPC } from "./utils/trpc";import { MessageType } from "./utils/type";import { isHttpUrl } from "./utils/url";export default function SavePage() {const api = useTRPC();+ const { settings, isPending: isSettingsLoaded } = usePluginSettings();const [error, setError] = useState<string | undefined>(undefined);+ const [pendingBookmark, setPendingBookmark] =+ useState<ZNewBookmarkRequest | null>(null);+ const [hasCheckedRequest, setHasCheckedRequest] = useState(false);const {data,@@ -45,6 +53,7 @@ export default function SavePage() {},}),);+useEffect(() => {async function getNewBookmarkRequestFromBackgroundScriptIfAny(): Promise<ZNewBookmarkRequest | null> {const { [NEW_BOOKMARK_REQUEST_KEY_NAME]: req } =@@ -57,7 +66,7 @@ export default function SavePage() {return zNewBookmarkRequestSchema.parse(req);}- async function runSave() {+ async function loadBookmarkRequest() {let newBookmarkRequest =await getNewBookmarkRequestFromBackgroundScriptIfAny();if (!newBookmarkRequest) {@@ -67,6 +76,7 @@ export default function SavePage() {});if (!currentTab.url) {setError("Current tab has no URL to bookmark.");+ setHasCheckedRequest(true);return;}@@ -74,6 +84,7 @@ export default function SavePage() {setError("Cannot bookmark this type of URL. Only HTTP/HTTPS URLs are supported.",);+ setHasCheckedRequest(true);return;}@@ -85,14 +96,43 @@ export default function SavePage() {};}+ setPendingBookmark(newBookmarkRequest);+ setHasCheckedRequest(true);+ }++ if (!isSettingsLoaded) return;+ loadBookmarkRequest();+ }, [isSettingsLoaded]);++ // Auto-save when settings are loaded and we have a pending bookmark+ useEffect(() => {+ if (+ hasCheckedRequest &&+ pendingBookmark &&+ settings.autoSave &&+ status === "idle"+ ) {createBookmark({- ...newBookmarkRequest,- source: newBookmarkRequest.source || "extension",+ ...pendingBookmark,+ source: pendingBookmark.source || "extension",});}+ }, [+ hasCheckedRequest,+ pendingBookmark,+ settings.autoSave,+ status,+ createBookmark,+ ]);- runSave();- }, [createBookmark]);+ const handleManualSave = () => {+ if (pendingBookmark) {+ createBookmark({+ ...pendingBookmark,+ source: pendingBookmark.source || "extension",+ });+ }+ };if (error) {return <div className="text-red-500">{error}</div>;@@ -114,7 +154,80 @@ export default function SavePage() {);}case "idle": {- return <div />;+ // Show confirmation UI when autoSave is disabled+ if (!settings.autoSave && pendingBookmark && hasCheckedRequest) {+ return (+ <div className="flex flex-col gap-3">+ <p className="text-lg font-medium">Save Bookmark?</p>+ {pendingBookmark.type === BookmarkTypes.LINK && (+ <div className="flex flex-col gap-2">+ <label className="text-xs font-medium text-muted-foreground">+ Title+ </label>+ <Input+ value={pendingBookmark.title ?? ""}+ onChange={(e) =>+ setPendingBookmark((prev) =>+ prev ? { ...prev, title: e.target.value } : prev,+ )+ }+ placeholder="Untitled"+ />+ <p className="truncate text-xs text-muted-foreground">+ {pendingBookmark.url}+ </p>+ </div>+ )}+ {pendingBookmark.type === BookmarkTypes.TEXT && (+ <p className="text-xs text-muted-foreground">+ {pendingBookmark.text.length > 150+ ? `${pendingBookmark.text.substring(0, 150)}...`+ : pendingBookmark.text}+ </p>+ )}+ {pendingBookmark.type === BookmarkTypes.ASSET && (+ <div className="flex flex-col gap-2">+ <label className="text-xs font-medium text-muted-foreground">+ Title+ </label>+ <Input+ value={pendingBookmark.title ?? ""}+ onChange={(e) =>+ setPendingBookmark((prev) =>+ prev ? { ...prev, title: e.target.value } : prev,+ )+ }+ placeholder={pendingBookmark.fileName ?? "Asset"}+ />+ </div>+ )}+ <div className="flex flex-col gap-2">+ <label className="text-xs font-medium text-muted-foreground">+ Notes+ </label>+ <Textarea+ value={pendingBookmark.note ?? ""}+ onChange={(e) =>+ setPendingBookmark((prev) =>+ prev ? { ...prev, note: e.target.value } : prev,+ )+ }+ placeholder="Add notes..."+ className="h-20 resize-none"+ />+ </div>+ <Button onClick={handleManualSave} className="w-full">+ Save Bookmark+ </Button>+ </div>+ );+ }+ return (+ <div className="flex justify-between text-lg">+ <span>Saving Bookmark </span>+ <Spinner />+ </div>+ );}}}diff --git a/apps/browser-extension/src/utils/settings.ts b/apps/browser-extension/src/utils/settings.tsindex 463efd2b..ef947b66 100644--- a/apps/browser-extension/src/utils/settings.ts+++ b/apps/browser-extension/src/utils/settings.ts@@ -13,6 +13,7 @@ const zSettingsSchema = z.object({useBadgeCache: z.boolean().default(true),badgeCacheExpireMs: z.number().min(0).default(DEFAULT_BADGE_CACHE_EXPIRE_MS),customHeaders: z.record(z.string(), z.string()).optional().default({}),+ autoSave: z.boolean().default(true),});const DEFAULT_SETTINGS: Settings = {@@ -23,6 +24,7 @@ const DEFAULT_SETTINGS: Settings = {useBadgeCache: true,badgeCacheExpireMs: DEFAULT_BADGE_CACHE_EXPIRE_MS,customHeaders: {},+ autoSave: true,};export type Settings = z.infer<typeof zSettingsSchema>;