Skip to content

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search

fix(ux): hide autocomplete dropdown when there are no suggestions

Claudec6417d8ec852
diff --git a/apps/web/components/dashboard/search/SearchInput.tsx b/apps/web/components/dashboard/search/SearchInput.tsx
index 644468e8..034b3bf7 100644
--- a/apps/web/components/dashboard/search/SearchInput.tsx
+++ b/apps/web/components/dashboard/search/SearchInput.tsx
@@ -11,7 +11,6 @@ import Link from "next/link";
import { Button } from "@/components/ui/button";
import {
Command,
- CommandEmpty,
CommandGroup,
CommandInput,
CommandItem,
@@ -225,7 +224,6 @@ const SearchInput = React.forwardRef<
onCloseAutoFocus={(e) => e.preventDefault()}
>
<CommandList className="max-h-96 overflow-y-auto">
- <CommandEmpty>{t("search.no_suggestions")}</CommandEmpty>
{hasSuggestions && <CommandItem value="-" className="hidden" />}
{suggestionGroups.map((group) => (
<CommandGroup key={group.id} heading={group.label}>
diff --git a/apps/web/components/dashboard/search/useSearchAutocomplete.ts b/apps/web/components/dashboard/search/useSearchAutocomplete.ts
index c72f4fc5..8afc50e4 100644
--- a/apps/web/components/dashboard/search/useSearchAutocomplete.ts
+++ b/apps/web/components/dashboard/search/useSearchAutocomplete.ts
@@ -510,7 +510,7 @@ export const useSearchAutocomplete = ({
const feedSuggestions = useFeedSuggestions(parsedState);
const sourceSuggestions = useSourceSuggestions(parsedState);
const historyItems = useHistorySuggestions(value, history);
- const { activeToken, getActiveToken } = parsedState;
+ const { getActiveToken } = parsedState;
const suggestionGroups = useMemo<SuggestionGroup[]>(() => {
const groups: SuggestionGroup[] = [];
@@ -576,9 +576,7 @@ export const useSearchAutocomplete = ({
]);
const hasSuggestions = suggestionGroups.length > 0;
- const showEmptyState =
- isPopoverOpen && !hasSuggestions && activeToken.length > 0;
- const isPopoverVisible = isPopoverOpen && (hasSuggestions || showEmptyState);
+ const isPopoverVisible = isPopoverOpen && hasSuggestions;
const handleSuggestionSelect = useCallback(
(item: AutocompleteSuggestionItem) => {
@@ -640,7 +638,6 @@ export const useSearchAutocomplete = ({
return {
suggestionGroups,
hasSuggestions,
- showEmptyState,
isPopoverVisible,
handleSuggestionSelect,
handleCommandKeyDown,