Skip to content

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search

fix(api): fix asset upload potential collision

Mohamed Bassemc865bdca3a53
diff --git a/packages/api/utils/upload.ts b/packages/api/utils/upload.ts
index b82bc855..a7ebe92c 100644
--- a/packages/api/utils/upload.ts
+++ b/packages/api/utils/upload.ts
@@ -95,7 +95,8 @@ export async function uploadAsset(
let tempFilePath: string | undefined;
try {
- tempFilePath = path.join(os.tmpdir(), `karakeep-upload-${Date.now()}`);
+ const assetId = newAssetId();
+ tempFilePath = path.join(os.tmpdir(), `karakeep-upload-${assetId}`);
await pipeline(
webStreamToNode(data.stream()),
fs.createWriteStream(tempFilePath),
@@ -103,7 +104,7 @@ export async function uploadAsset(
const [assetDb] = await db
.insert(assets)
.values({
- id: newAssetId(),
+ id: assetId,
// Initially, uploads are uploaded for unknown purpose
// And without an attached bookmark.
assetType: AssetTypes.UNKNOWN,