Skip to content

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search

deps: harden installs against package takeovers (#3264)

Mohamed Bassemdff8564d4d85
diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml
index 6bd75064..abebb8c6 100644
--- a/.github/workflows/cli.yml
+++ b/.github/workflows/cli.yml
@@ -30,10 +30,6 @@ jobs:
run: pnpm build
working-directory: apps/cli
- # npm 11.5.1 or later is required for trusted publishing
- - name: Upgrade npm
- run: npm install -g npm@latest
-
- name: Publish stable release
if: github.event_name == 'push'
run: pnpm publish --access public --no-git-checks
diff --git a/.github/workflows/mcp.yml b/.github/workflows/mcp.yml
index a7a81fbc..2c1ec017 100644
--- a/.github/workflows/mcp.yml
+++ b/.github/workflows/mcp.yml
@@ -24,8 +24,5 @@ jobs:
run: pnpm build
working-directory: apps/mcp
- # npm 11.5.1 or later is required for trusted publishing
- - run: npm install -g npm@latest
-
- run: pnpm publish --access public --no-git-checks
working-directory: apps/mcp
diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml
index 06f46b86..4b41d75b 100644
--- a/.github/workflows/sdk.yml
+++ b/.github/workflows/sdk.yml
@@ -24,8 +24,5 @@ jobs:
run: pnpm build
working-directory: packages/sdk
- # npm 11.5.1 or later is required for trusted publishing
- - run: npm install -g npm@latest
-
- run: pnpm publish --access public --no-git-checks
working-directory: packages/sdk
diff --git a/docker/Dockerfile b/docker/Dockerfile
index c3c4c3b6..fb24418b 100644
--- a/docker/Dockerfile
+++ b/docker/Dockerfile
@@ -16,7 +16,8 @@ ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
# Keep Corepack current enough to verify modern pnpm release signatures.
-RUN npm install -g corepack@latest && corepack enable pnpm
+# Pinned so the build doesn't pick up whatever corepack was published last.
+RUN npm install -g [email protected] && corepack enable pnpm
RUN apt-get update \
&& apt-get install --no-install-recommends -y \
diff --git a/karakeep-linux.sh b/karakeep-linux.sh
index 5a00c840..d51c0e79 100644
--- a/karakeep-linux.sh
+++ b/karakeep-linux.sh
@@ -210,7 +210,7 @@ install_karakeep() {
$shh apt-get update
$shh apt-get install -y nodejs
# https://github.com/karakeep-app/karakeep/issues/967
- $shh npm install -g corepack@latest
+ $shh npm install -g [email protected]
msg_done "Installed Node.js"
msg_start "Installing $(app)${CYAN}, please wait...${CLR}"
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
index a10d90c1..9a5cd627 100644
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -7,6 +7,28 @@ packages:
nodeLinker: hoisted
+# Refuse to install a version whose publish trust (trusted publisher or
+# provenance) is weaker than an earlier version of the same package, which is
+# what a takeover with a stolen publish token looks like.
+trustPolicy: no-downgrade
+# Exact versions only, so later releases of these packages are still checked.
+# Each was hand-published by the package's long-time maintainer (without CI
+# provenance) after other releases had started shipping with it. Review the
+# publisher and release history on npm before adding an entry here.
+trustPolicyExclude:
+ # paulmillr, after 3.6.0 shipped with provenance.
+ # lukastaegert, a 2.x backport after 4.x moved to trusted publishing.
+ # lukekarrys (npm team), a 6.x backport after 7.5.1 shipped with provenance.
+ # faisalman (the author), 1.x maintenance after 2.0 prereleases had provenance.
+# Only direct dependencies may come from git repos or tarball URLs. This is
+# already pnpm 11's default; it's set explicitly so a future default change
+# can't silently turn it off.
+blockExoticSubdeps: true
+
allowBuilds:
"@sentry/cli": true
"@swc/core": true
diff --git a/tooling/github/setup/action.yml b/tooling/github/setup/action.yml
index 7681e8e0..f1d91e33 100644
--- a/tooling/github/setup/action.yml
+++ b/tooling/github/setup/action.yml
@@ -11,12 +11,6 @@ runs:
cache: "pnpm"
registry-url: https://registry.npmjs.org
- - shell: bash
- run: pnpm add -g turbo
-
- - shell: bash
- run: npm install -g corepack@latest && corepack enable pnpm
-
- shell: bash
run: pnpm install
env: