A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search
fix: redact search params from browser url. fixes #2419
Mohamed Bassemf4a39230192b
diff --git a/apps/workers/workers/crawlerWorker.ts b/apps/workers/workers/crawlerWorker.tsindex f6f2af83..eed5af35 100644--- a/apps/workers/workers/crawlerWorker.ts+++ b/apps/workers/workers/crawlerWorker.ts@@ -117,6 +117,24 @@ function abortPromise(signal: AbortSignal): Promise<never> {return p;}+/**+ * Redact sensitive query parameters (e.g., tokens) from a URL for safe logging.+ */+function redactUrlCredentials(url: string): string {+ try {+ const parsed = new URL(url);+ for (const key of parsed.searchParams.keys()) {+ parsed.searchParams.set(key, "REDACTED");+ }+ if (parsed.password) {+ parsed.password = "REDACTED";+ }+ return parsed.toString();+ } catch {+ return url;+ }+}+/*** Normalize a Content-Type header by stripping parameters (e.g., charset)* and lowercasing the media type, so comparisons against supported types work.@@ -266,7 +284,7 @@ function startContextReaper() {async function startBrowserInstance() {if (serverConfig.crawler.browserWebSocketUrl) {logger.info(- `[Crawler] Connecting to existing browser websocket address: ${serverConfig.crawler.browserWebSocketUrl}`,+ `[Crawler] Connecting to existing browser websocket address: ${redactUrlCredentials(serverConfig.crawler.browserWebSocketUrl)}`,);return await chromium.connect(serverConfig.crawler.browserWebSocketUrl, {// Important: using slowMo to ensure stability with remote browser@@ -275,14 +293,14 @@ async function startBrowserInstance() {});} else if (serverConfig.crawler.browserWebUrl) {logger.info(- `[Crawler] Connecting to existing browser instance: ${serverConfig.crawler.browserWebUrl}`,+ `[Crawler] Connecting to existing browser instance: ${redactUrlCredentials(serverConfig.crawler.browserWebUrl)}`,);const webUrl = new URL(serverConfig.crawler.browserWebUrl);const { address } = await dns.promises.lookup(webUrl.hostname);webUrl.hostname = address;logger.info(- `[Crawler] Successfully resolved IP address, new address: ${webUrl.toString()}`,+ `[Crawler] Successfully resolved IP address, new address: ${redactUrlCredentials(webUrl.toString())}`,);return await chromium.connectOverCDP(webUrl.toString(), {