Skip to content

A self-hostable bookmark-everything app (links, notes and images) with AI-based automatic tagging and full text search

fix: ratelimit password login attempts

Mohamed Bassemf7d042971d0d
diff --git a/apps/web/server/auth.ts b/apps/web/server/auth.ts
index 2097058e..63a8ae06 100644
--- a/apps/web/server/auth.ts
+++ b/apps/web/server/auth.ts
@@ -9,6 +9,7 @@ import NextAuth, {
import { Adapter as NextAuthAdapater } from "next-auth/adapters";
import CredentialsProvider from "next-auth/providers/credentials";
import { Provider } from "next-auth/providers/index";
+import requestIp from "request-ip";
import { db } from "@karakeep/db";
import {
@@ -18,6 +19,7 @@ import {
verificationTokens,
} from "@karakeep/db/schema";
import serverConfig from "@karakeep/shared/config";
+import { getRateLimitClient } from "@karakeep/shared/ratelimiting";
import {
containsUnsafeUserNameMarkup,
normalizeUserNameInput,
@@ -119,11 +121,30 @@ const providers: Provider[] = [
email: { label: "Email", type: "email", placeholder: "Email" },
password: { label: "Password", type: "password" },
},
- async authorize(credentials) {
+ async authorize(credentials, req) {
if (!credentials) {
return null;
}
+ if (serverConfig.rateLimiting.enabled) {
+ const ip = requestIp.getClientIp({ headers: req?.headers ?? {} });
+ const client = ip ? await getRateLimitClient() : null;
+ if (client) {
+ const result = await client.checkRateLimit(
+ { name: "auth.login", windowMs: 15 * 60 * 1000, maxRequests: 10 },
+ `login:${ip}:${credentials.email.toLowerCase()}`,
+ );
+ if (!result.allowed) {
+ logEvent({
+ "event.name": "user.login_failed",
+ "user.email": credentials.email,
+ "auth.failure_reason": "rate_limited",
+ });
+ throw new Error("Too many login attempts. Please try again later.");
+ }
+ }
+ }
+
try {
return await validatePassword(
credentials?.email,