Skip to content

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

fix(h3): fix fixed height option (#3776)

Igor Dykhta14482223128c
diff --git a/src/components/src/side-panel/layer-panel/layer-configurator.tsx b/src/components/src/side-panel/layer-panel/layer-configurator.tsx
index ec7a2c3d9..4970da8aa 100644
--- a/src/components/src/side-panel/layer-panel/layer-configurator.tsx
+++ b/src/components/src/side-panel/layer-panel/layer-configurator.tsx
@@ -888,6 +888,7 @@ export default function LayerConfiguratorFactory(
{...layer.visConfigSettings.sizeRange}
{...visConfiguratorProps}
label="layerVisConfigs.heightRange"
+ disabled={layer.config.visConfig.fixedHeight}
/>
<VisConfigSwitch {...layer.visConfigSettings.fixedHeight} {...visConfiguratorProps} />
</ConfigGroupCollapsibleContent>
diff --git a/src/layers/src/h3-hexagon-layer/h3-hexagon-layer.ts b/src/layers/src/h3-hexagon-layer/h3-hexagon-layer.ts
index 8a3e127e3..bbfcab184 100644
--- a/src/layers/src/h3-hexagon-layer/h3-hexagon-layer.ts
+++ b/src/layers/src/h3-hexagon-layer/h3-hexagon-layer.ts
@@ -58,6 +58,7 @@ export type HexagonIdLayerVisConfigSettings = {
coverageRange: VisConfigRange;
elevationScale: VisConfigNumber;
enableElevationZoomFactor: VisConfigBoolean;
+ fixedHeight: VisConfigBoolean;
filled: VisConfigBoolean;
outline: VisConfigBoolean;
thickness: VisConfigNumber;
@@ -73,6 +74,7 @@ export type HexagonIdLayerVisConfig = {
coverageRange: [number, number];
elevationScale: number;
enableElevationZoomFactor: boolean;
+ fixedHeight: boolean;
filled: boolean;
outline: boolean;
thickness: number;
@@ -222,6 +224,7 @@ export default class HexagonIdLayer extends Layer {
size: {
...visualChannels.size,
property: 'height',
+ fixed: 'fixedHeight',
accessor: 'getElevation',
nullValue: 0,
condition: config => config.visConfig.enable3d,
diff --git a/test/browser/layer-tests/h3-hexagon-layer-specs.js b/test/browser/layer-tests/h3-hexagon-layer-specs.js
index acb95236f..41f27bd14 100644
--- a/test/browser/layer-tests/h3-hexagon-layer-specs.js
+++ b/test/browser/layer-tests/h3-hexagon-layer-specs.js
@@ -211,6 +211,42 @@ test('#H3Layer -> formatLayerData', t => {
'getFilterValue should return [value, 0, 0, 0]'
);
}
+ },
+ {
+ name: 'H3 layer format data. with sizeField and fixedHeight',
+ layer: {
+ config: {
+ dataId,
+ label: 'h3.3',
+ columns,
+ color: [10, 10, 10],
+ sizeField: {
+ type: 'real',
+ name: 'trip_distance'
+ },
+ visConfig: {
+ enable3d: true,
+ fixedHeight: true
+ }
+ },
+ type: 'hexagonId',
+ id: 'test_layer_3'
+ },
+ datasets: {
+ [dataId]: copyTableAndUpdate(preparedDataset, {filteredIndex})
+ },
+ assert: result => {
+ const {layerData} = result;
+
+ // getElevation with fixedHeight uses column values directly (identity scale)
+ // domain: [1.59, 11]
+ // value [1.59, 2.37]
+ t.deepEqual(
+ layerData.data.map(layerData.getElevation),
+ [1.59, 2.37],
+ 'getElevation should use column values when fixedHeight is enabled'
+ );
+ }
}
];