Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.
[Enhancement] treat type-analyzer type: NUMBER as strings (#891)
Joe LaBarbera1b091b552a2c
diff --git a/package.json b/package.jsonindex 012f2c689..5017fece9 100644--- a/package.json+++ b/package.json@@ -121,7 +121,7 @@"redux-actions": "^2.2.1","reselect": "^3.0.1","supercluster": "^6.0.1",- "type-analyzer": "0.2.3",+ "type-analyzer": "0.2.4","uber-licence": "^3.1.1","viewport-mercator-project": "^6.0.0","wellknown": "^0.5.0"diff --git a/src/processors/data-processor.js b/src/processors/data-processor.jsindex 93c095032..3ad0d4924 100644--- a/src/processors/data-processor.js+++ b/src/processors/data-processor.js@@ -361,7 +361,6 @@ export function analyzerTypeToFieldType(aType) {case TIME:case DATETIME:return ALL_FIELD_TYPES.timestamp;- case NUMBER:case FLOAT:return ALL_FIELD_TYPES.real;case INT:@@ -375,6 +374,7 @@ export function analyzerTypeToFieldType(aType) {case OBJECT:// TODO: create a new data type for objects and arraysreturn ALL_FIELD_TYPES.geojson;+ case NUMBER:case STRING:case ZIPCODE:return ALL_FIELD_TYPES.string;diff --git a/test/fixtures/state-saved-v1-2.js b/test/fixtures/state-saved-v1-2.jsindex 311151a75..81a8ca5a5 100644--- a/test/fixtures/state-saved-v1-2.js+++ b/test/fixtures/state-saved-v1-2.js@@ -5044,7 +5044,7 @@ export const v1expectedFields_2 = [{name: 'Longitude', type: 'real', format: '', analyzerType: 'FLOAT'},{name: 'at_Latitude', type: 'real', format: '', analyzerType: 'FLOAT'},{name: 'at_Longitude', type: 'real', format: '', analyzerType: 'FLOAT'},- {name: 'metric', type: 'real', format: '', analyzerType: 'NUMBER'},+ {name: 'metric', type: 'string', format: '', analyzerType: 'NUMBER'},{name: 'epoch', type: 'timestamp', format: 'x', analyzerType: 'TIME'},{name: 'epoch_ms', type: 'timestamp', format: 'X', analyzerType: 'TIME'},{name: 'meta_data', type: 'integer', format: '', analyzerType: 'INT'},diff --git a/test/node/schemas/dataset-schema-test.js b/test/node/schemas/dataset-schema-test.jsindex 078f16c05..ba9d5aab7 100644--- a/test/node/schemas/dataset-schema-test.js+++ b/test/node/schemas/dataset-schema-test.js@@ -86,7 +86,7 @@ test('#DatasetSchema -> SchemaManager.parseSavedData', t => {t.deepEqual(parsedValid[0].data.rows,expectedRows0,- 'should parse fields correctly'+ 'should parse rows correctly');t.deepEqual(@@ -107,7 +107,7 @@ test('#DatasetSchema -> SchemaManager.parseSavedData', t => {t.deepEqual(parsedValid[1].data.rows,expectedRows1,- 'should parse fields correctly'+ 'should parse rows correctly');t.end();@@ -144,7 +144,7 @@ test('#DatasetSchema -> SchemaManager.parseSavedData.v1', t => {t.deepEqual(parsedValid[0].data.rows,expectedRows,- 'should parse fields correctly'+ 'should parse rows correctly');t.end();@@ -179,7 +179,7 @@ test('#DatasetSchema -> SchemaManager.parseSavedData.v1 with ts', t => {t.deepEqual(parsedValid[0].data.rows,expectedRows,- 'should parse fields correctly'+ 'should parse rows correctly');t.end();diff --git a/test/node/utils/data-processor-test.js b/test/node/utils/data-processor-test.jsindex bee257fd1..2be3fc252 100644--- a/test/node/utils/data-processor-test.js+++ b/test/node/utils/data-processor-test.js@@ -607,10 +607,11 @@ test('Processor -> formatCsv', t => {const cases = [{- input: `gps_data.lat,gps_data.types,epoch,has_result,id,begintrip_ts_local,date- 29.9900937,driver_analytics,1472688000000,False,1,2016-10-01 09:41:39+00:00,2016-09-23- 29.9927699,driver_analytics,1472688000000,False,2,2016-10-01 16:46:37+00:00,2016-09-23- 29.9907261,driver_analytics,1472688000000,False,3,,2016-09-23`,+ input:+ `gps_data.lat,gps_data.types,epoch,has_result,id,begintrip_ts_local,date\n` ++ `29.9900937,driver_analytics,1472688000000,False,1,2016-10-01 09:41:39+00:00,2016-09-23\n` ++ `29.9927699,driver_analytics,1472688000000,False,2,2016-10-01 16:46:37+00:00,2016-09-23\n` ++ `29.9907261,driver_analytics,1472688000000,False,3,,2016-09-23`,expected:`gps_data.lat,gps_data.types,epoch,has_result,id,begintrip_ts_local,date\n` +`29.9900937,driver_analytics,1472688000000,false,1,2016-10-01 09:41:39+00:00,2016-09-23\n` +