Skip to content

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

[Enhancement] Replaced DI object storage with an actual Map

Giuseppe Macrì25f89a2c2c74
diff --git a/examples/demo-app/src/factories/save-map.js b/examples/demo-app/src/factories/save-map.js
index b02281552..79ab0ac1c 100644
--- a/examples/demo-app/src/factories/save-map.js
+++ b/examples/demo-app/src/factories/save-map.js
@@ -31,4 +31,4 @@ export const CustomSaveMapFactory = () => {
export function replaceSaveMap() {
return [SaveMapFactory, CustomSaveMapFactory]
-};
+}
diff --git a/src/components/injector.js b/src/components/injector.js
index a676c7013..e8d8dfcb7 100644
--- a/src/components/injector.js
+++ b/src/components/injector.js
@@ -32,10 +32,11 @@ export const errorMsg = {
notFunc: '`factory and its replacement should be a function`'
};
-export function injector(map = {}) {
- const cache = {}; // map<factory, factory -> ?>
+export function injector(map = new Map()) {
+ const cache = new Map(); // map<factory, factory -> ?>
const get = (fac, parent) => {
- const factory = map[fac];
+ const factory = map.get(fac);
+
// factory is not injected
if (!factory) {
Console.error(errorMsg.noDep(fac, parent));
@@ -43,12 +44,12 @@ export function injector(map = {}) {
}
const instances =
- cache[factory] ||
+ cache.get(factory) ||
factory(
...(factory.deps ? factory.deps.map(dep => get(dep, factory)) : [])
);
- cache[fac] = instances;
+ cache.set(fac, instances);
return instances;
};
@@ -66,7 +67,7 @@ export function injector(map = {}) {
return injector(map);
}
- return injector({...map, [factory]: replacement});
+ return injector((new Map(map)).set(factory, replacement));
},
get
};
diff --git a/src/components/modals/export-config-modal.js b/src/components/modals/export-config-modal.js
index 29ead553c..c56956b37 100644
--- a/src/components/modals/export-config-modal.js
+++ b/src/components/modals/export-config-modal.js
@@ -136,4 +136,5 @@ const ExportConfigModal = ({
ExportConfigModal.propTypes = propTypes;
const ExportConfigModalFactory = () => ExportConfigModal;
+
export default ExportConfigModalFactory;
diff --git a/src/components/modals/export-map-modal.js b/src/components/modals/export-map-modal.js
index 7ccc6ce5b..d869499c1 100644
--- a/src/components/modals/export-map-modal.js
+++ b/src/components/modals/export-map-modal.js
@@ -97,5 +97,6 @@ const ExportMapModal = ({
ExportMapModal.propTypes = propTypes;
-const exportMapModalFactory = () => ExportMapModal;
-export default exportMapModalFactory;
+const ExportMapModalFactory = () => ExportMapModal;
+
+export default ExportMapModalFactory;