Skip to content

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

fix: set aggregation layers min radius above 0 (#3669)

Igor Dykhta56ac6ff4b868
diff --git a/src/constants/src/layers.ts b/src/constants/src/layers.ts
index 70096efe1..e12057bb4 100644
--- a/src/constants/src/layers.ts
+++ b/src/constants/src/layers.ts
@@ -35,6 +35,8 @@ export const PROPERTY_GROUPS = keyMirror({
});
export const DEFAULT_LAYER_OPACITY = 0.8;
+/** Minimum grid / hexagon cell size in kilometers. Zero is invalid for aggregation. */
+export const MIN_WORLD_UNIT_SIZE = 0.001;
export const DEFAULT_HIGHLIGHT_COLOR: RGBAColor = [252, 242, 26, 255];
export const DEFAULT_LAYER_LABEL = 'new layer';
@@ -352,7 +354,7 @@ export const LAYER_VIS_CONFIGS: LayerVisConfigSettings = {
defaultValue: 1,
label: 'layerVisConfigs.worldUnitSize',
isRanged: false,
- range: [0, 500],
+ range: [MIN_WORLD_UNIT_SIZE, 500],
step: 0.0001,
group: PROPERTY_GROUPS.cell,
property: 'worldUnitSize',
@@ -473,7 +475,7 @@ export const LAYER_VIS_CONFIGS: LayerVisConfigSettings = {
defaultValue: 20,
label: 'layerVisConfigs.radius',
isRanged: false,
- range: [0, 100],
+ range: [0.1, 100],
step: 0.1,
group: PROPERTY_GROUPS.cell,
property: 'radius',
diff --git a/test/browser/layer-tests/grid-layer-specs.js b/test/browser/layer-tests/grid-layer-specs.js
index 0ff127489..1a0d0a4c9 100644
--- a/test/browser/layer-tests/grid-layer-specs.js
+++ b/test/browser/layer-tests/grid-layer-specs.js
@@ -123,6 +123,10 @@ test('#GridLayer -> constructor', t => {
t.ok(layer.isAggregated === true, 'gridLayer is aggregated');
t.ok(layer.config.label === 'test grid layer', 'label should be correct');
t.ok(Object.keys(layer.columnPairs).length, 'should have columnPairs');
+ t.ok(
+ layer.visConfigSettings.worldUnitSize.range[0] > 0,
+ 'grid size should have a positive minimum'
+ );
}
}
]
diff --git a/test/browser/layer-tests/heatmap-layer-specs.js b/test/browser/layer-tests/heatmap-layer-specs.js
index df0559aff..2689c4b02 100644
--- a/test/browser/layer-tests/heatmap-layer-specs.js
+++ b/test/browser/layer-tests/heatmap-layer-specs.js
@@ -35,6 +35,10 @@ test('#HeatmapLayer -> contructor', t => {
},
test: layer => {
t.equal(layer.config.visConfig.radius, 20, 'Heatmap default radius should be 20');
+ t.ok(
+ layer.visConfigSettings.radius.range[0] > 0,
+ 'heatmap radius should have a positive minimum'
+ );
t.ok(layer.config.dataId === 'taro', 'heatmaplayer dataId should be correct');
t.ok(layer.type === 'heatmap', 'type should be heatmap');
t.ok(layer.isAggregated === true, 'heatmaplayer is aggregated');
diff --git a/test/browser/layer-tests/hexagon-layer-specs.js b/test/browser/layer-tests/hexagon-layer-specs.js
index 3b93f9425..775f2c838 100644
--- a/test/browser/layer-tests/hexagon-layer-specs.js
+++ b/test/browser/layer-tests/hexagon-layer-specs.js
@@ -105,6 +105,10 @@ test('#HexagonLayer -> constructor', t => {
t.ok(layer.isAggregated === true, 'HexagonLayer is aggregated');
t.ok(layer.config.label === 'test hexagon layer', 'label should be correct');
t.ok(Object.keys(layer.columnPairs).length, 'should have columnPairs');
+ t.ok(
+ layer.visConfigSettings.worldUnitSize.range[0] > 0,
+ 'hexagon radius should have a positive minimum'
+ );
}
}
]