Skip to content

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

fix: respect split-map visibility in vector highlights (#3926)

Igor Dykhta9513327b5fac
diff --git a/src/layers/src/vector-tile/vector-tile-layer.ts b/src/layers/src/vector-tile/vector-tile-layer.ts
index 6309c4150..b9021b07c 100644
--- a/src/layers/src/vector-tile/vector-tile-layer.ts
+++ b/src/layers/src/vector-tile/vector-tile-layer.ts
@@ -724,7 +724,7 @@ export default class VectorTileLayer extends AbstractTileLayer<VectorTile, Featu
// @ts-expect-error props not typed?
...objectHovered.sourceLayer?.props,
...(this.getDefaultHoverLayerProps() as any),
- visible: true,
+ visible: defaultLayerProps.visible,
wrapLongitude: false,
data: [hoveredObject],
getLineColor: DEFAULT_HIGHLIGHT_STROKE_COLOR,
@@ -792,7 +792,7 @@ export default class VectorTileLayer extends AbstractTileLayer<VectorTile, Featu
return new GeoJsonLayer({
...(this.getDefaultHoverLayerProps() as any),
id: `${options.defaultLayerProps.id}-hover-outline-${tileId}`,
- visible: true,
+ visible: options.defaultLayerProps.visible,
wrapLongitude: false,
data: feats,
getLineColor: DEFAULT_HIGHLIGHT_STROKE_COLOR,
diff --git a/test/browser/layer-tests/vector-tile-layer-specs.js b/test/browser/layer-tests/vector-tile-layer-specs.js
index da70a255f..de5815b32 100644
--- a/test/browser/layer-tests/vector-tile-layer-specs.js
+++ b/test/browser/layer-tests/vector-tile-layer-specs.js
@@ -227,3 +227,57 @@ test('#VectorTileLayer -> radius range updates cached point attributes', t => {
}
t.end();
});
+
+test('#VectorTileLayer -> highlights respect current panel and layer visibility', t => {
+ for (const identified of [false, true]) {
+ const layer = new VectorTileLayer({id: 'vector', dataId: 'test'});
+ const feature = {
+ type: 'Feature',
+ ...(identified ? {id: 'selected'} : {}),
+ properties: {name: 'Selected'},
+ geometry: {type: 'Point', coordinates: [0, 0]}
+ };
+ const tile = {
+ id: '0-0-0',
+ index: {x: 0, y: 0, z: 0},
+ boundingBox: [
+ [-180, -85],
+ [180, 85]
+ ],
+ content: {shape: 'geojson-table', type: 'FeatureCollection', features: [feature]}
+ };
+ layer.tileDataset = {getTiles: () => [tile]};
+ const objectHovered = {
+ picked: true,
+ index: 0,
+ object: feature,
+ tile,
+ layer: {props: {id: layer.id}},
+ // Selection originated in the other, visible split-map panel.
+ sourceLayer: {props: {visible: true}}
+ };
+ for (const [visible, isVisible] of [
+ [true, true],
+ [false, true],
+ [true, false]
+ ]) {
+ layer.updateLayerConfig({isVisible});
+ const layers = layer.renderLayer({
+ data: {tileSource: {}, tilesetDataUrl: 'test/{z}/{x}/{y}'},
+ mapState: {zoom: 1, latitude: 0, longitude: 0},
+ animationConfig: {},
+ gpuFilter: {filterRange: [], filterValueAccessor: () => () => () => []},
+ layerCallbacks: {},
+ visible,
+ idx: 0,
+ objectHovered
+ });
+ const expected = visible && isVisible;
+ t.equal(layers.length, 2, `${identified ? 'outline' : 'fallback'} highlight is constructed`);
+ t.equal(layers[0].props.visible, expected, 'tile layer respects visibility');
+ t.equal(layers[1].props.visible, expected, 'highlight respects the current panel visibility');
+ t.deepEqual(layers[1].props.data, [feature], 'highlight keeps selected geometry');
+ }
+ }
+ t.end();
+});