Skip to content

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

fix(layers): stroke width slider sensitivity (#3812)

Igor Dykhta974f4273d102
diff --git a/src/constants/src/layers.ts b/src/constants/src/layers.ts
index 582594236..865f8ed13 100644
--- a/src/constants/src/layers.ts
+++ b/src/constants/src/layers.ts
@@ -100,7 +100,10 @@ export const LAYER_VIS_CONFIGS: LayerVisConfigSettings = {
label: 'layerVisConfigs.strokeWidth',
isRanged: false,
range: [0, 100],
- step: 0.1,
+ step: 0.01,
+ // 0–1 is the useful range for thin strokes; give it the first 20% of the track.
+ focusRange: [0, 1],
+ focusWeight: 0.2,
group: PROPERTY_GROUPS.stroke,
property: 'thickness',
allowCustomValue: true
diff --git a/src/layers/src/geojson-layer/geojson-layer.spec.ts b/src/layers/src/geojson-layer/geojson-layer.spec.ts
index 8dcfdc185..a4e7b14aa 100644
--- a/src/layers/src/geojson-layer/geojson-layer.spec.ts
+++ b/src/layers/src/geojson-layer/geojson-layer.spec.ts
@@ -2,6 +2,8 @@
// Copyright contributors to the kepler.gl project
import GeoJsonLayer, {getTextLabelPosition} from './geojson-layer';
+import {LAYER_VIS_CONFIGS} from '@kepler.gl/constants';
+import {valueToPosition} from '@kepler.gl/utils';
describe('GeoJsonLayer default deck parameters', () => {
const gpuFilter = null as any;
@@ -33,6 +35,28 @@ describe('GeoJsonLayer default deck parameters', () => {
});
});
+ test('stroke width gives 0–1 the first 20% of the slider at 0.01 steps', () => {
+ const thickness = LAYER_VIS_CONFIGS.thickness;
+ const scale = {focusRange: [0, 1] as [number, number], focusWeight: 0.2};
+ expect(thickness.step).toBe(0.01);
+ expect(thickness.range).toEqual([0, 100]);
+ expect(thickness.focusRange).toEqual(scale.focusRange);
+ expect(thickness.focusWeight).toBe(scale.focusWeight);
+
+ const [min, max] = thickness.range;
+ expect(valueToPosition(0, min, max, scale)).toBe(0);
+ expect(valueToPosition(1, min, max, scale)).toBeCloseTo(0.2);
+ expect(valueToPosition(0.5, min, max, scale)).toBeCloseTo(0.1);
+
+ const layer = new GeoJsonLayer({id: 'geojson_stroke'});
+ expect(layer.visConfigSettings.thickness).toMatchObject({
+ step: 0.01,
+ focusRange: [0, 1],
+ focusWeight: 0.2,
+ defaultValue: 0.5
+ });
+ });
+
test('defaults elevationOffset to 0 so existing maps stay on the ground', () => {
const layer = new GeoJsonLayer({id: 'geojson_offset'});
expect(layer.config.visConfig.elevationScale).toBe(1);
diff --git a/src/layers/src/geojson-layer/geojson-layer.ts b/src/layers/src/geojson-layer/geojson-layer.ts
index bd77e2d52..e9b01a8be 100644
--- a/src/layers/src/geojson-layer/geojson-layer.ts
+++ b/src/layers/src/geojson-layer/geojson-layer.ts
@@ -98,9 +98,7 @@ export const geojsonVisConfigs: {
},
thickness: {
...LAYER_VIS_CONFIGS.thickness,
- defaultValue: 0.5,
- focusRange: [0, 1],
- focusWeight: 0.3
+ defaultValue: 0.5
},
strokeColor: 'strokeColor',
colorRange: 'colorRange',
diff --git a/src/layers/src/trip-layer/trip-layer-color.spec.ts b/src/layers/src/trip-layer/trip-layer-color.spec.ts
index 8a966fced..bc4d9f125 100644
--- a/src/layers/src/trip-layer/trip-layer-color.spec.ts
+++ b/src/layers/src/trip-layer/trip-layer-color.spec.ts
@@ -79,6 +79,18 @@ function makeTripLayer(table: KeplerTable) {
return layer;
}
+describe('TripLayer stroke width slider', () => {
+ it('maps 0–1 onto the first 20% of the track at 0.01 steps', () => {
+ const layer = new TripLayer({id: 'trip_stroke'});
+ expect(layer.visConfigSettings.thickness).toMatchObject({
+ step: 0.01,
+ range: [0, 100],
+ focusRange: [0, 1],
+ focusWeight: 0.2
+ });
+ });
+});
+
describe('TripLayer TABLE mode color by field', () => {
it('getColor accessor maps each trip to its own company color', async () => {
const table = await makeTripTable();
diff --git a/src/layers/src/trip-layer/trip-layer.ts b/src/layers/src/trip-layer/trip-layer.ts
index 629c1cfc7..996a09d0c 100644
--- a/src/layers/src/trip-layer/trip-layer.ts
+++ b/src/layers/src/trip-layer/trip-layer.ts
@@ -163,7 +163,9 @@ export const tripVisConfigs: {
label: 'Stroke Width',
isRanged: false,
range: [0, 100],
- step: 0.1,
+ step: 0.01,
+ focusRange: [0, 1],
+ focusWeight: 0.2,
group: 'stroke',
property: 'thickness'
},