Skip to content

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

[bug] fix a bug where mapStyles is loaded as an empty object (#169)

Shan Heba035c44e76b
diff --git a/src/schemas/map-style-schema.js b/src/schemas/map-style-schema.js
index 5988f3817..55162f34e 100644
--- a/src/schemas/map-style-schema.js
+++ b/src/schemas/map-style-schema.js
@@ -52,7 +52,8 @@ class MapStyleSchemaV1 extends Schema {
}
load(mapStyles) {
- return {[this.key]: mapStyles}
+ // If mapStyle is an empty object, do not load it
+ return typeof mapStyles === 'object' && Object.keys(mapStyles).length ? {[this.key]: mapStyles} : {};
}
}
diff --git a/styles.js b/styles.js
index c004a444c..9be6229cb 100644
--- a/styles.js
+++ b/styles.js
@@ -18,4 +18,4 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
-module.exports = require('./dist/styles/base');
+module.exports = require('./dist/styles');
diff --git a/test/node/schemas/map-style-schema-test.js b/test/node/schemas/map-style-schema-test.js
index dfcb7c42a..1b1abe42b 100644
--- a/test/node/schemas/map-style-schema-test.js
+++ b/test/node/schemas/map-style-schema-test.js
@@ -42,8 +42,14 @@ test('#mapStyleSchema -> v1 -> save load mapStyle', t => {
mapStyles: {}
};
+ const expectedLoaded = {
+ styleType: 'dark',
+ topLayerGroups: {},
+ visibleLayerGroups: {}
+ }
+
t.deepEqual(msToSave, expectedSaved, 'saved mapStyle should be current');
- t.deepEqual(msLoaded, expectedSaved, 'loaded mapStyle should be current');
+ t.deepEqual(msLoaded, expectedLoaded, 'loaded mapStyle should be current');
t.end();
});