Skip to content

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

feat: add support to DECIMAL column type (#3341)

Xun Licc33b0c8fc4b
diff --git a/src/duckdb/src/table/duckdb-table-utils.ts b/src/duckdb/src/table/duckdb-table-utils.ts
index 5d46e800f..b6b4d8021 100644
--- a/src/duckdb/src/table/duckdb-table-utils.ts
+++ b/src/duckdb/src/table/duckdb-table-utils.ts
@@ -140,9 +140,13 @@ export function castDuckDBTypesForKepler(
return `ST_AsWKB(${quotedColumnName}) as ${quotedColumnName}`;
} else if (
options.bigIntToDouble &&
- (type === 'BIGINT' || type === 'UBIGINT' || type === 'HUGEINT' || type === 'UHUGEINT')
+ (type === 'BIGINT' ||
+ type === 'UBIGINT' ||
+ type === 'HUGEINT' ||
+ type === 'UHUGEINT' ||
+ type.startsWith('DECIMAL'))
) {
- // Cast 64-bit and larger integer types to DOUBLE to avoid BigInt in JS
+ // Cast 64-bit and larger integer types and DECIMAL to DOUBLE to avoid BigInt in JS
return `CAST(${quotedColumnName} AS DOUBLE) as ${quotedColumnName}`;
}
return quotedColumnName;
diff --git a/test/node/utils/duckdb-utils-test.js b/test/node/utils/duckdb-utils-test.js
index a59f62ec5..9924bc226 100644
--- a/test/node/utils/duckdb-utils-test.js
+++ b/test/node/utils/duckdb-utils-test.js
@@ -95,6 +95,24 @@ test('duckdb-utils -> castDuckDBTypesForKepler options', t => {
t.end();
});
+// Test castDuckDBTypesForKepler with DECIMAL types
+test('duckdb-utils -> castDuckDBTypesForKepler with DECIMAL', t => {
+ const tableName = 'test_table';
+ const columns = [
+ {name: 'id', type: 'INTEGER'},
+ {name: 'price', type: 'DECIMAL(18,2)'},
+ {name: 'amount', type: 'DECIMAL'},
+ {name: 'rate', type: 'DECIMAL(10,5)'}
+ ];
+
+ const result = castDuckDBTypesForKepler(tableName, columns);
+
+ const resultMock = `SELECT "id", CAST("price" AS DOUBLE) as "price", CAST("amount" AS DOUBLE) as "amount", CAST("rate" AS DOUBLE) as "rate" FROM "test_table"`;
+ t.equal(result, resultMock, 'should cast DECIMAL types to DOUBLE');
+
+ t.end();
+});
+
// Test castDuckDBTypesForKepler
test('duckdb-utils -> castDuckDBTypesForKepler with complex table name', t => {
const tableName = '"memory"."main"."earthquakes"';