Skip to content

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

fix: hide Kepler editor tooltip “top-left jump” on invalid hover coords (#3294)

bdjulbiccf76bba68e9c
diff --git a/src/components/src/map-container.tsx b/src/components/src/map-container.tsx
index 6177d0977..224df74ee 100644
--- a/src/components/src/map-container.tsx
+++ b/src/components/src/map-container.tsx
@@ -858,12 +858,19 @@ export default function MapContainerFactory(
getCursor?: ({isDragging}: {isDragging: boolean}) => string;
} = {};
if (primaryMap) {
- extraDeckParams.getTooltip = info =>
- EditorLayerUtils.getTooltip(info, {
+ // Omit hover updates when the pointer position is invalid, ie. over UI overlays or
+ // outside the map container. In those cases x/y may be < 0
+ extraDeckParams.getTooltip = info => {
+ const x = Number(info?.x);
+ const y = Number(info?.y);
+ if (Number.isNaN(x) || Number.isNaN(y) || x < 0 || y < 0) return null;
+
+ return EditorLayerUtils.getTooltip(info, {
editorMenuActive,
editor,
theme
});
+ };
extraDeckParams.getCursor = ({isDragging}: {isDragging: boolean}) => {
const editorCursor = EditorLayerUtils.getCursor({
diff --git a/test/browser-headless/component/map-container-test.js b/test/browser-headless/component/map-container-test.js
index 64601fb68..c23a00870 100644
--- a/test/browser-headless/component/map-container-test.js
+++ b/test/browser-headless/component/map-container-test.js
@@ -116,6 +116,13 @@ test('MapContainerFactory - _renderDeckOverlay', t => {
const divWrapper = instance._renderDeckOverlay(...args);
const DeckGl = divWrapper.props.children;
+ t.ok(typeof DeckGl.props.getTooltip === 'function', 'DeckGl should receive getTooltip prop');
+ t.equal(
+ DeckGl.props.getTooltip({x: -1, y: -1, pixel: [-1, -1]}),
+ null,
+ 'getTooltip should return null for invalid hover coordinates'
+ );
+
const clickEvents = [];
const hoverEvents = [];