Skip to content

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

[fix] Fixed crash when switching to dataset layer view mode (#2191)

Igor Dykhtae635e4cb7fd5
diff --git a/src/components/src/side-panel/layer-panel/layer-list.tsx b/src/components/src/side-panel/layer-panel/layer-list.tsx
index 85c986900..a3f723416 100644
--- a/src/components/src/side-panel/layer-panel/layer-list.tsx
+++ b/src/components/src/side-panel/layer-panel/layer-list.tsx
@@ -128,10 +128,15 @@ function LayerListFactory(LayerPanel: ReturnType<typeof LayerPanelFactory>) {
isSortable = true
} = props;
const {toggleModal: openModal} = uiStateActions;
- const sidePanelDndItems = useMemo(() => layerOrder.map(layerIdx => layers[layerIdx].id), [
- layers,
- layerOrder
- ]);
+ const layerOrdersToShow = useMemo(
+ () =>
+ layerOrder.filter(layerIdx => Boolean(layers[layerIdx]) && !layers[layerIdx].config.hidden),
+ [layers, layerOrder]
+ );
+
+ const sidePanelDndItems = useMemo(() => {
+ return layerOrdersToShow.map(layerIdx => layers[layerIdx].id);
+ }, [layerOrdersToShow, layers]);
const layerTypeOptions = useMemo(
() =>
@@ -170,27 +175,22 @@ function LayerListFactory(LayerPanel: ReturnType<typeof LayerPanelFactory>) {
<SortableList containerId="sortablelist" sidePanelDndItems={sidePanelDndItems}>
{/* warning: containerId should be similar to the first key in dndItems defined in kepler-gl.js*/}
- {sidePanelDndItems.map(
- (id, index) =>
- layers[layerOrder[index]] &&
- !layers[layerOrder[index]].config.hidden &&
- id && (
- <SortableItem
- key={id}
- layerId={id}
- panelProps={panelProps}
- layerActions={layerActions}
- layers={layers}
- layerIndex={layerOrder[index]}
- />
- )
- )}
+ {layerOrdersToShow.map(layerIdx => (
+ <SortableItem
+ key={layers[layerIdx].id}
+ layerId={layers[layerIdx].id}
+ panelProps={panelProps}
+ layerActions={layerActions}
+ layers={layers}
+ layerIndex={layerIdx}
+ />
+ ))}
</SortableList>
</>
) : (
<>
{layerOrder.map(
- (layerIdx, index) =>
+ layerIdx =>
layers[layerIdx] &&
!layers[layerIdx].config.hidden && (
<LayerPanel