Skip to content

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.

fix(sqlrooms): mark esm output as modules (#3841)

Igor Dykhtaf1a4b1bfcfe8
diff --git a/src/sqlrooms/package.json b/src/sqlrooms/package.json
index f92049b48..78104e9cf 100644
--- a/src/sqlrooms/package.json
+++ b/src/sqlrooms/package.json
@@ -15,7 +15,7 @@
"dist"
],
"scripts": {
- "build": "rm -fr dist && babel src --out-dir dist/cjs --source-maps inline --extensions '.ts,.tsx,.js,.jsx' --ignore '**/*.d.ts' && BABEL_ENV=esm babel src --out-dir dist/esm --source-maps inline --extensions '.ts,.tsx,.js,.jsx' --ignore '**/*.d.ts'",
+ "build": "rm -fr dist && babel src --out-dir dist/cjs --source-maps inline --extensions '.ts,.tsx,.js,.jsx' --ignore '**/*.d.ts' && BABEL_ENV=esm babel src --out-dir dist/esm --source-maps inline --extensions '.ts,.tsx,.js,.jsx' --ignore '**/*.d.ts' && echo '{\"type\":\"module\"}' > dist/esm/package.json",
"build:types": "tsc --project ./tsconfig.production.json",
"prepublishOnly": "babel-node ../../scripts/license-header/bin --license ../../FILE-HEADER && yarn build && yarn build:types",
"stab": "mkdir -p dist/cjs/config dist/esm/config && echo \"'use strict'; Object.assign(module.exports, require('../../src'));\" > dist/cjs/index.js && echo \"export * from '../../src';\" > dist/esm/index.js && echo \"'use strict'; Object.assign(module.exports, require('../../../src/config'));\" > dist/cjs/config/index.js && echo \"export * from '../../../src/config';\" > dist/esm/config/index.js",
diff --git a/src/sqlrooms/test/config.test.cjs b/src/sqlrooms/test/config.test.cjs
index c9c2d3f78..ffb1d4c36 100644
--- a/src/sqlrooms/test/config.test.cjs
+++ b/src/sqlrooms/test/config.test.cjs
@@ -2,10 +2,23 @@
// Copyright contributors to the kepler.gl project
const assert = require('node:assert/strict');
+const fs = require('node:fs');
+const path = require('node:path');
const {test} = require('node:test');
const {execFileSync} = require('node:child_process');
const {KeplerSliceConfig, migrateKeplerTabsToArtifacts} = require('@kepler.gl/sqlrooms/config');
+test('build marks the ESM subtree without changing the CommonJS package scope', () => {
+ const packageRoot = path.resolve(__dirname, '..');
+ const packageJson = JSON.parse(fs.readFileSync(path.join(packageRoot, 'package.json'), 'utf8'));
+ const esmPackageJson = JSON.parse(
+ fs.readFileSync(path.join(packageRoot, 'dist/esm/package.json'), 'utf8')
+ );
+
+ assert.equal(packageJson.type, undefined);
+ assert.deepEqual(esmPackageJson, {type: 'module'});
+});
+
test('config entry loads without the map or room runtime in CommonJS and ESM', () => {
execFileSync(
process.execPath,