Skip to content

armgit / kiln

Public Imported from GitHub
0

Build and revise procedural 3D assets with your coding agent. Local MCP server, CLI and TypeScript engine with rendered review, editable source and GLB export.

fix(renderer): refresh socket evidence after child exit

Matt Kissingerc47118a251a4
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6741383f..0623b456 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -26,6 +26,8 @@ does not publish a package.
- Retry transient Windows permission failures when publishing material revisions,
using the existing bounded atomic-directory helper. Existing revisions remain
immutable and are accepted only after full material verification.
+- Recheck renderer health after observing a child exit during concurrent startup,
+ so an earlier refused connection cannot hide another client's verified service.
## 1.2.3 (2026-10-12)
diff --git a/dist/build.json b/dist/build.json
index d2d1aad9..ddb4db87 100644
--- a/dist/build.json
+++ b/dist/build.json
@@ -2,10 +2,10 @@
"schemaVersion": 1,
"entries": {
"worker": {
- "identity": "sha256:77c1bbd1926fd994e0d670d05e16694963ab797e7e6cfcbf4a3edcf19e5215fa",
+ "identity": "sha256:8c6011a053d15863ced9171f045302f1df9656e66298aab07600e5abf5cb9b68",
"engineVersion": "1.3.0",
"toolchain": "[email protected]",
- "sourceHash": "3429366aef15fc207b42f1b2261f3d1d3af57b76e7163cec9a340d5d8ed53d35",
+ "sourceHash": "da55f9afb5a12898addb335ee7e8adbdd5236196c23fdae9f432693c2b1ea566",
"rendererSourceHash": "27927c48b377f7694251a76c0cecd05216fcbbb8a7d03e8bf2bd681dabb5573a",
"dependencyHash": "f17d705cc5de6856252c111542b8e179695cc81448eb1e2fc4d9a343ed42370a",
"dependencies": {
@@ -40,10 +40,10 @@
"bundleHash": "sha256:07c1b534e55c1b7fa3fb8136028209b5187fbc9b16810970ad76140ea436696e"
},
"agent-run": {
- "identity": "sha256:77c1bbd1926fd994e0d670d05e16694963ab797e7e6cfcbf4a3edcf19e5215fa",
+ "identity": "sha256:8c6011a053d15863ced9171f045302f1df9656e66298aab07600e5abf5cb9b68",
"engineVersion": "1.3.0",
"toolchain": "[email protected]",
- "sourceHash": "3429366aef15fc207b42f1b2261f3d1d3af57b76e7163cec9a340d5d8ed53d35",
+ "sourceHash": "da55f9afb5a12898addb335ee7e8adbdd5236196c23fdae9f432693c2b1ea566",
"rendererSourceHash": "27927c48b377f7694251a76c0cecd05216fcbbb8a7d03e8bf2bd681dabb5573a",
"dependencyHash": "f17d705cc5de6856252c111542b8e179695cc81448eb1e2fc4d9a343ed42370a",
"dependencies": {
@@ -78,10 +78,10 @@
"bundleHash": "sha256:05be3a3342f08b36b4412d7ddcb0c56ec2036100845dcad0b4840338885a0621"
},
"agent-providers": {
- "identity": "sha256:77c1bbd1926fd994e0d670d05e16694963ab797e7e6cfcbf4a3edcf19e5215fa",
+ "identity": "sha256:8c6011a053d15863ced9171f045302f1df9656e66298aab07600e5abf5cb9b68",
"engineVersion": "1.3.0",
"toolchain": "[email protected]",
- "sourceHash": "3429366aef15fc207b42f1b2261f3d1d3af57b76e7163cec9a340d5d8ed53d35",
+ "sourceHash": "da55f9afb5a12898addb335ee7e8adbdd5236196c23fdae9f432693c2b1ea566",
"rendererSourceHash": "27927c48b377f7694251a76c0cecd05216fcbbb8a7d03e8bf2bd681dabb5573a",
"dependencyHash": "f17d705cc5de6856252c111542b8e179695cc81448eb1e2fc4d9a343ed42370a",
"dependencies": {
@@ -116,10 +116,10 @@
"bundleHash": "sha256:9d6faf03d307321bc2e3bd5ce5bdee0bbbf61e0ebed8bfebfa1fb072287b83fa"
},
"mcp": {
- "identity": "sha256:77c1bbd1926fd994e0d670d05e16694963ab797e7e6cfcbf4a3edcf19e5215fa",
+ "identity": "sha256:8c6011a053d15863ced9171f045302f1df9656e66298aab07600e5abf5cb9b68",
"engineVersion": "1.3.0",
"toolchain": "[email protected]",
- "sourceHash": "3429366aef15fc207b42f1b2261f3d1d3af57b76e7163cec9a340d5d8ed53d35",
+ "sourceHash": "da55f9afb5a12898addb335ee7e8adbdd5236196c23fdae9f432693c2b1ea566",
"rendererSourceHash": "27927c48b377f7694251a76c0cecd05216fcbbb8a7d03e8bf2bd681dabb5573a",
"dependencyHash": "f17d705cc5de6856252c111542b8e179695cc81448eb1e2fc4d9a343ed42370a",
"dependencies": {
@@ -154,10 +154,10 @@
"bundleHash": "sha256:7488f7b83f132bf1de7a05a66d884e8ea08ab8e5accddcd1cbbad54b2e1a7ea6"
},
"cli": {
- "identity": "sha256:77c1bbd1926fd994e0d670d05e16694963ab797e7e6cfcbf4a3edcf19e5215fa",
+ "identity": "sha256:8c6011a053d15863ced9171f045302f1df9656e66298aab07600e5abf5cb9b68",
"engineVersion": "1.3.0",
"toolchain": "[email protected]",
- "sourceHash": "3429366aef15fc207b42f1b2261f3d1d3af57b76e7163cec9a340d5d8ed53d35",
+ "sourceHash": "da55f9afb5a12898addb335ee7e8adbdd5236196c23fdae9f432693c2b1ea566",
"rendererSourceHash": "27927c48b377f7694251a76c0cecd05216fcbbb8a7d03e8bf2bd681dabb5573a",
"dependencyHash": "f17d705cc5de6856252c111542b8e179695cc81448eb1e2fc4d9a343ed42370a",
"dependencies": {
@@ -189,13 +189,13 @@
},
"target": "node",
"file": "cli.mjs",
- "bundleHash": "sha256:5cdcc8724cc59b238d5a2bda29dcaae5711bd51b2f41683b06b6572933b300cc"
+ "bundleHash": "sha256:2301a0fe7b2ecb2bbc96d2adba2df8cbed07a751609741f549cbaa31f91d3d11"
},
"engine": {
- "identity": "sha256:77c1bbd1926fd994e0d670d05e16694963ab797e7e6cfcbf4a3edcf19e5215fa",
+ "identity": "sha256:8c6011a053d15863ced9171f045302f1df9656e66298aab07600e5abf5cb9b68",
"engineVersion": "1.3.0",
"toolchain": "[email protected]",
- "sourceHash": "3429366aef15fc207b42f1b2261f3d1d3af57b76e7163cec9a340d5d8ed53d35",
+ "sourceHash": "da55f9afb5a12898addb335ee7e8adbdd5236196c23fdae9f432693c2b1ea566",
"rendererSourceHash": "27927c48b377f7694251a76c0cecd05216fcbbb8a7d03e8bf2bd681dabb5573a",
"dependencyHash": "f17d705cc5de6856252c111542b8e179695cc81448eb1e2fc4d9a343ed42370a",
"dependencies": {
@@ -227,7 +227,7 @@
},
"target": "node",
"file": "mcp-engine.mjs",
- "bundleHash": "sha256:78eac9085eb4af560be414c37e500f7b72117520de83bd3c55b8f54d0c25098b"
+ "bundleHash": "sha256:723dcd58529e9856281adac58f70bc2f11ac298283092d7a7f2de617e8a3bd90"
}
}
}
diff --git a/dist/cli.mjs b/dist/cli.mjs
index 25958197..0f94459b 100644
--- a/dist/cli.mjs
+++ b/dist/cli.mjs
@@ -52275,13 +52275,13 @@ async function startLocalRenderService(dir = renderServiceDir(), environment = p
const deadline = Date.now() + budget;
try {
while (Date.now() < deadline) {
+ const exitedBeforeProbe = windowsLaunch ? windowsLaunch.hasExited() : running.exitCode !== null || running.signalCode !== null;
const fresh = await inspectLocalRenderService(url, dir, 1000);
if (fresh.kind === "service" && !fresh.stale)
return url;
if (fresh.kind === "service" || fresh.kind === "incompatible" || fresh.kind === "foreign")
throw new Error(describeUnavailableService(url, fresh));
- const exited = windowsLaunch ? windowsLaunch.hasExited() : running.exitCode !== null || running.signalCode !== null;
- if (spawnError || exited && fresh.kind === "absent")
+ if (spawnError || exitedBeforeProbe && fresh.kind === "absent")
throw new Error(`render service exited during startup${spawnError ? `: ${spawnError.message}` : ""}${stderr.trim() ? `: ${stderr.trim()}` : windowsLaunch ? "; launch the renderer manually to inspect native-driver errors" : ""}`);
await new Promise((done) => setTimeout(done, 250));
}
diff --git a/dist/mcp-engine.mjs b/dist/mcp-engine.mjs
index 8e5f3139..bdfdf0fa 100644
--- a/dist/mcp-engine.mjs
+++ b/dist/mcp-engine.mjs
@@ -40907,13 +40907,13 @@ async function startLocalRenderService(dir = renderServiceDir(), environment = p
const deadline = Date.now() + budget;
try {
while (Date.now() < deadline) {
+ const exitedBeforeProbe = windowsLaunch ? windowsLaunch.hasExited() : running.exitCode !== null || running.signalCode !== null;
const fresh = await inspectLocalRenderService(url, dir, 1000);
if (fresh.kind === "service" && !fresh.stale)
return url;
if (fresh.kind === "service" || fresh.kind === "incompatible" || fresh.kind === "foreign")
throw new Error(describeUnavailableService(url, fresh));
- const exited = windowsLaunch ? windowsLaunch.hasExited() : running.exitCode !== null || running.signalCode !== null;
- if (spawnError || exited && fresh.kind === "absent")
+ if (spawnError || exitedBeforeProbe && fresh.kind === "absent")
throw new Error(`render service exited during startup${spawnError ? `: ${spawnError.message}` : ""}${stderr.trim() ? `: ${stderr.trim()}` : windowsLaunch ? "; launch the renderer manually to inspect native-driver errors" : ""}`);
await new Promise((done) => setTimeout(done, 250));
}
diff --git a/src/__tests__/render-service-lifecycle.test.ts b/src/__tests__/render-service-lifecycle.test.ts
index 6b90f7f3..adae8d93 100644
--- a/src/__tests__/render-service-lifecycle.test.ts
+++ b/src/__tests__/render-service-lifecycle.test.ts
@@ -6,6 +6,7 @@ import { join, resolve } from 'node:path';
import { afterEach, expect, test } from 'bun:test';
import {
inspectLocalRenderService,
+ processIsAlive,
renderServiceSourceFingerprint,
startLocalRenderService,
terminateRenderService,
@@ -187,6 +188,101 @@ test.each([0, 4000])(
},
);
+test('a refusal observed before child exit cannot reject a compatible winner that is now listening', async () => {
+ const { dir, port, url } = await installation();
+ const journal = join(dir, 'delayed-probe-startup.jsonl');
+ const barrier = join(dir, 'release-delayed-probe');
+ const originalFetch = globalThis.fetch;
+ let healthCalls = 0;
+ let refusalCode: string | undefined;
+ let probeTimer: ReturnType<typeof setTimeout> | undefined;
+ let probeEntered!: () => void;
+ const entered = new Promise<void>((done) => {
+ probeEntered = done;
+ });
+ let releaseProbe!: () => void;
+ const released = new Promise<void>((done) => {
+ releaseProbe = done;
+ });
+ globalThis.fetch = (async (input, init) => {
+ const target = input instanceof Request ? input.url : String(input);
+ if (target !== `${url}/health` || ++healthCalls !== 2) return originalFetch(input, init);
+ // Capture a real refusal while the child is gated before listen, but delay
+ // delivering that old observation until its bind attempt has lost and exited.
+ try {
+ return await originalFetch(input, init);
+ } catch (error) {
+ const detail = error as { code?: string; cause?: { code?: string } };
+ refusalCode = detail.code ?? detail.cause?.code;
+ probeEntered();
+ await released;
+ throw error;
+ }
+ }) as typeof fetch;
+ const pending = startLocalRenderService(dir, {
+ ...process.env,
+ FAKE_STARTUP_JOURNAL: journal,
+ FAKE_STARTUP_BARRIER: barrier,
+ KILN_RENDER_SERVICE_STARTUP_MS: '15000',
+ });
+ void pending.catch(() => {});
+ const deadline = Date.now() + 10_000;
+ try {
+ await Promise.race([
+ entered,
+ new Promise((_, reject) => {
+ probeTimer = setTimeout(() => reject(new Error('startup probe not entered')), 10_000);
+ }),
+ ]);
+ clearTimeout(probeTimer);
+ expect(refusalCode ?? '').toMatch(/^(ECONNREFUSED|ConnectionRefused)$/);
+ let pid: number | undefined;
+ while (!pid && Date.now() < deadline) {
+ pid = await readFile(journal, 'utf8')
+ .then((text) => JSON.parse(text.trim()).pid)
+ .catch(() => undefined);
+ if (!pid) await new Promise((done) => setTimeout(done, 20));
+ }
+ if (!pid) throw new Error('owned child did not announce startup');
+ ownedPids.push(pid);
+ const base = fakeRenderHealth();
+ const health = fakeRenderHealth({
+ instance: {
+ ...base.instance,
+ sourceDir: dir,
+ sourceFingerprint: renderServiceSourceFingerprint(dir)!,
+ },
+ });
+ const winner = createServer((_request, response) => {
+ response.setHeader('content-type', 'application/json');
+ response.end(JSON.stringify(health));
+ });
+ servers.push(winner);
+ await new Promise<void>((done, reject) => {
+ winner.once('error', reject);
+ winner.listen(port, '127.0.0.1', done);
+ });
+ // The losing child now attempts this same occupied socket and really exits.
+ await writeFile(barrier, 'release');
+ while (processIsAlive(pid) && Date.now() < deadline)
+ await new Promise((done) => setTimeout(done, 20));
+ expect(processIsAlive(pid)).toBe(false);
+ expect(await inspectLocalRenderService(url, dir)).toMatchObject({
+ kind: 'service',
+ stale: false,
+ });
+ releaseProbe();
+ expect(await pending).toBe(url);
+ expect(healthCalls).toBeGreaterThanOrEqual(4);
+ } finally {
+ clearTimeout(probeTimer);
+ releaseProbe();
+ await writeFile(barrier, 'release');
+ globalThis.fetch = originalFetch;
+ await pending.catch(() => {});
+ }
+});
+
test('a renderer that exits before health is reported as startup failure', async () => {
const { dir } = await installation();
await writeFile(join(dir, 'src/server.mjs'), 'process.exit(9);');
diff --git a/src/render-service-host.ts b/src/render-service-host.ts
index fa89c89b..3440f5e8 100644
--- a/src/render-service-host.ts
+++ b/src/render-service-host.ts
@@ -250,17 +250,18 @@ export async function startLocalRenderService(
const deadline = Date.now() + budget;
try {
while (Date.now() < deadline) {
+ const exitedBeforeProbe = windowsLaunch
+ ? windowsLaunch.hasExited()
+ : running.exitCode !== null || running.signalCode !== null;
const fresh = await inspectLocalRenderService(url, dir, 1_000);
if (fresh.kind === 'service' && !fresh.stale) return url;
if (fresh.kind === 'service' || fresh.kind === 'incompatible' || fresh.kind === 'foreign')
throw new Error(describeUnavailableService(url, fresh));
- const exited = windowsLaunch
- ? windowsLaunch.hasExited()
- : running.exitCode !== null || running.signalCode !== null;
// A competing child can win the socket while this one exits after losing
// its bind. An unknown listener gets the same startup deadline as our child;
- // only verified health permits joining. An exited child with no listener fails.
- if (spawnError || (exited && fresh.kind === 'absent'))
+ // only verified health permits joining. A refusal observed before exit can
+ // already be stale, so require a probe begun after observing the child exit.
+ if (spawnError || (exitedBeforeProbe && fresh.kind === 'absent'))
throw new Error(
`render service exited during startup${spawnError ? `: ${spawnError.message}` : ''}${stderr.trim() ? `: ${stderr.trim()}` : windowsLaunch ? '; launch the renderer manually to inspect native-driver errors' : ''}`,
);