Skip to content

armgit / kong

Public Imported from GitHub
0

The world's first agentic reverse engineer.

feat: wire syntactic normalizer into analyzer pipeline

Amruthd72831f8222c
diff --git a/kong/agent/analyzer.py b/kong/agent/analyzer.py
index ed130da..a96433f 100644
--- a/kong/agent/analyzer.py
+++ b/kong/agent/analyzer.py
@@ -16,6 +16,7 @@ from kong.agent.models import FunctionResult
from kong.agent.queue import WorkItem
from kong.ghidra.client import GhidraClient
from kong.ghidra.types import BinaryInfo, FunctionInfo, StringEntry, StructDefinition
+from kong.normalizer.syntactic import normalize
if TYPE_CHECKING:
from kong.agent.deobfuscator import Deobfuscator
@@ -191,7 +192,7 @@ class Analyzer:
"""Assemble all context the LLM needs to analyze this function."""
func = item.function
- decompilation = self.client.get_decompilation(func.address)
+ decompilation = normalize(self.client.get_decompilation(func.address))
caller_snippets = self._get_caller_snippets(item.callers, known_results)
callee_snippets = self._get_callee_snippets(item.callees, known_results)
@@ -225,7 +226,7 @@ class Analyzer:
for addr in caller_addrs[:3]:
name = self._resolve_name(addr, known_results)
try:
- full = self.client.get_decompilation(addr)
+ full = normalize(self.client.get_decompilation(addr))
lines = full.split("\n")[:10]
snippet = "\n".join(lines)
except Exception:
@@ -244,7 +245,7 @@ class Analyzer:
for addr in callee_addrs[:5]:
name = self._resolve_name(addr, known_results)
try:
- full = self.client.get_decompilation(addr)
+ full = normalize(self.client.get_decompilation(addr))
lines = full.split("\n")[:10]
snippet = "\n".join(lines)
except Exception:
diff --git a/tests/test_agent_analyzer.py b/tests/test_agent_analyzer.py
index a26b38b..bdb8c05 100644
--- a/tests/test_agent_analyzer.py
+++ b/tests/test_agent_analyzer.py
@@ -294,3 +294,58 @@ class TestParseLLMJson:
raw = '{"name": "test"}'
resp = Analyzer.parse_llm_json(raw)
assert resp.raw == raw
+
+
+class TestNormalizerIntegration:
+ def test_decompilation_normalized_before_prompt(self):
+ """Decompilation artifacts (undefined4, + -) are cleaned before reaching the LLM."""
+ raw_decomp = (
+ "undefined4 counter;\n"
+ "for (counter = 0; counter < n; counter = counter + 1) {\n"
+ " x = x + -0x10;\n"
+ "}\n"
+ )
+ llm = _mock_llm(LLMResponse(name="f"))
+ client = _mock_client()
+ client.get_decompilation.return_value = raw_decomp
+
+ analyzer = Analyzer(client, llm)
+ analyzer.analyze(_item(), _binary_info(), {}, [])
+
+ prompt = llm.analyze_function.call_args[0][0]
+ assert "undefined4" not in prompt
+ assert "int counter" in prompt
+ assert "+ -" not in prompt
+ assert "- 0x10" in prompt
+
+ def test_caller_snippets_normalized(self):
+ raw_caller = "undefined4 i;\nfor (i = 0; i < n; i = i + 1) { x = x + -5; }\n"
+ llm = _mock_llm(LLMResponse(name="f"))
+ client = _mock_client()
+ client.get_decompilation.side_effect = lambda addr: (
+ raw_caller if addr == 0x3000 else "void target() { return; }"
+ )
+
+ item = _item(callers=[0x3000])
+ analyzer = Analyzer(client, llm)
+ ctx = analyzer._build_context(item, _binary_info(), {}, [])
+
+ assert len(ctx.caller_snippets) == 1
+ assert "undefined4" not in ctx.caller_snippets[0].snippet
+ assert "int i" in ctx.caller_snippets[0].snippet
+
+ def test_callee_snippets_normalized(self):
+ raw_callee = "undefined4 j;\nfor (j = 0; j < m; j = j + 1) { y = y + -3; }\n"
+ llm = _mock_llm(LLMResponse(name="f"))
+ client = _mock_client()
+ client.get_decompilation.side_effect = lambda addr: (
+ raw_callee if addr == 0x2000 else "void target() { callee(); }"
+ )
+
+ item = _item(callees=[0x2000])
+ analyzer = Analyzer(client, llm)
+ ctx = analyzer._build_context(item, _binary_info(), {}, [])
+
+ assert len(ctx.callee_snippets) == 1
+ assert "undefined4" not in ctx.callee_snippets[0].snippet
+ assert "- 3" in ctx.callee_snippets[0].snippet