Self-hosted project management for devs and their clients: tickets, time tracking, docs and meetings, with an AI assistant that cites its sources. AGPL-3.0.
Ruby agplai-assistantdockerdsgvogdprhotwireissue-trackerjira-alternativeknowledge-basellmmcp-servermeeting-notesopen-sourceproject-managementredmine-alternativeruby-on-railsself-hostedticketingtime-tracking
fix(meetings): show Korrigieren for a mark made before the page's scripts ran
Guido Boyke2d49eeaaabbf
diff --git a/app/javascript/controllers/transcript_selection_controller.js b/app/javascript/controllers/transcript_selection_controller.jsindex 545c971..eff31ed 100644--- a/app/javascript/controllers/transcript_selection_controller.js+++ b/app/javascript/controllers/transcript_selection_controller.js@@ -25,6 +25,9 @@ export default class extends Controller {connect() {this.follow = this.follow.bind(this)document.addEventListener("selectionchange", this.follow)+ // A mark made before this controller connected (the page was still loading its+ // scripts) changes nothing any more: look at it once now.+ this.follow()}disconnect() {diff --git a/spec/system/meeting_term_correction_spec.rb b/spec/system/meeting_term_correction_spec.rbindex 5800cb9..f9628b4 100644--- a/spec/system/meeting_term_correction_spec.rb+++ b/spec/system/meeting_term_correction_spec.rb@@ -15,11 +15,22 @@ RSpec.describe 'Correcting a term in a meeting', type: :system dolet(:transcript) { "Anna: Wir testen Lalabeis heute.\nBen: Lalabeis kann viel, sagt Anna.\nUnd Lalabeis-Konten auch." }before do+ # Stylesheets on: the button over a mark is hidden (Tailwind's hidden) until there is a+ # mark, so finding it visible waits for the controller to place it.+ driven_by :selenium_chrome_headless_fullProsopite.pauseActsAsTenant.current_tenant = organisationendafter do+ # The window and this origin's storage are reused by the next example (the lane state of+ # the meetings, tickets and glossary pages lives there).+ begin+ page.execute_script('sessionStorage.clear(); localStorage.clear()')+ rescue StandardError+ nil+ end+ page.driver.browser.manage.window.resize_to(1440, 900)ActsAsTenant.current_tenant = nilProsopite.resumeend@@ -130,12 +141,37 @@ RSpec.describe 'Correcting a term in a meeting', type: :system do)end+ # A meeting with notes shows its transcript collapsed (clamp: :tall): the text+ # the browser holds is the whole transcript all the same, and a mark in the+ # part that shows is found.+ it 'corrects in a collapsed transcript, only at the mark' do+ user = admin(:de)+ meeting = meeting_for(user)+ meeting.update!(notes: 'Kurze Notiz zum Gespräch.')+ sign_in user+ visit organisation_project_meetings_path(organisation, project, meeting_id: meeting.id)+ expect(page).to have_css("##{ActionView::RecordIdentifier.dom_id(meeting, :transcript)} [data-controller='clamp-toggle']")++ mark_in_transcript(meeting, 'Lalabeis', nth: 0)+ find("#meeting-term-correction-trigger-#{meeting.id}").click+ within('[role="dialog"]') do+ expect(page).to have_select(I18n.t("#{tc}.speaker_label", locale: :de), selected: 'Anna Ananas')+ fill_in I18n.t("#{tc}.correct_label", locale: :de), with: 'Lalabase'+ click_button I18n.t("#{tc}.here", locale: :de)+ end++ expect(page).to have_text(I18n.t("#{tc}.flash.replaced", count: 1, locale: :de))+ expect(meeting.reload.transcript).to start_with("Anna: Wir testen Lalabase heute.\nBen: Lalabeis kann viel")+ end+it 'offers no correction in the panel beside a ticket' douser = admin(:de)meeting = meeting_for(user)ticket = create(:ticket, project: project, title: 'Ticket neben dem Meeting', creator: user)meeting.outgoing_references.create!(organisation: organisation, target: ticket, target_title_snapshot: ticket.display_title)sign_in user+ # A medium grid: the ticket and the meeting beside each other (the after hook sets the+ # window back).page.driver.browser.manage.window.resize_to(1200, 900)visit organisation_project_tickets_path(organisation, project, ticket_id: ticket.id)@@ -146,7 +182,5 @@ RSpec.describe 'Correcting a term in a meeting', type: :system doexpect(page).to have_no_css('[data-controller~="transcript-selection"]')expect(page).to have_no_css("#meeting-term-correction-trigger-#{meeting.id}", visible: :all)end- ensure- page.driver.browser.manage.window.resize_to(1440, 900)endend