Skip to content

Self-hosted project management for devs and their clients: tickets, time tracking, docs and meetings, with an AI assistant that cites its sources. AGPL-3.0.

style(roles): clear the erb_lint findings of the role editor

Guido Boyke9b63c5484a41
diff --git a/app/views/organisations/roles/edit.html.erb b/app/views/organisations/roles/edit.html.erb
index cb39000..854a7ca 100644
--- a/app/views/organisations/roles/edit.html.erb
+++ b/app/views/organisations/roles/edit.html.erb
@@ -13,7 +13,7 @@
) %>
<% end %>
<% end %>
-
+
<% if @role.is_default || @role.account_admin? || true %>
<div class="max-w-6xl mt-4 mb-4">
<% if @role.is_default %>
@@ -63,14 +63,14 @@
<h3 class="text-lg font-semibold mb-4">
<%= t('views.organisations.roles.edit.basic_info') %>
</h3>
-
+
<div class="grid grid-cols-1 md:grid-cols-2 gap-6">
<div>
<%= form.label :title, t('views.organisations.roles.edit.label_title'), class: 'block text-sm font-medium text-gray-700 mb-2' %>
<%= form.text_field :title,
class: 'w-full px-3 py-2 border border-cream-300 bg-cream-50 rounded text-sm focus:outline-none focus:border-ink focus:ring-1 focus:ring-ink transition-all' %>
</div>
-
+
<div class="md:col-span-2">
<%= form.label :description, t('views.organisations.roles.edit.label_description'), class: 'block text-sm font-medium text-gray-700 mb-2' %>
<%= form.text_area :description, rows: 3,
@@ -95,12 +95,12 @@
<div class="absolute inset-y-0 left-0 flex items-center pl-3 pointer-events-none">
<i class="bi bi-search text-gray-400"></i>
</div>
- <input type="text" id="permission-search"
+ <input type="text" id="permission-search" autocomplete="off"
class="w-full pl-10 pr-3 py-2 border border-cream-300 bg-cream-50 rounded text-sm focus:outline-none focus:border-ink focus:ring-1 focus:ring-ink transition-all"
placeholder="<%= t('views.organisations.roles.edit.search_placeholder') %>"
onkeyup="filterPermissions()">
</div>
-
+
<div class="text-sm text-gray-500">
<%= t('views.organisations.roles.edit.category_hint') %>
</div>
@@ -139,20 +139,20 @@
end %>
<i class="bi <%= category_icon %> text-xl mr-2"></i>
<h2 class="text-xl font-semibold"><%= category_name(category.to_s) %></h2>
-
+
<!-- Select all permissions in this category -->
<div class="ml-auto">
- <button type="button" onclick="toggleCategoryPermissions('<%= category %>', true)"
+ <button type="button" onclick="toggleCategoryPermissions(<%= category.to_s.to_json %>, true)"
class="text-sm text-cobalt-600 hover:underline ml-2">
<%= t('views.organisations.roles.edit.select_all') %>
</button>
- <button type="button" onclick="toggleCategoryPermissions('<%= category %>', false)"
+ <button type="button" onclick="toggleCategoryPermissions(<%= category.to_s.to_json %>, false)"
class="text-sm text-cobalt-600 hover:underline ml-2">
<%= t('views.organisations.roles.edit.deselect_all') %>
</button>
</div>
</div>
-
+
<div class="space-y-3">
<%
# Sort and group permissions sensibly
@@ -163,7 +163,7 @@
read_permissions = []
write_permissions = []
other_permissions = []
-
+
actions.each do |action|
if action.start_with?('read_access_')
read_permissions << action
@@ -173,7 +173,7 @@
other_permissions << action
end
end
-
+
# Filter old read/write permissions (deprecated) - these should no longer be used
old_permissions = []
if read_permissions.include?('read_access_all_projects')
@@ -190,7 +190,7 @@
read_permissions.sort!
write_permissions.sort!
other_permissions.sort!
-
+
grouped_actions = {
t('views.organisations.roles.edit.group_read') => read_permissions,
t('views.organisations.roles.edit.group_write') => write_permissions,
@@ -201,7 +201,7 @@
grouped_actions[t('views.organisations.roles.edit.group_permissions')] = actions
end
%>
-
+
<% grouped_actions.each do |group_name, group_actions| %>
<% if group_actions.any? %>
<div class="mt-3 mb-2">
@@ -212,12 +212,12 @@
<div class="flex items-start hover:bg-cream-100 p-2 rounded permission-item"
data-name="<%= action %>" data-category="<%= category %>">
<div class="flex items-center h-5">
- <%= check_box_tag "permissions[#{category}][#{action}]", 1, @permissions[category][action],
+ <%= check_box_tag "permissions[#{category}][#{action}]", 1, @permissions[category][action],
class: "h-5 w-5 rounded border-gray-300 text-cobalt-600 focus:ring-cobalt-500 permission-checkbox",
'data-category': category, 'data-action': action %>
</div>
<div class="ml-3">
- <label for="permissions[<%= category %>][<%= action %>]"
+ <label for="permissions[<%= category %>][<%= action %>]"
class="font-medium text-gray-700 cursor-pointer">
<%= action.humanize.gsub('_', ' ') %>
</label>
@@ -236,7 +236,7 @@
<% end %>
</div>
</div>
-
+
<!-- Project permissions tab -->
<div class="hidden" id="projects" role="tabpanel" aria-labelledby="projects-tab">
<div class="bg-cobalt-50 border-l-4 border-cobalt-400 p-4 mb-6">
@@ -251,10 +251,10 @@
</div>
</div>
</div>
-
+
<% category = :projects %>
<% actions = @permission_categories[category] %>
-
+
<div class="grid grid-cols-1 md:grid-cols-2 gap-6">
<!-- Read-access permissions -->
<div class="bg-cobalt-50 rounded-lg shadow p-4 border border-cobalt-200">
@@ -273,19 +273,19 @@
</button>
</div>
</div>
-
+
<div class="space-y-2">
<% read_actions = actions.select { |a| a.start_with?('read_access_') } %>
<% read_actions.each do |action| %>
<div class="flex items-start hover:bg-cobalt-100 p-2 rounded permission-item"
data-name="<%= action %>" data-category="<%= category %>">
<div class="flex items-center h-5">
- <%= check_box_tag "permissions[#{category}][#{action}]", 1, @permissions[category][action],
+ <%= check_box_tag "permissions[#{category}][#{action}]", 1, @permissions[category][action],
class: "h-5 w-5 rounded border-gray-300 text-cobalt-600 focus:ring-cobalt-500 permission-checkbox read-permission",
'data-category': category, 'data-action': action %>
</div>
<div class="ml-3">
- <label for="permissions[<%= category %>][<%= action %>]"
+ <label for="permissions[<%= category %>][<%= action %>]"
class="font-medium text-gray-700 cursor-pointer">
<%= action.humanize.gsub('_', ' ') %>
</label>
@@ -297,7 +297,7 @@
<% end %>
</div>
</div>
-
+
<!-- Write-access permissions -->
<div class="bg-green-50 rounded-lg shadow p-4 border border-green-200">
<div class="flex items-center mb-4">
@@ -315,19 +315,19 @@
</button>
</div>
</div>
-
+
<div class="space-y-2">
<% write_actions = actions.select { |a| a.start_with?('write_access_') } %>
<% write_actions.each do |action| %>
<div class="flex items-start hover:bg-green-100 p-2 rounded permission-item"
data-name="<%= action %>" data-category="<%= category %>">
<div class="flex items-center h-5">
- <%= check_box_tag "permissions[#{category}][#{action}]", 1, @permissions[category][action],
+ <%= check_box_tag "permissions[#{category}][#{action}]", 1, @permissions[category][action],
class: "h-5 w-5 rounded border-gray-300 text-green-600 focus:ring-green-500 permission-checkbox write-permission",
'data-category': category, 'data-action': action %>
</div>
<div class="ml-3">
- <label for="permissions[<%= category %>][<%= action %>]"
+ <label for="permissions[<%= category %>][<%= action %>]"
class="font-medium text-gray-700 cursor-pointer">
<%= action.humanize.gsub('_', ' ') %>
</label>
@@ -339,26 +339,26 @@
<% end %>
</div>
</div>
-
+
<!-- Project management permissions -->
<div class="bg-purple-50 rounded-lg shadow p-4 border border-purple-200 md:col-span-2">
<div class="flex items-center mb-4">
<i class="bi bi-gear text-xl mr-2 text-purple-600"></i>
<h2 class="text-xl font-semibold text-purple-800"><%= t('views.organisations.roles.edit.project_management') %></h2>
</div>
-
+
<div class="space-y-2">
<% other_actions = actions.reject { |a| a.start_with?('read_access_') || a.start_with?('write_access_') } %>
<% other_actions.each do |action| %>
<div class="flex items-start hover:bg-purple-100 p-2 rounded permission-item"
data-name="<%= action %>" data-category="<%= category %>">
<div class="flex items-center h-5">
- <%= check_box_tag "permissions[#{category}][#{action}]", 1, @permissions[category][action],
+ <%= check_box_tag "permissions[#{category}][#{action}]", 1, @permissions[category][action],
class: "h-5 w-5 rounded border-gray-300 text-purple-600 focus:ring-purple-500 permission-checkbox",
'data-category': category, 'data-action': action %>
</div>
<div class="ml-3">
- <label for="permissions[<%= category %>][<%= action %>]"
+ <label for="permissions[<%= category %>][<%= action %>]"
class="font-medium text-gray-700 cursor-pointer">
<%= action.humanize.gsub('_', ' ') %>
</label>
@@ -372,7 +372,7 @@
</div>
</div>
</div>
-
+
</div>
<!-- JavaScript for tabs and functions -->
@@ -412,11 +412,11 @@
function filterPermissions() {
const searchTerm = document.getElementById('permission-search').value.toLowerCase();
const items = document.querySelectorAll('.permission-item');
-
+
items.forEach(item => {
const name = item.getAttribute('data-name').toLowerCase();
const description = item.querySelector('p').textContent.toLowerCase();
-
+
if (name.includes(searchTerm) || description.includes(searchTerm)) {
item.style.display = '';
} else {
@@ -424,7 +424,7 @@
}
});
}
-
+
// Bulk selection for categories
function toggleCategoryPermissions(category, state) {
const checkboxes = document.querySelectorAll(`.permission-checkbox[data-category="${category}"]`);
@@ -432,21 +432,21 @@
checkbox.checked = state;
});
}
-
+
function toggleReadPermissions(state) {
const readCheckboxes = document.querySelectorAll('.read-permission');
readCheckboxes.forEach(checkbox => {
checkbox.checked = state;
});
}
-
+
function toggleWritePermissions(state) {
const writeCheckboxes = document.querySelectorAll('.write-permission');
writeCheckboxes.forEach(checkbox => {
checkbox.checked = state;
});
}
-
+
// Initialization
document.addEventListener('DOMContentLoaded', () => {
setupTabs();
@@ -454,7 +454,7 @@
</script>
</div>
-
+
<!-- Footer with buttons -->
<div class="flex items-center justify-end gap-4 pt-6">
<%= render Neo::Buttons::ButtonComponent.new(variant: :secondary, size: :large,
@@ -468,4 +468,4 @@
</div>
<% end %>
</div>
-</div>
\ No newline at end of file
+</div>