Self-hosted project management for devs and their clients: tickets, time tracking, docs and meetings, with an AI assistant that cites its sources. AGPL-3.0.
Ruby agplai-assistantdockerdsgvogdprhotwireissue-trackerjira-alternativeknowledge-basellmmcp-servermeeting-notesopen-sourceproject-managementredmine-alternativeruby-on-railsself-hostedticketingtime-tracking
Keep the dark red of the member panel and the phone's square "+"
Guido Boykec4c2de1c13e1
diff --git a/app/assets/stylesheets/application.tailwind.css b/app/assets/stylesheets/application.tailwind.cssindex ad59778..7ebee46 100644--- a/app/assets/stylesheets/application.tailwind.css+++ b/app/assets/stylesheets/application.tailwind.css@@ -40,7 +40,7 @@.members-row:focus-within, .members-invitation-row:focus-within { @apply bg-cream-200/70; }.members-row--selected, .members-row--selected:focus-within { @apply bg-cream-200; }.members-row--selected:hover { background-color: rgb(var(--selected-row-hover)); }- .dark .more-menu__danger { color: var(--wash-danger-text); }+ .dark .members-danger { color: var(--wash-danger-text); }/* The list is capped (layout.css, "Page widths"); open, the lane docks at thecap and adds its 24 px gap and its 400 px. */@media (min-width: 1100px) {@@ -402,7 +402,8 @@the rebuilt tickets. Tokens only, so all three themes follow. */@layer components {.people-head { @apply flex items-center gap-4 px-6 pt-5; }- .people-head > * { @apply min-w-0 flex-1; }+ /* The title box takes the width; the phone's square "+" keeps its size. */+ .people-head > :not(.people-head__action) { @apply min-w-0 flex-1; }.people-head__action { margin-inline-start: auto; }.people-tools { @apply flex flex-wrap items-center gap-2 px-6 pb-3 pt-4; }.people-search { width: 260px; max-width: 100%; }diff --git a/spec/system/people_review_74_spec.rb b/spec/system/people_review_74_spec.rbnew file mode 100644index 0000000..46bd7a8--- /dev/null+++ b/spec/system/people_review_74_spec.rb@@ -0,0 +1,65 @@+# frozen_string_literal: true++require 'rails_helper'++# Review of PR #74, two findings only a browser shows.+#+# P2: the rename of the members page's menu classes also renamed the dark+# rule of .members-danger, which the member panel still uses for its error+# line and "Mitglied entfernen". In dark mode that text fell back to the+# light red, 2.7:1 against the dark surface instead of 8.9:1.+#+# P3: .people-head > * stretched every child of the head, the phone's square+# "+" too (327 x 40 instead of 40 x 40).+RSpec.describe 'People page, review of PR #74', type: :system do+ let(:organisation) { create(:organisation) }+ let(:admin) { create(:user, first_name: 'Anna', last_name: 'Admin') }+ let(:colleague) { create(:user, first_name: 'Carl', last_name: 'Kollege') }++ before do+ Prosopite.pause+ ActsAsTenant.current_tenant = organisation+ role = create(:role, organisation: organisation, title: Role::ACCOUNT_ADMIN_TITLE)+ create(:membership, user: admin, organisation: organisation, role: role, active: true)+ sign_in admin+ end++ after do+ ActsAsTenant.current_tenant = nil+ Prosopite.resume+ end++ it 'keeps the dark red of "Mitglied entfernen" in the member panel' do+ membership = create(:membership, user: colleague, organisation: organisation,+ role: create(:role, organisation: organisation), active: true)+ visit organisation_memberships_path(organisation)+ page.execute_script("localStorage.setItem('lb-theme', 'dark')")+ visit organisation_memberships_path(organisation, membership_id: membership.id)++ remove = find('.members-panel .members-danger', text: I18n.t('member_management.remove'))+ colors = page.evaluate_script(<<~JS, remove.native)+ (function (element) {+ const wanted = getComputedStyle(document.documentElement).getPropertyValue('--wash-danger-text').trim()+ const resolved = document.createElement('span')+ resolved.style.color = wanted+ document.body.append(resolved)+ const result = { dark: document.documentElement.classList.contains('dark'),+ actual: getComputedStyle(element).color, expected: getComputedStyle(resolved).color }+ resolved.remove()+ return result+ })(arguments[0])+ JS++ expect(colors['dark']).to be(true)+ expect(colors['actual']).to eq(colors['expected'])+ end++ it 'keeps the phone\'s "+" square' do+ visit organisation_people_path(organisation, viewport: 'mobile')++ add = find('.people-head__action')+ size = page.evaluate_script('(function (e) { const r = e.getBoundingClientRect(); return [r.width, r.height] })(arguments[0])',+ add.native)+ expect(size[0]).to be_within(1).of(size[1])+ end+end