Skip to content

Self-hosted project management for devs and their clients: tickets, time tracking, docs and meetings, with an AI assistant that cites its sources. AGPL-3.0.

Keep the panel's close button with the sticky tabs at the narrow stage

Guido Boykeca2d5c82d0c4
diff --git a/app/assets/stylesheets/components/ticket_meeting_panel.css b/app/assets/stylesheets/components/ticket_meeting_panel.css
index 0731802..01970d9 100644
--- a/app/assets/stylesheets/components/ticket_meeting_panel.css
+++ b/app/assets/stylesheets/components/ticket_meeting_panel.css
@@ -127,8 +127,16 @@
box-shadow: inset 0 -2px 0 rgb(var(--ink));
}
- /* The lane's close button stays reachable while the ticket is in front. */
- .layout[data-meeting-panel-stage="narrow"][data-meeting-panel-tab="ticket"]:not(.hide-panel) > .column.panel .panel-close {
+ /* Follow the sticky tabs in either tab, even when the meeting keeps its scroll
+ position behind the ticket. Float with no flow height to share the tabs' row. */
+ .layout[data-meeting-panel-stage="narrow"]:not(.hide-panel) > .column.panel .panel-close {
+ position: sticky;
+ top: 8px;
+ right: auto;
+ float: right;
+ width: 2rem;
+ height: 2rem;
+ margin-bottom: -2rem;
visibility: visible;
z-index: 2;
}
diff --git a/spec/system/ticket_meeting_panel_stages_spec.rb b/spec/system/ticket_meeting_panel_stages_spec.rb
index 3dd650c..393597d 100644
--- a/spec/system/ticket_meeting_panel_stages_spec.rb
+++ b/spec/system/ticket_meeting_panel_stages_spec.rb
@@ -158,6 +158,13 @@ RSpec.describe 'Meeting beside the ticket, by the width of the grid', type: :sys
stage_tab("Ticket ##{ticket.number}").click
expect(page).to have_css("#ticket-content-#{ticket.id}", visible: :visible)
expect(scroll_top('.layout .column.content')).to be_within(2).of(700)
+
+ # The meeting still sits 900px down behind the ticket. Its close control must
+ # stay in the visible tab bar, without scrolling either lane back to the top.
+ expect(page).to have_css('aside.column.panel .panel-close', obscured: false)
+ find('aside.column.panel .panel-close').click
+ expect(page).to have_css('.layout.hide-panel')
+ expect(page).to have_css("#ticket-content-#{ticket.id}", visible: :visible)
end
it 'keeps a hidden list hidden at the wide stage, with no channel before the ticket' do