Skip to content

Self-hosted project management for devs and their clients: tickets, time tracking, docs and meetings, with an AI assistant that cites its sources. AGPL-3.0.

Keep a refused request a handled error in "Reply with AI"

Guido Boykefa7f38ab4098
diff --git a/app/services/actors/create_ai_post.rb b/app/services/actors/create_ai_post.rb
index 246c158..ca5374b 100644
--- a/app/services/actors/create_ai_post.rb
+++ b/app/services/actors/create_ai_post.rb
@@ -98,7 +98,9 @@ module Actors
# Provider maps the vendor 401 to AuthError.
Rails.logger.error "AI API key invalid: #{e.message}"
raise ActorError.new(e.message, code: :invalid_key)
- rescue Faraday::ClientError => e
+ rescue Lalabase::Llm::Provider::RequestRefusedError, Faraday::ClientError => e
+ # The providers map a vendor 400 to RequestRefusedError (a Provider::Error,
+ # no longer a Faraday::ClientError); it stays the handled provider error.
Rails.logger.error "AI API error: #{e.message}"
raise ActorError.new(e.message, code: :provider_error)
end
diff --git a/spec/services/actors/create_ai_post_spec.rb b/spec/services/actors/create_ai_post_spec.rb
index 859f01e..058deb9 100644
--- a/spec/services/actors/create_ai_post_spec.rb
+++ b/spec/services/actors/create_ai_post_spec.rb
@@ -223,6 +223,29 @@ RSpec.describe Actors::CreateAiPost, type: :service do
expect(result.errors.first).to include('boom 502')
end
+ # The providers map a vendor 400 to RequestRefusedError (a Provider::Error,
+ # no longer a Faraday::ClientError). It must stay the handled provider error,
+ # not fall through to :internal_error (or raise in development and test).
+ it 'maps a chat RequestRefusedError → :provider_error and preserves the message' do
+ allow(Lalabase::Llm::Factory).to receive(:for_feature).and_call_original
+ allow(Lalabase::Llm::Factory).to receive(:for_feature).with(:ask_ai_post, anything).and_return(provider)
+ allow(provider).to receive(:chat).and_raise(Lalabase::Llm::Provider::RequestRefusedError.new('HTTP 400: refused'))
+ result = nil
+ expect { result = call }.not_to change(Post.where(ticket: ticket), :count)
+ expect(result.code).to eq(:provider_error)
+ expect(result.errors.first).to include('HTTP 400: refused')
+ end
+
+ it 'keeps an OpenAI 400 the handled provider error end to end (real provider, stubbed client)' do
+ fake_client = instance_double(OpenAI::Client)
+ allow(OpenAI::Client).to receive(:new).and_return(fake_client)
+ allow(fake_client).to receive(:chat).and_raise(Faraday::BadRequestError.new('the server responded with status 400'))
+ allow(Lalabase::Llm::Factory).to receive(:for_feature).and_call_original
+ real_provider = Lalabase::Llm::OpenAiProvider.new(api_key: 'sk-test')
+ allow(Lalabase::Llm::Factory).to receive(:for_feature).with(:ask_ai_post, anything).and_return(real_provider)
+ expect(call.code).to eq(:provider_error)
+ end
+
it 'writes no post on any provider failure' do
allow(Lalabase::Llm::Factory).to receive(:for_feature).and_call_original
allow(Lalabase::Llm::Factory).to receive(:for_feature).with(:ask_ai_post, anything).and_raise(Lalabase::Llm::AiDisabledError.new('off'))