The agent engineering platform.
Python agentsaiai-agentsanthropicchatgptdeepagentsenterpriseframeworkgeminigenerative-ailangchainlanggraphllmmultiagentopen-sourceopenaipydanticpythonragtypescript
chore(langchain): fix types in test_model_fallback (#34615)
Christophe Bornet0438f8c27755
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_model_fallback.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_model_fallback.pyindex a679ff69de..c268f6c565 100644--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_model_fallback.py+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_model_fallback.py@@ -3,13 +3,14 @@from __future__ import annotationsimport warnings-from typing import TYPE_CHECKING, cast+from typing import TYPE_CHECKING, Any, castimport pytestfrom langchain_core.language_models.chat_models import BaseChatModelfrom langchain_core.language_models.fake_chat_models import GenericFakeChatModel-from langchain_core.messages import AIMessage, HumanMessage+from langchain_core.messages import AIMessage, BaseMessage, HumanMessage, SystemMessagefrom langchain_core.outputs import ChatGeneration, ChatResult+from typing_extensions import overridefrom langchain.agents.factory import create_agentfrom langchain.agents.middleware.model_fallback import ModelFallbackMiddleware@@ -17,6 +18,7 @@ from langchain.agents.middleware.types import AgentState, ModelRequest, ModelResfrom tests.unit_tests.agents.model import FakeToolCallingModelif TYPE_CHECKING:+ from langchain_core.callbacks import AsyncCallbackManagerForLLMRun, CallbackManagerForLLMRunfrom langgraph.runtime import Runtime@@ -34,7 +36,7 @@ def _make_request() -> ModelRequest:tool_choice=None,tools=[],response_format=None,- state=cast("AgentState", {}),+ state=AgentState(messages=[]),runtime=_fake_runtime(),model_settings={},)@@ -64,7 +66,14 @@ def test_fallback_on_primary_failure() -> None:"""Test that fallback model is used when primary fails."""class FailingPrimaryModel(GenericFakeChatModel):- def _generate(self, messages, **kwargs):+ @override+ def _generate(+ self,+ messages: list[BaseMessage],+ stop: list[str] | None = None,+ run_manager: CallbackManagerForLLMRun | None = None,+ **kwargs: Any,+ ) -> ChatResult:msg = "Primary model failed"raise ValueError(msg)@@ -89,7 +98,14 @@ def test_multiple_fallbacks() -> None:"""Test that multiple fallback models are tried in sequence."""class FailingModel(GenericFakeChatModel):- def _generate(self, messages, **kwargs):+ @override+ def _generate(+ self,+ messages: list[BaseMessage],+ stop: list[str] | None = None,+ run_manager: CallbackManagerForLLMRun | None = None,+ **kwargs: Any,+ ) -> ChatResult:msg = "Model failed"raise ValueError(msg)@@ -115,7 +131,14 @@ def test_all_models_fail() -> None:"""Test that exception is raised when all models fail."""class AlwaysFailingModel(GenericFakeChatModel):- def _generate(self, messages, **kwargs):+ @override+ def _generate(+ self,+ messages: list[BaseMessage],+ stop: list[str] | None = None,+ run_manager: CallbackManagerForLLMRun | None = None,+ **kwargs: Any,+ ) -> ChatResult:msg = "Model failed"raise ValueError(msg)@@ -158,7 +181,14 @@ async def test_fallback_on_primary_failure_async() -> None:"""Test async version - fallback model is used when primary fails."""class AsyncFailingPrimaryModel(GenericFakeChatModel):- async def _agenerate(self, messages, **kwargs):+ @override+ async def _agenerate(+ self,+ messages: list[BaseMessage],+ stop: list[str] | None = None,+ run_manager: AsyncCallbackManagerForLLMRun | None = None,+ **kwargs: Any,+ ) -> ChatResult:msg = "Primary model failed"raise ValueError(msg)@@ -183,7 +213,14 @@ async def test_multiple_fallbacks_async() -> None:"""Test async version - multiple fallback models are tried in sequence."""class AsyncFailingModel(GenericFakeChatModel):- async def _agenerate(self, messages, **kwargs):+ @override+ async def _agenerate(+ self,+ messages: list[BaseMessage],+ stop: list[str] | None = None,+ run_manager: AsyncCallbackManagerForLLMRun | None = None,+ **kwargs: Any,+ ) -> ChatResult:msg = "Model failed"raise ValueError(msg)@@ -209,7 +246,14 @@ async def test_all_models_fail_async() -> None:"""Test async version - exception is raised when all models fail."""class AsyncAlwaysFailingModel(GenericFakeChatModel):- async def _agenerate(self, messages, **kwargs):+ @override+ async def _agenerate(+ self,+ messages: list[BaseMessage],+ stop: list[str] | None = None,+ run_manager: AsyncCallbackManagerForLLMRun | None = None,+ **kwargs: Any,+ ) -> ChatResult:msg = "Model failed"raise ValueError(msg)@@ -234,24 +278,38 @@ def test_model_fallback_middleware_with_agent() -> None:class FailingModel(BaseChatModel):"""Model that always fails."""- def _generate(self, messages, **kwargs):+ @override+ def _generate(+ self,+ messages: list[BaseMessage],+ stop: list[str] | None = None,+ run_manager: CallbackManagerForLLMRun | None = None,+ **kwargs: Any,+ ) -> ChatResult:msg = "Primary model failed"raise ValueError(msg)@property- def _llm_type(self):+ def _llm_type(self) -> str:return "failing"class SuccessModel(BaseChatModel):"""Model that succeeds."""- def _generate(self, messages, **kwargs):+ @override+ def _generate(+ self,+ messages: list[BaseMessage],+ stop: list[str] | None = None,+ run_manager: CallbackManagerForLLMRun | None = None,+ **kwargs: Any,+ ) -> ChatResult:return ChatResult(generations=[ChatGeneration(message=AIMessage(content="Fallback success"))])@property- def _llm_type(self):+ def _llm_type(self) -> str:return "success"primary = FailingModel()@@ -279,13 +337,20 @@ def test_model_fallback_middleware_exhausted_with_agent() -> None:super().__init__()self.name = name- def _generate(self, messages, **kwargs):+ @override+ def _generate(+ self,+ messages: list[BaseMessage],+ stop: list[str] | None = None,+ run_manager: CallbackManagerForLLMRun | None = None,+ **kwargs: Any,+ ) -> ChatResult:msg = f"{self.name} failed"raise ValueError(msg)@property- def _llm_type(self):- return self.name+ def _llm_type(self) -> str:+ return self.name or "always_failing"primary = AlwaysFailingModel("primary")fallback1 = AlwaysFailingModel("fallback1")@@ -325,7 +390,7 @@ def test_model_request_is_frozen() -> None:with pytest.warns(DeprecationWarning, match="Direct attribute assignment to ModelRequest.model is deprecated"):- request.model = new_model # type: ignore[misc]+ request.model = new_model# Verify the assignment actually workedassert request.model == new_model@@ -342,7 +407,7 @@ def test_model_request_is_frozen() -> None:DeprecationWarning,match="Direct attribute assignment to ModelRequest.messages is deprecated",):- request.messages = [] # type: ignore[misc]+ request.messages = []assert request.messages == []@@ -350,7 +415,9 @@ def test_model_request_is_frozen() -> None:request2 = _make_request()with warnings.catch_warnings():warnings.simplefilter("error") # Turn warnings into errors- new_request = request2.override(model=new_model, system_prompt="override prompt")+ new_request = request2.override(+ model=new_model, system_message=SystemMessage(content="override prompt")+ )assert new_request.model == new_modelassert new_request.system_prompt == "override prompt"