The agent engineering platform.
Python agentsaiai-agentsanthropicchatgptdeepagentsenterpriseframeworkgeminigenerative-ailangchainlanggraphllmmultiagentopen-sourceopenaipydanticpythonragtypescript
fix(chroma): pydantic validation error when using `retriever.invoke()` (#31377)
Abhinav0861cba04b71
diff --git a/libs/partners/chroma/langchain_chroma/vectorstores.py b/libs/partners/chroma/langchain_chroma/vectorstores.pyindex 106c5451f7..fd33edcb50 100644--- a/libs/partners/chroma/langchain_chroma/vectorstores.py+++ b/libs/partners/chroma/langchain_chroma/vectorstores.py@@ -51,18 +51,25 @@ def _results_to_docs_and_scores(results: Any) -> list[tuple[Document, float]]:results["distances"][0],strict=False,)+ if result[0] is not None]def _results_to_docs_and_vectors(results: Any) -> list[tuple[Document, np.ndarray]]:+ """Convert ChromaDB results to documents and vectors, filtering out None content."""return [- (Document(page_content=result[0], metadata=result[1] or {}), result[2])+ (+ Document(page_content=result[0], metadata=result[1] or {}, id=result[3]),+ result[2],+ )for result in zip(results["documents"][0],results["metadatas"][0],results["embeddings"][0],+ results["ids"][0],strict=False,)+ if result[0] is not None]@@ -1155,6 +1162,7 @@ class Chroma(VectorStore):results["ids"],strict=False,)+ if doc is not None # Filter out documents with None page_content]def update_document(self, document_id: str, document: Document) -> None:diff --git a/libs/partners/chroma/tests/integration_tests/test_vectorstores.py b/libs/partners/chroma/tests/integration_tests/test_vectorstores.pyindex 3c4b0ae75f..548c1c04f1 100644--- a/libs/partners/chroma/tests/integration_tests/test_vectorstores.py+++ b/libs/partners/chroma/tests/integration_tests/test_vectorstores.py@@ -193,7 +193,10 @@ def test_chroma_with_metadatas_with_vectors() -> None:vec_1 = embeddings.embed_query(texts[0])output = docsearch.similarity_search_with_vectors("foo", k=1)docsearch.delete_collection()- assert output[0][0] == Document(page_content="foo", metadata={"page": "0"})+ doc = output[0][0]+ assert doc.page_content == "foo"+ assert doc.metadata == {"page": "0"}+ assert doc.id is not Noneassert (output[0][1] == vec_1).all()@@ -825,3 +828,44 @@ def test_delete_where_clause(client: chromadb.ClientAPI) -> None:assert vectorstore._collection.count() == 1# Clean upvectorstore.delete_collection()+++def test_chroma_handles_none_page_content() -> None:+ """Test that Chroma gracefully handles None page_content values."""+ from langchain_chroma.vectorstores import _results_to_docs_and_scores++ mock_results = {+ "documents": [["valid content", None, "another valid content"]],+ "metadatas": [[{"key": "value1"}, {"key": "value2"}, {"key": "value3"}]],+ "ids": [["id1", "id2", "id3"]],+ "distances": [[0.1, 0.2, 0.3]],+ }++ docs_and_scores = _results_to_docs_and_scores(mock_results)++ assert len(docs_and_scores) == 2+ assert docs_and_scores[0][0].page_content == "valid content"+ assert docs_and_scores[1][0].page_content == "another valid content"+ assert docs_and_scores[0][0].id == "id1"+ assert docs_and_scores[1][0].id == "id3"+++def test_chroma_handles_none_page_content_with_vectors() -> None:+ """Test that Chroma gracefully handles None page_content values with vectors."""+ from langchain_chroma.vectorstores import _results_to_docs_and_vectors++ mock_results = {+ "documents": [["valid content", None, "another valid content"]],+ "metadatas": [[{"key": "value1"}, {"key": "value2"}, {"key": "value3"}]],+ "ids": [["id1", "id2", "id3"]],+ "embeddings": [[[0.1, 0.2], [0.3, 0.4], [0.5, 0.6]]],+ }+ docs_and_vectors = _results_to_docs_and_vectors(mock_results)++ assert len(docs_and_vectors) == 2+ assert docs_and_vectors[0][0].page_content == "valid content"+ assert docs_and_vectors[1][0].page_content == "another valid content"+ assert docs_and_vectors[0][0].id == "id1"+ assert docs_and_vectors[1][0].id == "id3"+ assert docs_and_vectors[0][1] == [0.1, 0.2]+ assert docs_and_vectors[1][1] == [0.5, 0.6]