Skip to content

The agent engineering platform.

core(patch): Fix encoding problem of load_prompt method (#21559)

Guangdong Liu0bce28cd30b9
diff --git a/libs/core/langchain_core/prompts/loading.py b/libs/core/langchain_core/prompts/loading.py
index eeb2c57bfb..0b554a90dc 100644
--- a/libs/core/langchain_core/prompts/loading.py
+++ b/libs/core/langchain_core/prompts/loading.py
@@ -3,7 +3,7 @@
import json
import logging
from pathlib import Path
-from typing import Callable, Dict, Union
+from typing import Callable, Dict, Optional, Union
import yaml
@@ -125,7 +125,9 @@ def _load_prompt(config: dict) -> PromptTemplate:
return PromptTemplate(**config)
-def load_prompt(path: Union[str, Path]) -> BasePromptTemplate:
+def load_prompt(
+ path: Union[str, Path], encoding: Optional[str] = None
+) -> BasePromptTemplate:
"""Unified method for loading a prompt from LangChainHub or local fs."""
if isinstance(path, str) and path.startswith("lc://"):
raise RuntimeError(
@@ -133,10 +135,12 @@ def load_prompt(path: Union[str, Path]) -> BasePromptTemplate:
"Please use the new LangChain Hub at https://smith.langchain.com/hub "
"instead."
)
- return _load_prompt_from_file(path)
+ return _load_prompt_from_file(path, encoding)
-def _load_prompt_from_file(file: Union[str, Path]) -> BasePromptTemplate:
+def _load_prompt_from_file(
+ file: Union[str, Path], encoding: Optional[str] = None
+) -> BasePromptTemplate:
"""Load prompt from file."""
# Convert file to a Path object.
if isinstance(file, str):
@@ -145,10 +149,10 @@ def _load_prompt_from_file(file: Union[str, Path]) -> BasePromptTemplate:
file_path = file
# Load from either json or yaml.
if file_path.suffix == ".json":
- with open(file_path) as f:
+ with open(file_path, encoding=encoding) as f:
config = json.load(f)
elif file_path.suffix.endswith((".yaml", ".yml")):
- with open(file_path, "r") as f:
+ with open(file_path, mode="r", encoding=encoding) as f:
config = yaml.safe_load(f)
else:
raise ValueError(f"Got unsupported file type {file_path.suffix}")