Skip to content

The agent engineering platform.

chore(langchain): fix types in `memory_assert`, `conftest`, `conftest_checkpointer` and `conftest_store` (#34636)

Christophe Bornet23c4c506d395
diff --git a/libs/langchain_v1/tests/unit_tests/agents/conftest.py b/libs/langchain_v1/tests/unit_tests/agents/conftest.py
index 95f7e32670..8cec1e5fac 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/conftest.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/conftest.py
@@ -95,7 +95,7 @@ def deterministic_uuids(mocker: MockerFixture) -> MockerFixture:
@pytest.fixture(
params=SYNC_STORE_PARAMS,
)
-def sync_store(request: pytest.FixtureRequest) -> Iterator[BaseStore]:
+def sync_store(request: pytest.FixtureRequest) -> Iterator[BaseStore | None]:
store_name = request.param
if store_name is None:
yield None
@@ -119,7 +119,7 @@ def sync_store(request: pytest.FixtureRequest) -> Iterator[BaseStore]:
@pytest.fixture(
params=ASYNC_STORE_PARAMS,
)
-async def async_store(request: pytest.FixtureRequest) -> AsyncIterator[BaseStore]:
+async def async_store(request: pytest.FixtureRequest) -> AsyncIterator[BaseStore | None]:
store_name = request.param
if store_name is None:
yield None
@@ -145,7 +145,7 @@ async def async_store(request: pytest.FixtureRequest) -> AsyncIterator[BaseStore
)
def sync_checkpointer(
request: pytest.FixtureRequest,
-) -> Iterator[BaseCheckpointSaver]:
+) -> Iterator[BaseCheckpointSaver[str]]:
checkpointer_name = request.param
if checkpointer_name == "memory":
with _checkpointer_memory() as checkpointer:
@@ -172,7 +172,7 @@ def sync_checkpointer(
)
async def async_checkpointer(
request: pytest.FixtureRequest,
-) -> AsyncIterator[BaseCheckpointSaver]:
+) -> AsyncIterator[BaseCheckpointSaver[str]]:
checkpointer_name = request.param
if checkpointer_name == "memory":
with _checkpointer_memory() as checkpointer:
diff --git a/libs/langchain_v1/tests/unit_tests/agents/conftest_checkpointer.py b/libs/langchain_v1/tests/unit_tests/agents/conftest_checkpointer.py
index 44d19f3781..c18dca6e33 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/conftest_checkpointer.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/conftest_checkpointer.py
@@ -1,62 +1,65 @@
+from collections.abc import AsyncIterator, Iterator
from contextlib import asynccontextmanager, contextmanager
+from langgraph.checkpoint.base import BaseCheckpointSaver
+
from tests.unit_tests.agents.memory_assert import MemorySaverAssertImmutable
@contextmanager
-def _checkpointer_memory():
+def _checkpointer_memory() -> Iterator[BaseCheckpointSaver[str]]:
yield MemorySaverAssertImmutable()
@asynccontextmanager
-async def _checkpointer_memory_aio():
+async def _checkpointer_memory_aio() -> AsyncIterator[BaseCheckpointSaver[str]]:
yield MemorySaverAssertImmutable()
# Placeholder functions for other checkpointer types that aren't available
@contextmanager
-def _checkpointer_sqlite():
+def _checkpointer_sqlite() -> Iterator[BaseCheckpointSaver[str]]:
# Fallback to memory for now
yield MemorySaverAssertImmutable()
@contextmanager
-def _checkpointer_postgres():
+def _checkpointer_postgres() -> Iterator[BaseCheckpointSaver[str]]:
# Fallback to memory for now
yield MemorySaverAssertImmutable()
@contextmanager
-def _checkpointer_postgres_pipe():
+def _checkpointer_postgres_pipe() -> Iterator[BaseCheckpointSaver[str]]:
# Fallback to memory for now
yield MemorySaverAssertImmutable()
@contextmanager
-def _checkpointer_postgres_pool():
+def _checkpointer_postgres_pool() -> Iterator[BaseCheckpointSaver[str]]:
# Fallback to memory for now
yield MemorySaverAssertImmutable()
@asynccontextmanager
-async def _checkpointer_sqlite_aio():
+async def _checkpointer_sqlite_aio() -> AsyncIterator[BaseCheckpointSaver[str]]:
# Fallback to memory for now
yield MemorySaverAssertImmutable()
@asynccontextmanager
-async def _checkpointer_postgres_aio():
+async def _checkpointer_postgres_aio() -> AsyncIterator[BaseCheckpointSaver[str]]:
# Fallback to memory for now
yield MemorySaverAssertImmutable()
@asynccontextmanager
-async def _checkpointer_postgres_aio_pipe():
+async def _checkpointer_postgres_aio_pipe() -> AsyncIterator[BaseCheckpointSaver[str]]:
# Fallback to memory for now
yield MemorySaverAssertImmutable()
@asynccontextmanager
-async def _checkpointer_postgres_aio_pool():
+async def _checkpointer_postgres_aio_pool() -> AsyncIterator[BaseCheckpointSaver[str]]:
# Fallback to memory for now
yield MemorySaverAssertImmutable()
diff --git a/libs/langchain_v1/tests/unit_tests/agents/conftest_store.py b/libs/langchain_v1/tests/unit_tests/agents/conftest_store.py
index fb0eb4e2fb..8d74198779 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/conftest_store.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/conftest_store.py
@@ -1,58 +1,60 @@
+from collections.abc import AsyncIterator, Iterator
from contextlib import asynccontextmanager, contextmanager
+from langgraph.store.base import BaseStore
from langgraph.store.memory import InMemoryStore
@contextmanager
-def _store_memory():
+def _store_memory() -> Iterator[BaseStore]:
store = InMemoryStore()
yield store
@asynccontextmanager
-async def _store_memory_aio():
+async def _store_memory_aio() -> AsyncIterator[BaseStore]:
store = InMemoryStore()
yield store
# Placeholder functions for other store types that aren't available
@contextmanager
-def _store_postgres():
+def _store_postgres() -> Iterator[BaseStore]:
# Fallback to memory for now
store = InMemoryStore()
yield store
@contextmanager
-def _store_postgres_pipe():
+def _store_postgres_pipe() -> Iterator[BaseStore]:
# Fallback to memory for now
store = InMemoryStore()
yield store
@contextmanager
-def _store_postgres_pool():
+def _store_postgres_pool() -> Iterator[BaseStore]:
# Fallback to memory for now
store = InMemoryStore()
yield store
@asynccontextmanager
-async def _store_postgres_aio():
+async def _store_postgres_aio() -> AsyncIterator[BaseStore]:
# Fallback to memory for now
store = InMemoryStore()
yield store
@asynccontextmanager
-async def _store_postgres_aio_pipe():
+async def _store_postgres_aio_pipe() -> AsyncIterator[BaseStore]:
# Fallback to memory for now
store = InMemoryStore()
yield store
@asynccontextmanager
-async def _store_postgres_aio_pool():
+async def _store_postgres_aio_pool() -> AsyncIterator[BaseStore]:
# Fallback to memory for now
store = InMemoryStore()
yield store
diff --git a/libs/langchain_v1/tests/unit_tests/agents/memory_assert.py b/libs/langchain_v1/tests/unit_tests/agents/memory_assert.py
index d1e4d3a06b..0e08963e3a 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/memory_assert.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/memory_assert.py
@@ -2,20 +2,23 @@ import os
import tempfile
import time
from collections import defaultdict
-from functools import partial
+from typing import Any
+from langchain_core.runnables import RunnableConfig
from langgraph.checkpoint.base import (
ChannelVersions,
Checkpoint,
CheckpointMetadata,
- SerializerProtocol,
)
from langgraph.checkpoint.memory import InMemorySaver, PersistentDict
+from langgraph.checkpoint.serde.base import (
+ SerializerProtocol,
+)
from langgraph.pregel._checkpoint import copy_checkpoint
class MemorySaverAssertImmutable(InMemorySaver):
- storage_for_copies: defaultdict[str, dict[str, dict[str, Checkpoint]]]
+ storage_for_copies: defaultdict[str, dict[str, dict[str, tuple[str, bytes]]]]
def __init__(
self,
@@ -24,18 +27,23 @@ class MemorySaverAssertImmutable(InMemorySaver):
put_sleep: float | None = None,
) -> None:
_, filename = tempfile.mkstemp()
- super().__init__(serde=serde, factory=partial(PersistentDict, filename=filename))
+
+ class TempfilePersistentDict(PersistentDict):
+ def __init__(self, *args: Any, **kwargs: Any) -> None:
+ super().__init__(*args, filename=filename, **kwargs)
+
+ super().__init__(serde=serde, factory=TempfilePersistentDict)
self.storage_for_copies = defaultdict(lambda: defaultdict(dict))
self.put_sleep = put_sleep
self.stack.callback(os.remove, filename)
def put(
self,
- config: dict,
+ config: RunnableConfig,
checkpoint: Checkpoint,
metadata: CheckpointMetadata,
new_versions: ChannelVersions,
- ) -> None:
+ ) -> RunnableConfig:
if self.put_sleep:
time.sleep(self.put_sleep)
# assert checkpoint hasn't been modified since last written