Skip to content

The agent engineering platform.

chore(core): fix some ruff TC rules (#33929)

Christophe Bornet2bfbc29ccc22
diff --git a/libs/core/langchain_core/callbacks/base.py b/libs/core/langchain_core/callbacks/base.py
index af455bd970..f6b6b45742 100644
--- a/libs/core/langchain_core/callbacks/base.py
+++ b/libs/core/langchain_core/callbacks/base.py
@@ -5,13 +5,12 @@ from __future__ import annotations
import logging
from typing import TYPE_CHECKING, Any
-from typing_extensions import Self
-
if TYPE_CHECKING:
from collections.abc import Sequence
from uuid import UUID
from tenacity import RetryCallState
+ from typing_extensions import Self
from langchain_core.agents import AgentAction, AgentFinish
from langchain_core.documents import Document
diff --git a/libs/core/langchain_core/callbacks/manager.py b/libs/core/langchain_core/callbacks/manager.py
index 29db63609d..7ed53f7400 100644
--- a/libs/core/langchain_core/callbacks/manager.py
+++ b/libs/core/langchain_core/callbacks/manager.py
@@ -39,7 +39,6 @@ from langchain_core.tracers.context import (
tracing_v2_callback_var,
)
from langchain_core.tracers.langchain import LangChainTracer
-from langchain_core.tracers.schemas import Run
from langchain_core.tracers.stdout import ConsoleCallbackHandler
from langchain_core.utils.env import env_var_is_set
@@ -52,6 +51,7 @@ if TYPE_CHECKING:
from langchain_core.documents import Document
from langchain_core.outputs import ChatGenerationChunk, GenerationChunk, LLMResult
from langchain_core.runnables.config import RunnableConfig
+ from langchain_core.tracers.schemas import Run
logger = logging.getLogger(__name__)
diff --git a/libs/core/langchain_core/indexing/api.py b/libs/core/langchain_core/indexing/api.py
index de42a4f4f8..860d34f335 100644
--- a/libs/core/langchain_core/indexing/api.py
+++ b/libs/core/langchain_core/indexing/api.py
@@ -6,16 +6,9 @@ import hashlib
import json
import uuid
import warnings
-from collections.abc import (
- AsyncIterable,
- AsyncIterator,
- Callable,
- Iterable,
- Iterator,
- Sequence,
-)
from itertools import islice
from typing import (
+ TYPE_CHECKING,
Any,
Literal,
TypedDict,
@@ -29,6 +22,16 @@ from langchain_core.exceptions import LangChainException
from langchain_core.indexing.base import DocumentIndex, RecordManager
from langchain_core.vectorstores import VectorStore
+if TYPE_CHECKING:
+ from collections.abc import (
+ AsyncIterable,
+ AsyncIterator,
+ Callable,
+ Iterable,
+ Iterator,
+ Sequence,
+ )
+
# Magic UUID to use as a namespace for hashing.
# Used to try and generate a unique UUID for each document
# from hashing the document content and metadata.
diff --git a/libs/core/langchain_core/messages/base.py b/libs/core/langchain_core/messages/base.py
index 05ce4e57fd..0cc7614e53 100644
--- a/libs/core/langchain_core/messages/base.py
+++ b/libs/core/langchain_core/messages/base.py
@@ -5,11 +5,9 @@ from __future__ import annotations
from typing import TYPE_CHECKING, Any, cast, overload
from pydantic import ConfigDict, Field
-from typing_extensions import Self
from langchain_core._api.deprecation import warn_deprecated
from langchain_core.load.serializable import Serializable
-from langchain_core.messages import content as types
from langchain_core.utils import get_bolded_text
from langchain_core.utils._merge import merge_dicts, merge_lists
from langchain_core.utils.interactive_env import is_interactive_env
@@ -17,6 +15,9 @@ from langchain_core.utils.interactive_env import is_interactive_env
if TYPE_CHECKING:
from collections.abc import Sequence
+ from typing_extensions import Self
+
+ from langchain_core.messages import content as types
from langchain_core.prompts.chat import ChatPromptTemplate
diff --git a/libs/core/langchain_core/messages/block_translators/__init__.py b/libs/core/langchain_core/messages/block_translators/__init__.py
index 9d0c67ea7d..44ddc2515c 100644
--- a/libs/core/langchain_core/messages/block_translators/__init__.py
+++ b/libs/core/langchain_core/messages/block_translators/__init__.py
@@ -12,10 +12,11 @@ the implementation in `BaseMessage`.
from __future__ import annotations
-from collections.abc import Callable
from typing import TYPE_CHECKING
if TYPE_CHECKING:
+ from collections.abc import Callable
+
from langchain_core.messages import AIMessage, AIMessageChunk
from langchain_core.messages import content as types
diff --git a/libs/core/langchain_core/messages/block_translators/openai.py b/libs/core/langchain_core/messages/block_translators/openai.py
index f70c15feca..1bc4b3f64f 100644
--- a/libs/core/langchain_core/messages/block_translators/openai.py
+++ b/libs/core/langchain_core/messages/block_translators/openai.py
@@ -4,7 +4,6 @@ from __future__ import annotations
import json
import warnings
-from collections.abc import Iterable
from typing import TYPE_CHECKING, Any, Literal, cast
from langchain_core.language_models._utils import (
@@ -14,6 +13,8 @@ from langchain_core.language_models._utils import (
from langchain_core.messages import content as types
if TYPE_CHECKING:
+ from collections.abc import Iterable
+
from langchain_core.messages import AIMessage, AIMessageChunk
diff --git a/libs/core/langchain_core/outputs/chat_generation.py b/libs/core/langchain_core/outputs/chat_generation.py
index 209f08937a..96605d939e 100644
--- a/libs/core/langchain_core/outputs/chat_generation.py
+++ b/libs/core/langchain_core/outputs/chat_generation.py
@@ -2,15 +2,17 @@
from __future__ import annotations
-from typing import Literal
+from typing import TYPE_CHECKING, Literal
from pydantic import model_validator
-from typing_extensions import Self
from langchain_core.messages import BaseMessage, BaseMessageChunk
from langchain_core.outputs.generation import Generation
from langchain_core.utils._merge import merge_dicts
+if TYPE_CHECKING:
+ from typing_extensions import Self
+
class ChatGeneration(Generation):
"""A single chat generation output.
diff --git a/libs/core/langchain_core/prompts/base.py b/libs/core/langchain_core/prompts/base.py
index f4cd86fb5c..947550f587 100644
--- a/libs/core/langchain_core/prompts/base.py
+++ b/libs/core/langchain_core/prompts/base.py
@@ -6,7 +6,7 @@ import contextlib
import json
import typing
from abc import ABC, abstractmethod
-from collections.abc import Callable, Mapping
+from collections.abc import Mapping
from functools import cached_property
from pathlib import Path
from typing import (
@@ -33,6 +33,8 @@ from langchain_core.runnables.config import ensure_config
from langchain_core.utils.pydantic import create_model_v2
if TYPE_CHECKING:
+ from collections.abc import Callable
+
from langchain_core.documents import Document
diff --git a/libs/core/langchain_core/prompts/message.py b/libs/core/langchain_core/prompts/message.py
index bf52af4959..fb7dd88b5c 100644
--- a/libs/core/langchain_core/prompts/message.py
+++ b/libs/core/langchain_core/prompts/message.py
@@ -6,10 +6,10 @@ from abc import ABC, abstractmethod
from typing import TYPE_CHECKING, Any
from langchain_core.load import Serializable
-from langchain_core.messages import BaseMessage
from langchain_core.utils.interactive_env import is_interactive_env
if TYPE_CHECKING:
+ from langchain_core.messages import BaseMessage
from langchain_core.prompts.chat import ChatPromptTemplate
diff --git a/libs/core/langchain_core/prompts/string.py b/libs/core/langchain_core/prompts/string.py
index c93615fdb3..ee4835b1bf 100644
--- a/libs/core/langchain_core/prompts/string.py
+++ b/libs/core/langchain_core/prompts/string.py
@@ -4,9 +4,8 @@ from __future__ import annotations
import warnings
from abc import ABC
-from collections.abc import Callable, Sequence
from string import Formatter
-from typing import Any, Literal
+from typing import TYPE_CHECKING, Any, Literal
from pydantic import BaseModel, create_model
@@ -16,6 +15,9 @@ from langchain_core.utils import get_colored_text, mustache
from langchain_core.utils.formatting import formatter
from langchain_core.utils.interactive_env import is_interactive_env
+if TYPE_CHECKING:
+ from collections.abc import Callable, Sequence
+
try:
from jinja2 import Environment, meta
from jinja2.sandbox import SandboxedEnvironment
diff --git a/libs/core/langchain_core/runnables/graph.py b/libs/core/langchain_core/runnables/graph.py
index 76f1cc1f5b..3e1aa1cc42 100644
--- a/libs/core/langchain_core/runnables/graph.py
+++ b/libs/core/langchain_core/runnables/graph.py
@@ -4,7 +4,6 @@ from __future__ import annotations
import inspect
from collections import defaultdict
-from collections.abc import Callable
from dataclasses import dataclass, field
from enum import Enum
from typing import (
@@ -22,7 +21,7 @@ from langchain_core.runnables.base import Runnable, RunnableSerializable
from langchain_core.utils.pydantic import _IgnoreUnserializable, is_basemodel_subclass
if TYPE_CHECKING:
- from collections.abc import Sequence
+ from collections.abc import Callable, Sequence
from pydantic import BaseModel
diff --git a/libs/core/langchain_core/runnables/graph_ascii.py b/libs/core/langchain_core/runnables/graph_ascii.py
index b7d6edf39b..05692b857c 100644
--- a/libs/core/langchain_core/runnables/graph_ascii.py
+++ b/libs/core/langchain_core/runnables/graph_ascii.py
@@ -7,7 +7,6 @@ from __future__ import annotations
import math
import os
-from collections.abc import Mapping, Sequence
from typing import TYPE_CHECKING, Any
try:
@@ -20,6 +19,8 @@ except ImportError:
_HAS_GRANDALF = False
if TYPE_CHECKING:
+ from collections.abc import Mapping, Sequence
+
from langchain_core.runnables.graph import Edge as LangEdge
diff --git a/libs/core/langchain_core/runnables/utils.py b/libs/core/langchain_core/runnables/utils.py
index 4860e70bc2..2c013f6123 100644
--- a/libs/core/langchain_core/runnables/utils.py
+++ b/libs/core/langchain_core/runnables/utils.py
@@ -7,8 +7,7 @@ import asyncio
import inspect
import sys
import textwrap
-from collections.abc import Callable, Mapping, Sequence
-from contextvars import Context
+from collections.abc import Mapping, Sequence
from functools import lru_cache
from inspect import signature
from itertools import groupby
@@ -31,9 +30,11 @@ if TYPE_CHECKING:
AsyncIterable,
AsyncIterator,
Awaitable,
+ Callable,
Coroutine,
Iterable,
)
+ from contextvars import Context
from langchain_core.runnables.schema import StreamEvent
diff --git a/libs/core/langchain_core/tracers/core.py b/libs/core/langchain_core/tracers/core.py
index e027d78a32..97a2092d15 100644
--- a/libs/core/langchain_core/tracers/core.py
+++ b/libs/core/langchain_core/tracers/core.py
@@ -15,12 +15,6 @@ from typing import (
from langchain_core.exceptions import TracerException
from langchain_core.load import dumpd
-from langchain_core.outputs import (
- ChatGeneration,
- ChatGenerationChunk,
- GenerationChunk,
- LLMResult,
-)
from langchain_core.tracers.schemas import Run
if TYPE_CHECKING:
@@ -31,6 +25,12 @@ if TYPE_CHECKING:
from langchain_core.documents import Document
from langchain_core.messages import BaseMessage
+ from langchain_core.outputs import (
+ ChatGeneration,
+ ChatGenerationChunk,
+ GenerationChunk,
+ LLMResult,
+ )
logger = logging.getLogger(__name__)
diff --git a/libs/core/langchain_core/utils/function_calling.py b/libs/core/langchain_core/utils/function_calling.py
index f96b3ee1a9..6fe3e35a61 100644
--- a/libs/core/langchain_core/utils/function_calling.py
+++ b/libs/core/langchain_core/utils/function_calling.py
@@ -8,7 +8,6 @@ import logging
import types
import typing
import uuid
-from collections.abc import Callable
from typing import (
TYPE_CHECKING,
Annotated,
@@ -33,6 +32,8 @@ from langchain_core.utils.json_schema import dereference_refs
from langchain_core.utils.pydantic import is_basemodel_subclass
if TYPE_CHECKING:
+ from collections.abc import Callable
+
from langchain_core.tools import BaseTool
logger = logging.getLogger(__name__)
diff --git a/libs/core/langchain_core/utils/json.py b/libs/core/langchain_core/utils/json.py
index 9c00b11f94..0d5907b4d6 100644
--- a/libs/core/langchain_core/utils/json.py
+++ b/libs/core/langchain_core/utils/json.py
@@ -4,11 +4,13 @@ from __future__ import annotations
import json
import re
-from collections.abc import Callable
-from typing import Any
+from typing import TYPE_CHECKING, Any
from langchain_core.exceptions import OutputParserException
+if TYPE_CHECKING:
+ from collections.abc import Callable
+
def _replace_new_line(match: re.Match[str]) -> str:
value = match.group(2)
diff --git a/libs/core/langchain_core/utils/pydantic.py b/libs/core/langchain_core/utils/pydantic.py
index fd3413e715..514a3f8fc4 100644
--- a/libs/core/langchain_core/utils/pydantic.py
+++ b/libs/core/langchain_core/utils/pydantic.py
@@ -5,7 +5,6 @@ from __future__ import annotations
import inspect
import textwrap
import warnings
-from collections.abc import Callable
from contextlib import nullcontext
from functools import lru_cache, wraps
from types import GenericAlias
@@ -41,10 +40,12 @@ from pydantic.json_schema import (
)
from pydantic.v1 import BaseModel as BaseModelV1
from pydantic.v1 import create_model as create_model_v1
-from pydantic.v1.fields import ModelField
from typing_extensions import deprecated, override
if TYPE_CHECKING:
+ from collections.abc import Callable
+
+ from pydantic.v1.fields import ModelField
from pydantic_core import core_schema
PYDANTIC_VERSION = version.parse(pydantic.__version__)
diff --git a/libs/core/langchain_core/vectorstores/base.py b/libs/core/langchain_core/vectorstores/base.py
index 3580f5e9cd..1f7f73e709 100644
--- a/libs/core/langchain_core/vectorstores/base.py
+++ b/libs/core/langchain_core/vectorstores/base.py
@@ -11,7 +11,6 @@ import logging
import math
import warnings
from abc import ABC, abstractmethod
-from collections.abc import Callable
from itertools import cycle
from typing import (
TYPE_CHECKING,
@@ -29,7 +28,7 @@ from langchain_core.retrievers import BaseRetriever, LangSmithRetrieverParams
from langchain_core.runnables.config import run_in_executor
if TYPE_CHECKING:
- from collections.abc import Collection, Iterable, Iterator, Sequence
+ from collections.abc import Callable, Collection, Iterable, Iterator, Sequence
from langchain_core.callbacks.manager import (
AsyncCallbackManagerForRetrieverRun,
diff --git a/libs/core/langchain_core/vectorstores/in_memory.py b/libs/core/langchain_core/vectorstores/in_memory.py
index cb8a9b1985..919cd6a377 100644
--- a/libs/core/langchain_core/vectorstores/in_memory.py
+++ b/libs/core/langchain_core/vectorstores/in_memory.py
@@ -4,7 +4,6 @@ from __future__ import annotations
import json
import uuid
-from collections.abc import Callable
from pathlib import Path
from typing import (
TYPE_CHECKING,
@@ -20,7 +19,7 @@ from langchain_core.vectorstores.utils import _cosine_similarity as cosine_simil
from langchain_core.vectorstores.utils import maximal_marginal_relevance
if TYPE_CHECKING:
- from collections.abc import Iterator, Sequence
+ from collections.abc import Callable, Iterator, Sequence
from langchain_core.embeddings import Embeddings
diff --git a/libs/core/tests/unit_tests/runnables/test_concurrency.py b/libs/core/tests/unit_tests/runnables/test_concurrency.py
index 60022b803d..72196881d2 100644
--- a/libs/core/tests/unit_tests/runnables/test_concurrency.py
+++ b/libs/core/tests/unit_tests/runnables/test_concurrency.py
@@ -3,12 +3,14 @@
import asyncio
import time
from threading import Lock
-from typing import Any
+from typing import TYPE_CHECKING, Any
import pytest
from langchain_core.runnables import RunnableConfig, RunnableLambda
-from langchain_core.runnables.base import Runnable
+
+if TYPE_CHECKING:
+ from langchain_core.runnables.base import Runnable
@pytest.mark.asyncio
diff --git a/libs/core/tests/unit_tests/runnables/test_tracing_interops.py b/libs/core/tests/unit_tests/runnables/test_tracing_interops.py
index e5638b3e8e..4fb9ab3cad 100644
--- a/libs/core/tests/unit_tests/runnables/test_tracing_interops.py
+++ b/libs/core/tests/unit_tests/runnables/test_tracing_interops.py
@@ -3,21 +3,25 @@ from __future__ import annotations
import json
import sys
import uuid
-from collections.abc import AsyncGenerator, Callable, Coroutine, Generator
from inspect import isasyncgenfunction
-from typing import Any, Literal
+from typing import TYPE_CHECKING, Any, Literal
from unittest.mock import MagicMock, patch
import pytest
from langsmith import Client, get_current_run_tree, traceable
from langsmith.run_helpers import tracing_context
-from langsmith.run_trees import RunTree
from langsmith.utils import get_env_var
-from langchain_core.callbacks import BaseCallbackHandler
from langchain_core.runnables.base import RunnableLambda, RunnableParallel
from langchain_core.tracers.langchain import LangChainTracer
+if TYPE_CHECKING:
+ from collections.abc import AsyncGenerator, Callable, Coroutine, Generator
+
+ from langsmith.run_trees import RunTree
+
+ from langchain_core.callbacks import BaseCallbackHandler
+
def _get_posts(client: Client) -> list:
mock_calls = client.session.request.mock_calls # type: ignore[attr-defined]
diff --git a/libs/core/tests/unit_tests/utils/test_utils.py b/libs/core/tests/unit_tests/utils/test_utils.py
index f70063c421..c492980047 100644
--- a/libs/core/tests/unit_tests/utils/test_utils.py
+++ b/libs/core/tests/unit_tests/utils/test_utils.py
@@ -1,10 +1,9 @@
import os
import re
import sys
-from collections.abc import Callable
from contextlib import AbstractContextManager, nullcontext
from copy import deepcopy
-from typing import Any
+from typing import TYPE_CHECKING, Any
from unittest.mock import patch
import pytest
@@ -23,6 +22,9 @@ from langchain_core.utils import (
from langchain_core.utils._merge import merge_dicts
from langchain_core.utils.utils import secret_from_env
+if TYPE_CHECKING:
+ from collections.abc import Callable
+
@pytest.mark.parametrize(
("package", "check_kwargs", "actual_version", "expected"),