Skip to content

The agent engineering platform.

chore(langchain_v1): rename `model_request` node -> `model` (#33310)

Sydney Runkle2fa9741f9989
diff --git a/libs/langchain_v1/langchain/agents/factory.py b/libs/langchain_v1/langchain/agents/factory.py
index bb99309030..89cc01c077 100644
--- a/libs/langchain_v1/langchain/agents/factory.py
+++ b/libs/langchain_v1/langchain/agents/factory.py
@@ -219,7 +219,7 @@ def create_agent( # noqa: PLR0915
model: The language model for the agent. Can be a string identifier
(e.g., ``"openai:gpt-4"``), a chat model instance (e.g., ``ChatOpenAI()``).
tools: A list of tools, dicts, or callables. If ``None`` or an empty list,
- the agent will consist of a model_request node without a tool calling loop.
+ the agent will consist of a model node without a tool calling loop.
system_prompt: An optional system prompt for the LLM. If provided as a string,
it will be converted to a SystemMessage and added to the beginning
of the message list.
@@ -608,7 +608,7 @@ def create_agent( # noqa: PLR0915
)
return request.model.bind(**request.model_settings), None
- def model_request(state: AgentState, runtime: Runtime[ContextT]) -> dict[str, Any]:
+ def model_node(state: AgentState, runtime: Runtime[ContextT]) -> dict[str, Any]:
"""Sync model request handler with sequential middleware processing."""
request = ModelRequest(
model=model,
@@ -674,7 +674,7 @@ def create_agent( # noqa: PLR0915
msg = f"Maximum retry attempts ({max_attempts}) exceeded"
raise RuntimeError(msg)
- async def amodel_request(state: AgentState, runtime: Runtime[ContextT]) -> dict[str, Any]:
+ async def amodel_node(state: AgentState, runtime: Runtime[ContextT]) -> dict[str, Any]:
"""Async model request handler with sequential middleware processing."""
request = ModelRequest(
model=model,
@@ -724,7 +724,7 @@ def create_agent( # noqa: PLR0915
raise RuntimeError(msg)
# Use sync or async based on model capabilities
- graph.add_node("model_request", RunnableCallable(model_request, amodel_request, trace=False))
+ graph.add_node("model", RunnableCallable(model_node, amodel_node, trace=False))
# Only add tools node if we have tools
if tool_node is not None:
@@ -808,27 +808,27 @@ def create_agent( # noqa: PLR0915
after_agent_node = RunnableCallable(sync_after_agent, async_after_agent, trace=False)
graph.add_node(f"{m.name}.after_agent", after_agent_node, input_schema=state_schema)
- # Determine the entry node (runs once at start): before_agent -> before_model -> model_request
+ # Determine the entry node (runs once at start): before_agent -> before_model -> model
if middleware_w_before_agent:
entry_node = f"{middleware_w_before_agent[0].name}.before_agent"
elif middleware_w_before_model:
entry_node = f"{middleware_w_before_model[0].name}.before_model"
else:
- entry_node = "model_request"
+ entry_node = "model"
# Determine the loop entry node (beginning of agent loop, excludes before_agent)
# This is where tools will loop back to for the next iteration
if middleware_w_before_model:
loop_entry_node = f"{middleware_w_before_model[0].name}.before_model"
else:
- loop_entry_node = "model_request"
+ loop_entry_node = "model"
# Determine the loop exit node (end of each iteration, can run multiple times)
- # This is after_model or model_request, but NOT after_agent
+ # This is after_model or model, but NOT after_agent
if middleware_w_after_model:
loop_exit_node = f"{middleware_w_after_model[0].name}.after_model"
else:
- loop_exit_node = "model_request"
+ loop_exit_node = "model"
# Determine the exit node (runs once at end): after_agent or END
if middleware_w_after_agent:
@@ -860,7 +860,7 @@ def create_agent( # noqa: PLR0915
_make_model_to_model_edge(loop_entry_node, exit_node),
[loop_entry_node, exit_node],
)
- elif loop_exit_node == "model_request":
+ elif loop_exit_node == "model":
# If no tools and no after_model, go directly to exit_node
graph.add_edge(loop_exit_node, exit_node)
# No tools but we have after_model - connect after_model to exit_node
@@ -883,7 +883,7 @@ def create_agent( # noqa: PLR0915
loop_entry_node,
can_jump_to=_get_can_jump_to(m1, "before_agent"),
)
- # Connect last before_agent to loop_entry_node (before_model or model_request)
+ # Connect last before_agent to loop_entry_node (before_model or model)
_add_middleware_edge(
graph,
f"{middleware_w_before_agent[-1].name}.before_agent",
@@ -902,18 +902,18 @@ def create_agent( # noqa: PLR0915
loop_entry_node,
can_jump_to=_get_can_jump_to(m1, "before_model"),
)
- # Go directly to model_request after the last before_model
+ # Go directly to model after the last before_model
_add_middleware_edge(
graph,
f"{middleware_w_before_model[-1].name}.before_model",
- "model_request",
+ "model",
loop_entry_node,
can_jump_to=_get_can_jump_to(middleware_w_before_model[-1], "before_model"),
)
# Add after_model middleware edges
if middleware_w_after_model:
- graph.add_edge("model_request", f"{middleware_w_after_model[-1].name}.after_model")
+ graph.add_edge("model", f"{middleware_w_after_model[-1].name}.after_model")
for idx in range(len(middleware_w_after_model) - 1, 0, -1):
m1 = middleware_w_after_model[idx]
m2 = middleware_w_after_model[idx - 1]
diff --git a/libs/langchain_v1/tests/unit_tests/agents/__snapshots__/test_middleware_agent.ambr b/libs/langchain_v1/tests/unit_tests/agents/__snapshots__/test_middleware_agent.ambr
index 2581a1ea07..0538c79b40 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/__snapshots__/test_middleware_agent.ambr
+++ b/libs/langchain_v1/tests/unit_tests/agents/__snapshots__/test_middleware_agent.ambr
@@ -8,10 +8,10 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
__end__([<p>__end__</p>]):::last
- __start__ --> model_request;
- model_request --> __end__;
+ __start__ --> model;
+ model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
classDef last fill:#bfb6fc
@@ -27,12 +27,12 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopOne\2ebefore_model(NoopOne.before_model)
__end__([<p>__end__</p>]):::last
- NoopOne\2ebefore_model --> model_request;
+ NoopOne\2ebefore_model --> model;
__start__ --> NoopOne\2ebefore_model;
- model_request --> __end__;
+ model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
classDef last fill:#bfb6fc
@@ -48,13 +48,13 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopTen\2ebefore_model(NoopTen.before_model)
NoopTen\2eafter_model(NoopTen.after_model)
__end__([<p>__end__</p>]):::last
- NoopTen\2ebefore_model --> model_request;
+ NoopTen\2ebefore_model --> model;
__start__ --> NoopTen\2ebefore_model;
- model_request --> NoopTen\2eafter_model;
+ model --> NoopTen\2eafter_model;
NoopTen\2eafter_model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
@@ -71,17 +71,17 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopTen\2ebefore_model(NoopTen.before_model)
NoopTen\2eafter_model(NoopTen.after_model)
NoopEleven\2ebefore_model(NoopEleven.before_model)
NoopEleven\2eafter_model(NoopEleven.after_model)
__end__([<p>__end__</p>]):::last
NoopEleven\2eafter_model --> NoopTen\2eafter_model;
- NoopEleven\2ebefore_model --> model_request;
+ NoopEleven\2ebefore_model --> model;
NoopTen\2ebefore_model --> NoopEleven\2ebefore_model;
__start__ --> NoopTen\2ebefore_model;
- model_request --> NoopEleven\2eafter_model;
+ model --> NoopEleven\2eafter_model;
NoopTen\2eafter_model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
@@ -98,14 +98,14 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopOne\2ebefore_model(NoopOne.before_model)
NoopTwo\2ebefore_model(NoopTwo.before_model)
__end__([<p>__end__</p>]):::last
NoopOne\2ebefore_model --> NoopTwo\2ebefore_model;
- NoopTwo\2ebefore_model --> model_request;
+ NoopTwo\2ebefore_model --> model;
__start__ --> NoopOne\2ebefore_model;
- model_request --> __end__;
+ model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
classDef last fill:#bfb6fc
@@ -121,16 +121,16 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopOne\2ebefore_model(NoopOne.before_model)
NoopTwo\2ebefore_model(NoopTwo.before_model)
NoopThree\2ebefore_model(NoopThree.before_model)
__end__([<p>__end__</p>]):::last
NoopOne\2ebefore_model --> NoopTwo\2ebefore_model;
- NoopThree\2ebefore_model --> model_request;
+ NoopThree\2ebefore_model --> model;
NoopTwo\2ebefore_model --> NoopThree\2ebefore_model;
__start__ --> NoopOne\2ebefore_model;
- model_request --> __end__;
+ model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
classDef last fill:#bfb6fc
@@ -146,11 +146,11 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopFour\2eafter_model(NoopFour.after_model)
__end__([<p>__end__</p>]):::last
- __start__ --> model_request;
- model_request --> NoopFour\2eafter_model;
+ __start__ --> model;
+ model --> NoopFour\2eafter_model;
NoopFour\2eafter_model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
@@ -167,13 +167,13 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopFour\2eafter_model(NoopFour.after_model)
NoopFive\2eafter_model(NoopFive.after_model)
__end__([<p>__end__</p>]):::last
NoopFive\2eafter_model --> NoopFour\2eafter_model;
- __start__ --> model_request;
- model_request --> NoopFive\2eafter_model;
+ __start__ --> model;
+ model --> NoopFive\2eafter_model;
NoopFour\2eafter_model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
@@ -190,15 +190,15 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopFour\2eafter_model(NoopFour.after_model)
NoopFive\2eafter_model(NoopFive.after_model)
NoopSix\2eafter_model(NoopSix.after_model)
__end__([<p>__end__</p>]):::last
NoopFive\2eafter_model --> NoopFour\2eafter_model;
NoopSix\2eafter_model --> NoopFive\2eafter_model;
- __start__ --> model_request;
- model_request --> NoopSix\2eafter_model;
+ __start__ --> model;
+ model --> NoopSix\2eafter_model;
NoopFour\2eafter_model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
@@ -215,13 +215,13 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopSeven\2ebefore_model(NoopSeven.before_model)
NoopSeven\2eafter_model(NoopSeven.after_model)
__end__([<p>__end__</p>]):::last
- NoopSeven\2ebefore_model --> model_request;
+ NoopSeven\2ebefore_model --> model;
__start__ --> NoopSeven\2ebefore_model;
- model_request --> NoopSeven\2eafter_model;
+ model --> NoopSeven\2eafter_model;
NoopSeven\2eafter_model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
@@ -238,17 +238,17 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopSeven\2ebefore_model(NoopSeven.before_model)
NoopSeven\2eafter_model(NoopSeven.after_model)
NoopEight\2ebefore_model(NoopEight.before_model)
NoopEight\2eafter_model(NoopEight.after_model)
__end__([<p>__end__</p>]):::last
NoopEight\2eafter_model --> NoopSeven\2eafter_model;
- NoopEight\2ebefore_model --> model_request;
+ NoopEight\2ebefore_model --> model;
NoopSeven\2ebefore_model --> NoopEight\2ebefore_model;
__start__ --> NoopSeven\2ebefore_model;
- model_request --> NoopEight\2eafter_model;
+ model --> NoopEight\2eafter_model;
NoopSeven\2eafter_model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
@@ -265,7 +265,7 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
NoopSeven\2ebefore_model(NoopSeven.before_model)
NoopSeven\2eafter_model(NoopSeven.after_model)
NoopEight\2ebefore_model(NoopEight.before_model)
@@ -276,10 +276,10 @@
NoopEight\2eafter_model --> NoopSeven\2eafter_model;
NoopEight\2ebefore_model --> NoopNine\2ebefore_model;
NoopNine\2eafter_model --> NoopEight\2eafter_model;
- NoopNine\2ebefore_model --> model_request;
+ NoopNine\2ebefore_model --> model;
NoopSeven\2ebefore_model --> NoopEight\2ebefore_model;
__start__ --> NoopSeven\2ebefore_model;
- model_request --> NoopNine\2eafter_model;
+ model --> NoopNine\2eafter_model;
NoopSeven\2eafter_model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
@@ -296,7 +296,7 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
tools(tools)
NoopSeven\2ebefore_model(NoopSeven.before_model)
NoopSeven\2eafter_model(NoopSeven.after_model)
@@ -305,13 +305,13 @@
__end__([<p>__end__</p>]):::last
NoopEight\2eafter_model --> NoopSeven\2eafter_model;
NoopEight\2ebefore_model -.-> __end__;
- NoopEight\2ebefore_model -.-> model_request;
+ NoopEight\2ebefore_model -.-> model;
NoopSeven\2eafter_model -.-> NoopSeven\2ebefore_model;
NoopSeven\2eafter_model -.-> __end__;
NoopSeven\2eafter_model -.-> tools;
NoopSeven\2ebefore_model --> NoopEight\2ebefore_model;
__start__ --> NoopSeven\2ebefore_model;
- model_request --> NoopEight\2eafter_model;
+ model --> NoopEight\2eafter_model;
tools -.-> NoopSeven\2ebefore_model;
tools -.-> __end__;
classDef default fill:#f2f0ff,line-height:1.2
@@ -329,7 +329,7 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
tools(tools)
NoopSeven\2ebefore_model(NoopSeven.before_model)
NoopSeven\2eafter_model(NoopSeven.after_model)
@@ -338,13 +338,13 @@
__end__([<p>__end__</p>]):::last
NoopEight\2eafter_model --> NoopSeven\2eafter_model;
NoopEight\2ebefore_model -.-> __end__;
- NoopEight\2ebefore_model -.-> model_request;
+ NoopEight\2ebefore_model -.-> model;
NoopSeven\2eafter_model -.-> NoopSeven\2ebefore_model;
NoopSeven\2eafter_model -.-> __end__;
NoopSeven\2eafter_model -.-> tools;
NoopSeven\2ebefore_model --> NoopEight\2ebefore_model;
__start__ --> NoopSeven\2ebefore_model;
- model_request --> NoopEight\2eafter_model;
+ model --> NoopEight\2eafter_model;
tools -.-> NoopSeven\2ebefore_model;
tools -.-> __end__;
classDef default fill:#f2f0ff,line-height:1.2
@@ -362,7 +362,7 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
tools(tools)
NoopSeven\2ebefore_model(NoopSeven.before_model)
NoopSeven\2eafter_model(NoopSeven.after_model)
@@ -371,13 +371,13 @@
__end__([<p>__end__</p>]):::last
NoopEight\2eafter_model --> NoopSeven\2eafter_model;
NoopEight\2ebefore_model -.-> __end__;
- NoopEight\2ebefore_model -.-> model_request;
+ NoopEight\2ebefore_model -.-> model;
NoopSeven\2eafter_model -.-> NoopSeven\2ebefore_model;
NoopSeven\2eafter_model -.-> __end__;
NoopSeven\2eafter_model -.-> tools;
NoopSeven\2ebefore_model --> NoopEight\2ebefore_model;
__start__ --> NoopSeven\2ebefore_model;
- model_request --> NoopEight\2eafter_model;
+ model --> NoopEight\2eafter_model;
tools -.-> NoopSeven\2ebefore_model;
tools -.-> __end__;
classDef default fill:#f2f0ff,line-height:1.2
@@ -395,7 +395,7 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
tools(tools)
NoopSeven\2ebefore_model(NoopSeven.before_model)
NoopSeven\2eafter_model(NoopSeven.after_model)
@@ -404,13 +404,13 @@
__end__([<p>__end__</p>]):::last
NoopEight\2eafter_model --> NoopSeven\2eafter_model;
NoopEight\2ebefore_model -.-> __end__;
- NoopEight\2ebefore_model -.-> model_request;
+ NoopEight\2ebefore_model -.-> model;
NoopSeven\2eafter_model -.-> NoopSeven\2ebefore_model;
NoopSeven\2eafter_model -.-> __end__;
NoopSeven\2eafter_model -.-> tools;
NoopSeven\2ebefore_model --> NoopEight\2ebefore_model;
__start__ --> NoopSeven\2ebefore_model;
- model_request --> NoopEight\2eafter_model;
+ model --> NoopEight\2eafter_model;
tools -.-> NoopSeven\2ebefore_model;
tools -.-> __end__;
classDef default fill:#f2f0ff,line-height:1.2
@@ -428,7 +428,7 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
tools(tools)
NoopSeven\2ebefore_model(NoopSeven.before_model)
NoopSeven\2eafter_model(NoopSeven.after_model)
@@ -437,13 +437,13 @@
__end__([<p>__end__</p>]):::last
NoopEight\2eafter_model --> NoopSeven\2eafter_model;
NoopEight\2ebefore_model -.-> __end__;
- NoopEight\2ebefore_model -.-> model_request;
+ NoopEight\2ebefore_model -.-> model;
NoopSeven\2eafter_model -.-> NoopSeven\2ebefore_model;
NoopSeven\2eafter_model -.-> __end__;
NoopSeven\2eafter_model -.-> tools;
NoopSeven\2ebefore_model --> NoopEight\2ebefore_model;
__start__ --> NoopSeven\2ebefore_model;
- model_request --> NoopEight\2eafter_model;
+ model --> NoopEight\2eafter_model;
tools -.-> NoopSeven\2ebefore_model;
tools -.-> __end__;
classDef default fill:#f2f0ff,line-height:1.2
diff --git a/libs/langchain_v1/tests/unit_tests/agents/__snapshots__/test_middleware_decorators.ambr b/libs/langchain_v1/tests/unit_tests/agents/__snapshots__/test_middleware_decorators.ambr
index efdd8216a6..4da1944b9a 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/__snapshots__/test_middleware_decorators.ambr
+++ b/libs/langchain_v1/tests/unit_tests/agents/__snapshots__/test_middleware_decorators.ambr
@@ -8,13 +8,13 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
async_before_with_jump\2ebefore_model(async_before_with_jump.before_model)
__end__([<p>__end__</p>]):::last
__start__ --> async_before_with_jump\2ebefore_model;
async_before_with_jump\2ebefore_model -.-> __end__;
- async_before_with_jump\2ebefore_model -.-> model_request;
- model_request --> __end__;
+ async_before_with_jump\2ebefore_model -.-> model;
+ model --> __end__;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
classDef last fill:#bfb6fc
@@ -30,13 +30,13 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
async_after_with_jump\2eafter_model(async_after_with_jump.after_model)
__end__([<p>__end__</p>]):::last
- __start__ --> model_request;
+ __start__ --> model;
async_after_with_jump\2eafter_model -.-> __end__;
- async_after_with_jump\2eafter_model -.-> model_request;
- model_request --> async_after_with_jump\2eafter_model;
+ async_after_with_jump\2eafter_model -.-> model;
+ model --> async_after_with_jump\2eafter_model;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
classDef last fill:#bfb6fc
@@ -52,7 +52,7 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
async_before_early_exit\2ebefore_model(async_before_early_exit.before_model)
async_after_retry\2eafter_model(async_after_retry.after_model)
__end__([<p>__end__</p>]):::last
@@ -60,8 +60,8 @@
async_after_retry\2eafter_model -.-> __end__;
async_after_retry\2eafter_model -.-> async_before_early_exit\2ebefore_model;
async_before_early_exit\2ebefore_model -.-> __end__;
- async_before_early_exit\2ebefore_model -.-> model_request;
- model_request --> async_after_retry\2eafter_model;
+ async_before_early_exit\2ebefore_model -.-> model;
+ model --> async_after_retry\2eafter_model;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
classDef last fill:#bfb6fc
@@ -77,16 +77,16 @@
---
graph TD;
__start__([<p>__start__</p>]):::first
- model_request(model_request)
+ model(model)
sync_before_with_jump\2ebefore_model(sync_before_with_jump.before_model)
async_after_with_jumps\2eafter_model(async_after_with_jumps.after_model)
__end__([<p>__end__</p>]):::last
__start__ --> sync_before_with_jump\2ebefore_model;
async_after_with_jumps\2eafter_model -.-> __end__;
async_after_with_jumps\2eafter_model -.-> sync_before_with_jump\2ebefore_model;
- model_request --> async_after_with_jumps\2eafter_model;
+ model --> async_after_with_jumps\2eafter_model;
sync_before_with_jump\2ebefore_model -.-> __end__;
- sync_before_with_jump\2ebefore_model -.-> model_request;
+ sync_before_with_jump\2ebefore_model -.-> model;
classDef default fill:#f2f0ff,line-height:1.2
classDef first fill-opacity:0
classDef last fill:#bfb6fc