The agent engineering platform.
Python agentsaiai-agentsanthropicchatgptdeepagentsenterpriseframeworkgeminigenerative-ailangchainlanggraphllmmultiagentopen-sourceopenaipydanticpythonragtypescript
fix(core): accept int temperature in _get_ls_params for LangSmith tracing (#35302)
Shivangi Sharma3686bcbd966f
diff --git a/libs/core/langchain_core/language_models/chat_models.py b/libs/core/langchain_core/language_models/chat_models.pyindex 7e11c491d6..32f198532e 100644--- a/libs/core/langchain_core/language_models/chat_models.py+++ b/libs/core/langchain_core/language_models/chat_models.py@@ -812,9 +812,11 @@ class BaseChatModel(BaseLanguageModel[AIMessage], ABC):ls_params["ls_model_name"] = self.model_name# temperature- if "temperature" in kwargs and isinstance(kwargs["temperature"], float):+ if "temperature" in kwargs and isinstance(kwargs["temperature"], (int, float)):ls_params["ls_temperature"] = kwargs["temperature"]- elif hasattr(self, "temperature") and isinstance(self.temperature, float):+ elif hasattr(self, "temperature") and isinstance(+ self.temperature, (int, float)+ ):ls_params["ls_temperature"] = self.temperature# max_tokensdiff --git a/libs/core/langchain_core/language_models/llms.py b/libs/core/langchain_core/language_models/llms.pyindex 5aa287ada8..fa034675d8 100644--- a/libs/core/langchain_core/language_models/llms.py+++ b/libs/core/langchain_core/language_models/llms.py@@ -351,9 +351,11 @@ class BaseLLM(BaseLanguageModel[str], ABC):ls_params["ls_model_name"] = self.model_name# temperature- if "temperature" in kwargs and isinstance(kwargs["temperature"], float):+ if "temperature" in kwargs and isinstance(kwargs["temperature"], (int, float)):ls_params["ls_temperature"] = kwargs["temperature"]- elif hasattr(self, "temperature") and isinstance(self.temperature, float):+ elif hasattr(self, "temperature") and isinstance(+ self.temperature, (int, float)+ ):ls_params["ls_temperature"] = self.temperature# max_tokensdiff --git a/libs/core/tests/unit_tests/language_models/chat_models/test_base.py b/libs/core/tests/unit_tests/language_models/chat_models/test_base.pyindex eedb5d393a..5686b1a5b5 100644--- a/libs/core/tests/unit_tests/language_models/chat_models/test_base.py+++ b/libs/core/tests/unit_tests/language_models/chat_models/test_base.py@@ -1206,6 +1206,13 @@ def test_get_ls_params() -> None:ls_params = llm._get_ls_params(temperature=0.2)assert ls_params["ls_temperature"] == 0.2+ # Test integer temperature values (regression test for issue #35300)+ ls_params = llm._get_ls_params(temperature=0)+ assert ls_params["ls_temperature"] == 0++ ls_params = llm._get_ls_params(temperature=1)+ assert ls_params["ls_temperature"] == 1+ls_params = llm._get_ls_params(max_tokens=2048)assert ls_params["ls_max_tokens"] == 2048diff --git a/libs/core/tests/unit_tests/language_models/llms/test_base.py b/libs/core/tests/unit_tests/language_models/llms/test_base.pyindex e5547a617a..7ca52e4339 100644--- a/libs/core/tests/unit_tests/language_models/llms/test_base.py+++ b/libs/core/tests/unit_tests/language_models/llms/test_base.py@@ -272,6 +272,13 @@ def test_get_ls_params() -> None:ls_params = llm._get_ls_params(temperature=0.2)assert ls_params["ls_temperature"] == 0.2+ # Test integer temperature values (regression test for issue #35300)+ ls_params = llm._get_ls_params(temperature=0)+ assert ls_params["ls_temperature"] == 0++ ls_params = llm._get_ls_params(temperature=1)+ assert ls_params["ls_temperature"] == 1+ls_params = llm._get_ls_params(max_tokens=2048)assert ls_params["ls_max_tokens"] == 2048