The agent engineering platform.
Python agentsaiai-agentsanthropicchatgptdeepagentsenterpriseframeworkgeminigenerative-ailangchainlanggraphllmmultiagentopen-sourceopenaipydanticpythonragtypescript
fix(core): make `removal` optional in `warn_deprecated` (#37056)
Mason Daugherty37be34be8288
diff --git a/libs/core/langchain_core/_api/deprecation.py b/libs/core/langchain_core/_api/deprecation.pyindex 0dfe09d7fa..16a540b860 100644--- a/libs/core/langchain_core/_api/deprecation.py+++ b/libs/core/langchain_core/_api/deprecation.py@@ -136,9 +136,8 @@ def deprecated(addendum: Additional text appended directly to the final message.removal: The expected removal version.- With the default (an empty string), a removal version is automatically- computed from since. Set to other Falsy values to not schedule a removal- date.+ With the default (an empty string), no removal version is shown in the+ warning message.Cannot be used together with pending.package: The package of the deprecated object.@@ -472,21 +471,13 @@ def warn_deprecated(addendum: Additional text appended directly to the final message.removal: The expected removal version.- With the default (an empty string), a removal version is automatically- computed from since. Set to other Falsy values to not schedule a removal- date.+ With the default (an empty string), no removal version is shown in the+ warning message.Cannot be used together with pending.package: The package of the deprecated object."""- if not pending:- if not removal:- removal = f"in {removal}" if removal else "within ?? minor releases"- msg = (- f"Need to determine which default deprecation schedule to use. "- f"{removal}"- )- raise NotImplementedError(msg)+ if not pending and removal:removal = f"in {removal}"if not message:diff --git a/libs/core/tests/unit_tests/_api/test_deprecation.py b/libs/core/tests/unit_tests/_api/test_deprecation.pyindex b1acff08a9..c3aac85420 100644--- a/libs/core/tests/unit_tests/_api/test_deprecation.py+++ b/libs/core/tests/unit_tests/_api/test_deprecation.py@@ -71,10 +71,16 @@ def test_warn_deprecated(kwargs: dict[str, Any], expected_message: str) -> None:assert str(warning) == expected_message-def test_undefined_deprecation_schedule() -> None:- """This test is expected to fail until we defined a deprecation schedule."""- with pytest.raises(NotImplementedError):- warn_deprecated("1.0.0", pending=False)+def test_warn_deprecated_without_removal() -> None:+ """`removal` is optional; warning omits the removal phrase when not provided."""+ with warnings.catch_warnings(record=True) as warning_list:+ warnings.simplefilter("always")+ warn_deprecated("1.0.0", name="SomeFunction", pending=False)++ assert len(warning_list) == 1+ message = str(warning_list[0].message)+ assert message == "`SomeFunction` was deprecated in LangChain 1.0.0"+ assert "will be removed" not in message@deprecated(since="2.0.0", removal="3.0.0", pending=False)