Skip to content

The agent engineering platform.

ollama: add pydocstyle linting for ollama (#27686)

JiaranI3952ee31b8fc
diff --git a/libs/partners/ollama/langchain_ollama/__init__.py b/libs/partners/ollama/langchain_ollama/__init__.py
index 4921503fa6..add2685a5b 100644
--- a/libs/partners/ollama/langchain_ollama/__init__.py
+++ b/libs/partners/ollama/langchain_ollama/__init__.py
@@ -1,3 +1,9 @@
+"""This is the langchain_ollama package.
+
+It provides infrastructure for interacting with the Ollama service.
+"""
+
+
from importlib import metadata
from langchain_ollama.chat_models import ChatOllama
diff --git a/libs/partners/ollama/langchain_ollama/chat_models.py b/libs/partners/ollama/langchain_ollama/chat_models.py
index f0db82b835..7f887280b0 100644
--- a/libs/partners/ollama/langchain_ollama/chat_models.py
+++ b/libs/partners/ollama/langchain_ollama/chat_models.py
@@ -90,7 +90,7 @@ def _lc_tool_call_to_openai_tool_call(tool_call: ToolCall) -> dict:
class ChatOllama(BaseChatModel):
- """Ollama chat model integration.
+ r"""Ollama chat model integration.
.. dropdown:: Setup
:open:
diff --git a/libs/partners/ollama/langchain_ollama/embeddings.py b/libs/partners/ollama/langchain_ollama/embeddings.py
index 6c5b812dc9..81dfd75b02 100644
--- a/libs/partners/ollama/langchain_ollama/embeddings.py
+++ b/libs/partners/ollama/langchain_ollama/embeddings.py
@@ -1,3 +1,4 @@
+"""Ollama embeddings models."""
from typing import (
List,
Optional,
diff --git a/libs/partners/ollama/pyproject.toml b/libs/partners/ollama/pyproject.toml
index 2bb8d9f718..6f66fbce29 100644
--- a/libs/partners/ollama/pyproject.toml
+++ b/libs/partners/ollama/pyproject.toml
@@ -24,7 +24,20 @@ ollama = ">=0.3.0,<1"
langchain-core = "^0.3.0"
[tool.ruff.lint]
-select = ["E", "F", "I", "T201"]
+select = [
+ "E", # pycodestyle
+ "F", # pyflakes
+ "I", # isort
+ "T201", # print
+ "D", # pydocstyle
+
+]
+
+[tool.ruff.lint.pydocstyle]
+convention = "google"
+
+[tool.ruff.lint.per-file-ignores]
+"tests/**" = ["D"] # ignore docstring checks for tests
[tool.coverage.run]
omit = ["tests/*"]
diff --git a/libs/partners/ollama/scripts/check_imports.py b/libs/partners/ollama/scripts/check_imports.py
index 58a460c149..acf6128ab9 100644
--- a/libs/partners/ollama/scripts/check_imports.py
+++ b/libs/partners/ollama/scripts/check_imports.py
@@ -1,3 +1,4 @@
+"""load multiple Python files specified as command line arguments."""
import sys
import traceback
from importlib.machinery import SourceFileLoader