Skip to content

The agent engineering platform.

fix(text-splitters): remove incorrect C# and Elixir separator keywords (#37037)

Dayna Blackwell3b9750f0a464
diff --git a/libs/text-splitters/langchain_text_splitters/character.py b/libs/text-splitters/langchain_text_splitters/character.py
index 469afdb913..dd2378a787 100644
--- a/libs/text-splitters/langchain_text_splitters/character.py
+++ b/libs/text-splitters/langchain_text_splitters/character.py
@@ -440,7 +440,6 @@ class RecursiveCharacterTextSplitter(TextSplitter):
# Split along control flow statements
"\nif ",
"\nunless ",
- "\nwhile ",
"\ncase ",
"\ncond ",
"\nwith ",
@@ -593,7 +592,6 @@ class RecursiveCharacterTextSplitter(TextSplitter):
return [
"\ninterface ",
"\nenum ",
- "\nimplements ",
"\ndelegate ",
"\nevent ",
# Split along class definitions
diff --git a/libs/text-splitters/tests/unit_tests/test_text_splitters.py b/libs/text-splitters/tests/unit_tests/test_text_splitters.py
index c7d7e2c480..cae9f16d10 100644
--- a/libs/text-splitters/tests/unit_tests/test_text_splitters.py
+++ b/libs/text-splitters/tests/unit_tests/test_text_splitters.py
@@ -1011,6 +1011,23 @@ class Program
]
+def test_csharp_separators_no_java_keywords() -> None:
+ """C# separators should not contain Java-only keywords."""
+ splitter = RecursiveCharacterTextSplitter.from_language(
+ Language.CSHARP, chunk_size=CHUNK_SIZE, chunk_overlap=0
+ )
+ # "implements" is a Java keyword; C# uses ":" for interface implementation
+ assert "\nimplements " not in splitter._separators
+
+
+def test_elixir_separators_no_while() -> None:
+ """Elixir has no while loop; the separator should not be present."""
+ splitter = RecursiveCharacterTextSplitter.from_language(
+ Language.ELIXIR, chunk_size=CHUNK_SIZE, chunk_overlap=0
+ )
+ assert "\nwhile " not in splitter._separators
+
+
def test_cpp_code_splitter() -> None:
splitter = RecursiveCharacterTextSplitter.from_language(
Language.CPP, chunk_size=CHUNK_SIZE, chunk_overlap=0