Skip to content

The agent engineering platform.

style(langchain): add TC ruff rules (#34496)

Christophe Bornet3d78cc69f1cd
diff --git a/libs/langchain_v1/langchain/agents/factory.py b/libs/langchain_v1/langchain/agents/factory.py
index 757519317b..dc25f35ce1 100644
--- a/libs/langchain_v1/langchain/agents/factory.py
+++ b/libs/langchain_v1/langchain/agents/factory.py
@@ -20,9 +20,7 @@ from langgraph._internal._runnable import RunnableCallable
from langgraph.constants import END, START
from langgraph.graph.state import StateGraph
from langgraph.prebuilt.tool_node import ToolCallWithContext, ToolNode
-from langgraph.runtime import Runtime
from langgraph.types import Command, Send
-from langgraph.typing import ContextT
from typing_extensions import NotRequired, Required, TypedDict
from langchain.agents.middleware.types import (
@@ -56,8 +54,10 @@ if TYPE_CHECKING:
from langchain_core.runnables import Runnable
from langgraph.cache.base import BaseCache
from langgraph.graph.state import CompiledStateGraph
+ from langgraph.runtime import Runtime
from langgraph.store.base import BaseStore
from langgraph.types import Checkpointer
+ from langgraph.typing import ContextT
from langchain.agents.middleware.types import ToolCallRequest, ToolCallWrapper
diff --git a/libs/langchain_v1/langchain/agents/middleware/types.py b/libs/langchain_v1/langchain/agents/middleware/types.py
index b1ec4320e4..ae2565f0ea 100644
--- a/libs/langchain_v1/langchain/agents/middleware/types.py
+++ b/libs/langchain_v1/langchain/agents/middleware/types.py
@@ -19,6 +19,8 @@ from typing import (
if TYPE_CHECKING:
from collections.abc import Awaitable
+ from langgraph.types import Command
+
# Needed as top level import for Pydantic schema generation on AgentState
import warnings
from typing import TypeAlias
@@ -33,7 +35,6 @@ from langchain_core.messages import (
from langgraph.channels.ephemeral_value import EphemeralValue
from langgraph.graph.message import add_messages
from langgraph.prebuilt.tool_node import ToolCallRequest, ToolCallWrapper
-from langgraph.types import Command
from langgraph.typing import ContextT
from typing_extensions import NotRequired, Required, TypedDict, TypeVar, Unpack
diff --git a/libs/langchain_v1/pyproject.toml b/libs/langchain_v1/pyproject.toml
index 8ef821f4f5..2eafe85ef2 100644
--- a/libs/langchain_v1/pyproject.toml
+++ b/libs/langchain_v1/pyproject.toml
@@ -114,9 +114,6 @@ ignore = [
"PERF203", # Rarely useful
"PLR09", # Too many something (arg, statements, etc)
"RUF012", # Doesn't play well with Pydantic
- "TC001", # Doesn't play well with Pydantic
- "TC002", # Doesn't play well with Pydantic
- "TC003", # Doesn't play well with Pydantic
"TD002", # Missing author in TODO
"TD003", # Missing issue link in TODO
diff --git a/libs/langchain_v1/tests/integration_tests/agents/middleware/test_shell_tool_integration.py b/libs/langchain_v1/tests/integration_tests/agents/middleware/test_shell_tool_integration.py
index c08cf50331..fc0b192c77 100644
--- a/libs/langchain_v1/tests/integration_tests/agents/middleware/test_shell_tool_integration.py
+++ b/libs/langchain_v1/tests/integration_tests/agents/middleware/test_shell_tool_integration.py
@@ -2,17 +2,21 @@
from __future__ import annotations
-from pathlib import Path
-from typing import Any
+from typing import TYPE_CHECKING, Any
import pytest
from langchain_core.messages import HumanMessage
from langchain_core.tools import tool
-from langgraph.graph.state import CompiledStateGraph
from langchain.agents import create_agent
from langchain.agents.middleware.shell_tool import ShellToolMiddleware
-from langchain.agents.middleware.types import _InputAgentState
+
+if TYPE_CHECKING:
+ from pathlib import Path
+
+ from langgraph.graph.state import CompiledStateGraph
+
+ from langchain.agents.middleware.types import _InputAgentState
def _get_model(provider: str) -> Any:
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_composition.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_composition.py
index 6d7c0889b5..ada493e1cb 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_composition.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_composition.py
@@ -1,13 +1,15 @@
"""Unit tests for _chain_model_call_handlers handler composition."""
-from typing import cast
+from typing import TYPE_CHECKING, cast
from langchain_core.messages import AIMessage
-from langgraph.runtime import Runtime
from langchain.agents.factory import _chain_model_call_handlers
from langchain.agents.middleware.types import ModelRequest, ModelResponse
+if TYPE_CHECKING:
+ from langgraph.runtime import Runtime
+
def create_test_request(**kwargs):
"""Helper to create a `ModelRequest` with sensible defaults."""
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_context_editing.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_context_editing.py
index e6349ebfcd..27740c2cd8 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_context_editing.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_context_editing.py
@@ -2,8 +2,7 @@
from __future__ import annotations
-from collections.abc import Iterable
-from typing import cast
+from typing import TYPE_CHECKING, cast
from langchain_core.language_models.fake_chat_models import FakeChatModel
from langchain_core.messages import (
@@ -11,7 +10,6 @@ from langchain_core.messages import (
MessageLikeRepresentation,
ToolMessage,
)
-from langgraph.runtime import Runtime
from langchain.agents.middleware.context_editing import (
ClearToolUsesEdit,
@@ -19,6 +17,11 @@ from langchain.agents.middleware.context_editing import (
)
from langchain.agents.middleware.types import AgentState, ModelRequest
+if TYPE_CHECKING:
+ from collections.abc import Iterable
+
+ from langgraph.runtime import Runtime
+
class _TokenCountingChatModel(FakeChatModel):
"""Fake chat model that counts tokens deterministically for tests."""
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_model_fallback.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_model_fallback.py
index ce7b0e23d6..a679ff69de 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_model_fallback.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_model_fallback.py
@@ -3,20 +3,22 @@
from __future__ import annotations
import warnings
-from typing import cast
+from typing import TYPE_CHECKING, cast
import pytest
from langchain_core.language_models.chat_models import BaseChatModel
from langchain_core.language_models.fake_chat_models import GenericFakeChatModel
from langchain_core.messages import AIMessage, HumanMessage
from langchain_core.outputs import ChatGeneration, ChatResult
-from langgraph.runtime import Runtime
from langchain.agents.factory import create_agent
from langchain.agents.middleware.model_fallback import ModelFallbackMiddleware
from langchain.agents.middleware.types import AgentState, ModelRequest, ModelResponse
from tests.unit_tests.agents.model import FakeToolCallingModel
+if TYPE_CHECKING:
+ from langgraph.runtime import Runtime
+
def _fake_runtime() -> Runtime:
return cast("Runtime", object())
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_shell_execution_policies.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_shell_execution_policies.py
index 7e13cf73d2..23404380a7 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_shell_execution_policies.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_shell_execution_policies.py
@@ -2,8 +2,7 @@ from __future__ import annotations
import os
import shutil
-from pathlib import Path
-from typing import Any
+from typing import TYPE_CHECKING, Any
import pytest
@@ -14,6 +13,9 @@ from langchain.agents.middleware.shell_tool import (
HostExecutionPolicy,
)
+if TYPE_CHECKING:
+ from pathlib import Path
+
def _make_resource(
*,
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_shell_tool.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_shell_tool.py
index 5125b471de..b2d86677cf 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_shell_tool.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_shell_tool.py
@@ -5,6 +5,7 @@ import gc
import tempfile
import time
from pathlib import Path
+from typing import TYPE_CHECKING
import pytest
from langchain_core.messages import ToolMessage
@@ -17,7 +18,9 @@ from langchain.agents.middleware.shell_tool import (
_SessionResources,
_ShellToolInput,
)
-from langchain.agents.middleware.types import AgentState
+
+if TYPE_CHECKING:
+ from langchain.agents.middleware.types import AgentState
def _empty_state() -> AgentState:
diff --git a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_todo.py b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_todo.py
index a3c2458a9d..3cea8263e4 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_todo.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_todo.py
@@ -2,12 +2,11 @@
from __future__ import annotations
-from typing import cast
+from typing import TYPE_CHECKING, cast
import pytest
from langchain_core.language_models.fake_chat_models import GenericFakeChatModel
from langchain_core.messages import AIMessage, HumanMessage
-from langgraph.runtime import Runtime
from langchain.agents.factory import create_agent
from langchain.agents.middleware.todo import (
@@ -20,6 +19,9 @@ from langchain.agents.middleware.todo import (
from langchain.agents.middleware.types import AgentState, ModelRequest, ModelResponse
from tests.unit_tests.agents.model import FakeToolCallingModel
+if TYPE_CHECKING:
+ from langgraph.runtime import Runtime
+
def _fake_runtime() -> Runtime:
return cast("Runtime", object())
diff --git a/libs/langchain_v1/tests/unit_tests/agents/test_state_schema.py b/libs/langchain_v1/tests/unit_tests/agents/test_state_schema.py
index d7bb9e57f5..5e21103e9d 100644
--- a/libs/langchain_v1/tests/unit_tests/agents/test_state_schema.py
+++ b/libs/langchain_v1/tests/unit_tests/agents/test_state_schema.py
@@ -13,7 +13,10 @@ from langchain_core.tools import tool
from langchain.agents import create_agent
from langchain.agents.middleware.types import AgentMiddleware, AgentState
-from langchain.tools import ToolRuntime
+
+# Cannot move ToolRuntime to TYPE_CHECKING as parameters of @tool annotated functions
+# are inspected at runtime.
+from langchain.tools import ToolRuntime # noqa: TC001
from .model import FakeToolCallingModel