The agent engineering platform.
Python agentsaiai-agentsanthropicchatgptdeepagentsenterpriseframeworkgeminigenerative-ailangchainlanggraphllmmultiagentopen-sourceopenaipydanticpythonragtypescript
fix(openai): accept valid responses that are falsy at runtime (#35307)
Mattijs Ugen5c6f8fe0a634
diff --git a/libs/partners/openai/langchain_openai/chat_models/base.py b/libs/partners/openai/langchain_openai/chat_models/base.pyindex 3a654a6451..c74c40f3c5 100644--- a/libs/partners/openai/langchain_openai/chat_models/base.py+++ b/libs/partners/openai/langchain_openai/chat_models/base.py@@ -3765,7 +3765,7 @@ def _convert_to_openai_response_format(def _oai_structured_outputs_parser(ai_msg: AIMessage, schema: type[_BM]) -> PydanticBaseModel | None:- if parsed := ai_msg.additional_kwargs.get("parsed"):+ if (parsed := ai_msg.additional_kwargs.get("parsed")) is not None:if isinstance(parsed, dict):return schema(**parsed)return parseddiff --git a/libs/partners/openai/tests/unit_tests/chat_models/test_base.py b/libs/partners/openai/tests/unit_tests/chat_models/test_base.pyindex c11ee325b5..438a1c4b60 100644--- a/libs/partners/openai/tests/unit_tests/chat_models/test_base.py+++ b/libs/partners/openai/tests/unit_tests/chat_models/test_base.py@@ -1388,6 +1388,26 @@ def test_structured_outputs_parser() -> None:assert result == parsed_response+def test_structured_outputs_parser_valid_falsy_response() -> None:+ class LunchBox(BaseModel):+ sandwiches: list[str]++ def __len__(self) -> int:+ return len(self.sandwiches)++ # prepare a valid *but falsy* response object, an empty LunchBox+ parsed_response = LunchBox(sandwiches=[])+ assert len(parsed_response) == 0+ llm_output = AIMessage(+ content='{"sandwiches": []}', additional_kwargs={"parsed": parsed_response}+ )+ output_parser = RunnableLambda(+ partial(_oai_structured_outputs_parser, schema=LunchBox)+ )+ result = output_parser.invoke(llm_output)+ assert result == parsed_response++def test__construct_lc_result_from_responses_api_error_handling() -> None:"""Test that errors in the response are properly raised."""response = Response(